[Bug 167147] Review Request: Aqsis - 3D Rendering system
by Red Hat Bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: Aqsis - 3D Rendering system
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=167147
------- Additional Comments From pgregory(a)aqsis.org 2007-01-18 05:40 EST -------
(In reply to comment #41)
> For this package, avoiding double compiling is more important.
> So if there is no other easy way to avoid this, please readd
> CFLAGS and CXXFLAGS on %install stage (and leave a comment
> about this on spec file)
>
> By the way, again, doesn't scons have the option like
> "--skip-build", which most "setup.py" scripts
> written in python have?
No, SCons is a very different tool to the Python packaging tools. Basically it
builds a complete dependency tree. The install depends on the build, and if the
build options change, the build has to be redone.
There are actually two options.
1) As mentioned, replace the CFLAGS and CXXFLAGS settings for the install phase
to ensure that the build options are identical.
2) Skip the 'build' phase altogether, the dependency setup for the 'install'
phase will ensure it builds before installing.
Whichever is most appropriate, the result will be the same.
Paul Gregory
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
17 years, 4 months
[Bug 167147] Review Request: Aqsis - 3D Rendering system
by Red Hat Bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: Aqsis - 3D Rendering system
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=167147
------- Additional Comments From mtasaka(a)ioa.s.u-tokyo.ac.jp 2007-01-17 22:13 EST -------
(In reply to comment #40)
> (In reply to comment #37)
> > * Compilation flags
> > - Well, please look at the build log.
> > This spec file:
> > 1. Once compile at %build stage using scons. At this time
> > compiler uses Fedora specific compilation flags.
> > 2. Next at %install stage, scons tries to compile all targets
> > once more!! At this stage, compiler does not use Fedora
> > specific compilation flags, so this is wrong.
> >
> This is a regression of a problem we had before. The problem is reintroduced by
> the 'fix' to a comment a couple of posts above, about removing the specification
> of CFLAGS and CXXFLAGS for the 'install' pass.
For this package, avoiding double compiling is more important.
So if there is no other easy way to avoid this, please readd
CFLAGS and CXXFLAGS on %install stage (and leave a comment
about this on spec file)
By the way, again, doesn't scons have the option like
"--skip-build", which most "setup.py" scripts
written in python have?
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
17 years, 4 months
[Bug 167147] Review Request: Aqsis - 3D Rendering system
by Red Hat Bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: Aqsis - 3D Rendering system
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=167147
------- Additional Comments From pgregory(a)aqsis.org 2007-01-17 18:06 EST -------
(In reply to comment #37)
> * Compilation flags
> - Well, please look at the build log.
> This spec file:
> 1. Once compile at %build stage using scons. At this time
> compiler uses Fedora specific compilation flags.
> 2. Next at %install stage, scons tries to compile all targets
> once more!! At this stage, compiler does not use Fedora
> specific compilation flags, so this is wrong.
>
> ? Doesn't scons accept the argument like --skip-build at
> install stage like usual "setup.py" written in python?
> ? Or are there any way to avoid twice compilation?
> - If not, move all compilation using scons to %install stage,
> compiling twice is redundant.
This is a regression of a problem we had before. The problem is reintroduced by
the 'fix' to a comment a couple of posts above, about removing the specification
of CFLAGS and CXXFLAGS for the 'install' pass. By removing those, the command
line to the compiler changes, which SCons sees as a dependency change, so
rebuilds all files with the new command line. The only way round this is to
leave the CFLAGS and CXXFLAGS declarations in the 'install' pass so that the
settings seen by SCons are identical to those used during the 'build' pass.
Paul Gregory
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
17 years, 4 months
[Bug 167147] Review Request: Aqsis - 3D Rendering system
by Red Hat Bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: Aqsis - 3D Rendering system
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=167147
------- Additional Comments From mtasaka(a)ioa.s.u-tokyo.ac.jp 2007-01-17 11:17 EST -------
Well, much improvement for this package!!
A. Packaging issue (mainly in
http://fedoraproject.org/wiki/Packaging/Guidelines )
So, first full review.
(Again note: please increase the release number
when you change the spec file, and reset the release
number when you use new source).
* Requires:
-------------------------------------------------------
Requires: fltk >= 1.1.0, libjpeg >= 6b, libtiff >= 3.7.1, OpenEXR
-------------------------------------------------------
These should not be needed. Libraries' dependencies automatically
checked by rpmbuild correctly pull these dependencies.
* Documentation
- "INSTALL" should not be necessary. This is needed for
people who want to rebuild this package by themselves.
* ChangeLog
- 1.2.0-0.6alpha2
should be 1.2.0-0.6.alpha2
* Compilation flags
- Well, please look at the build log.
This spec file:
1. Once compile at %build stage using scons. At this time
compiler uses Fedora specific compilation flags.
2. Next at %install stage, scons tries to compile all targets
once more!! At this stage, compiler does not use Fedora
specific compilation flags, so this is wrong.
? Doesn't scons accept the argument like --skip-build at
install stage like usual "setup.py" written in python?
? Or are there any way to avoid twice compilation?
- If not, move all compilation using scons to %install stage,
compiling twice is redundant.
* Encodings:
- Please change the encoding of the following file(s)
to UTF-8.
-----------------------------------------------------
/usr/share/doc/aqsis-1.2.0/AUTHORS: ISO-8859 English text
-----------------------------------------------------
= (not a blocker) If you are upstream, please change all
text files to UTF-8 for next tarball.
= License (okay)
= Some files are licensed not under LGPL or GPL.
./displays/d_sdcBMP/d_sdcBMP.cpp
./displays/d_sdcWin32/d_sdcWin32.cpp
./shadercompiler/slpp/pp*
./displays/d_exr/dspyhlpr.c
./displays/d_sdcWin32/interface.c
./displays/d_sdcWin32/d_sdcWin32.h
= None of them conflicts with GPL.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
17 years, 5 months
[Bug 167147] Review Request: Aqsis - 3D Rendering system
by Red Hat Bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: Aqsis - 3D Rendering system
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=167147
------- Additional Comments From kwizart(a)gmail.com 2007-01-16 20:22 EST -------
It will not build on x86_64!
You should add:
ExclusiveArch: i386
Or
Only patch it on x86_64 with an experimental support
%ifarch x86_64
%patch0 -p1
%endif
I also wonder why the plugin dir is in /usr/lib in x86_64 if your spec file
libdir=%{_libdir} it will work fine depending on the choice above...
Some build quotes:
--------------------------
...
tall_prefix=/usr sysconfdir=/etc no_rpath=true build
scons: Reading SConscript files ...
Looking for build directory for platform 'linux2'
Exact match not found, finding closest guess
No match found, looking for 'default' directory
Found configuration directory platform/default, will use that
...
build/shadercompiler/shadervm/shadervm.cpp: In member function 'void
Aqsis::CqShaderVM::LoadProgram(std::istream*)':
build/shadercompiler/shadervm/shadervm.cpp:1108: error: cast from 'void*' to
'int' loses precision
scons: *** [build/shadercompiler/shadervm/shadervm.os] Error 1
scons: building terminated because of errors.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
17 years, 5 months