[Bug 494650] New: [Intel 6.0 FEAT] Review request: libhbaapi - SNIA HBAAPI library
by Red Hat Bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
Summary: [Intel 6.0 FEAT] Review request: libhbaapi - SNIA HBAAPI library
https://bugzilla.redhat.com/show_bug.cgi?id=494650
Summary: [Intel 6.0 FEAT] Review request: libhbaapi - SNIA
HBAAPI library
Product: Red Hat Enterprise Linux 6
Version: 6.0
Platform: All
OS/Version: Linux
Status: NEW
Severity: medium
Priority: medium
Component: Package Review
AssignedTo: nobody(a)redhat.com
ReportedBy: jvillalo(a)redhat.com
CC: notting(a)redhat.com, mchristi(a)redhat.com,
syeghiay(a)redhat.com, pm-rhel(a)redhat.com,
fedora-package-review(a)redhat.com
Blocks: 442586
Estimated Hours: 0.0
Classification: Red Hat
Target Release: ---
Clone Of: 494546
+++ This bug was initially created as a clone of Bug #494546 +++
+++ This bug was initially created as a clone of Bug #489929 +++
Spec URL: http://jzeleny.fedorapeople.org/packages/libhbaapi/libhbaapi.spec
SRPM URL:
http://jzeleny.fedorapeople.org/packages/libhbaapi/libHBAAPI-2.2-2.fc10.s...
Description:
Package contains HBA API library, used as a wrapper for other vendor specific
libraries. Package will be used as a connector between FCoE Utilities and
libhalinux.
--- Additional comment from dan(a)danny.cz on 2009-03-30 10:13:18 EDT ---
formal review is here, see the notes below:
BAD source files match upstream:
BAD package meets naming and versioning guidelines.
OK specfile is properly named, is cleanly written and uses macros consistently.
OK dist tag is present.
OK license field matches the actual license.
OK license is open source-compatible. License text not included upstream.
OK latest version is being packaged.
OK BuildRequires are proper.
OK compiler flags are appropriate.
OK %clean is present.
OK package builds in mock (Rawhide/x86_64).
OK debuginfo package looks complete.
OK* rpmlint is silent.
OK final provides and requires look sane.
N/A %check is present and all tests pass.
OK shared libraries are added to the regular linker search paths.
OK owns the directories it creates.
OK doesn't own any directories it shouldn't.
OK no duplicates in %files.
OK file permissions are appropriate.
OK correct scriptlets present.
OK code, not content.
OK documentation is small, so no -docs subpackage is necessary.
OK %docs are not necessary for the proper functioning of the package.
OK headers in -devel
OK pkgconfig files in -devel
OK no libtool .la droppings.
OK not a GUI app.
- full URLs for Sources are missing
- the %name tag should be all in lowercase to be consistent with archive name
(https://fedoraproject.org/wiki/Packaging/NamingGuidelines)
- it's preferred to have the Requires for the devel sub-package on separate
lines
- rpmlint complains a bit:
libHBAAPI-debuginfo.x86_64: W: invalid-license SNIA
libHBAAPI-devel.x86_64: W: invalid-license SNIA
libHBAAPI.src: W: invalid-license SNIA
libHBAAPI.x86_64: W: invalid-license SNIA
=> SNIA license was recently added to the list of good licenses and is not yet
known to rpmlint
libHBAAPI.src: E: invalid-spec-name
=> package name and spec filename are not in sync
libHBAAPI-devel.x86_64: W: no-documentation
=> can be ignored
- you can apply the "includes" patch supplied by the hbaapi_build archive
instead of using an own copy
--- Additional comment from jzeleny(a)redhat.com on 2009-03-31 05:42:35 EDT ---
Updated SPEC: http://jzeleny.fedorapeople.org/packages/libhbaapi/libhbaapi.spec
Updated SRPM:
http://jzeleny.fedorapeople.org/packages/libhbaapi/libhbaapi-2.2-3.fc10.s...
--- Additional comment from dan(a)danny.cz on 2009-03-31 06:34:22 EDT ---
- the hbaapi_build_2.2.tar.gz tarball differs between this package and upstream
URL (length 674018 vs. 672470)
- the %description for the main package could be more verbose
--- Additional comment from dan(a)danny.cz on 2009-03-31 06:37:04 EDT ---
link to the thread about the SNIA license on fedora-legal mailing list -
https://www.redhat.com/archives/fedora-legal-list/2009-February/msg00033....
--- Additional comment from jzeleny(a)redhat.com on 2009-04-01 09:09:11 EDT ---
Updated SPEC: http://jzeleny.fedorapeople.org/packages/libhbaapi/libhbaapi.spec
Updated SRPM:
http://jzeleny.fedorapeople.org/packages/libhbaapi/libhbaapi-2.2-4.fc10.s...
I added one line to the description. It's not much, but hopefully it's enough
for now.
--- Additional comment from dan(a)danny.cz on 2009-04-01 10:15:39 EDT ---
All issues are fixed, this package is APPROVED.
--- Additional comment from jzeleny(a)redhat.com on 2009-04-02 03:40:24 EDT ---
New Package CVS Request
=======================
Package Name: libhbaapi
Short Description: Package contains HBA API
library. It will be used as a connector
between FCoE Utilities and libhbalinux.
Owners: jzeleny
Branches:
InitialCC:
--- Additional comment from kevin(a)tummy.com on 2009-04-03 16:41:57 EDT ---
I used "SNIA HBAAPI library" as the Short Description as that seems more
correct.
cvs done.
--- Additional comment from pm-rhel(a)redhat.com on 2009-04-07 08:36:44 EDT ---
This request was evaluated by Red Hat Product Management for
inclusion, but this component is not scheduled to be updated in
the current Red Hat Enterprise Linux release. If you would like
this request to be reviewed for the next minor release, ask your
support representative to set the next rhel-x.y flag to "?".
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
15 years, 1 month
[Bug 494555] New: Review request: fcoe-utils - utilities for fibre channel over ethernet
by Red Hat Bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
Summary: Review request: fcoe-utils - utilities for fibre channel over ethernet
https://bugzilla.redhat.com/show_bug.cgi?id=494555
Summary: Review request: fcoe-utils - utilities for fibre
channel over ethernet
Product: Red Hat Enterprise Linux 5
Version: 5.4
Platform: All
OS/Version: Linux
Status: NEW
Severity: medium
Priority: low
Component: distribution
AssignedTo: pm-rhel(a)redhat.com
ReportedBy: rpacheco(a)redhat.com
QAContact: release-test-team(a)redhat.com
CC: notting(a)redhat.com, mchristi(a)redhat.com,
pm-rhel(a)redhat.com, fedora-package-review(a)redhat.com
Depends on: 494553
Estimated Hours: 0.0
Classification: Red Hat
Target Release: ---
Clone Of: 494553
Ronald Pacheco <rpacheco(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flag| |pm_ack?, devel_ack?,
| |qa_ack?
+++ This bug was initially created as a clone of Bug #494553 +++
+++ This bug was initially created as a clone of Bug #493958 +++
SRPM:
http://jzeleny.fedorapeople.org/packages/fcoe-utils/fcoe-utils-1.0.7-2.fc...
SPEC: http://jzeleny.fedorapeople.org/packages/fcoe-utils/fcoe-utils.spec
Fibre Channel over Ethernet utilities:
fcoeadm - command line tool for configuring FCoE interfaces
fcoemon - service to configure DCB Ethernet QOS filters, works with dcbd
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
15 years, 1 month
[Bug 494548] New: Review request: libhbaapi - SNIA HBAAPI library
by Red Hat Bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
Summary: Review request: libhbaapi - SNIA HBAAPI library
https://bugzilla.redhat.com/show_bug.cgi?id=494548
Summary: Review request: libhbaapi - SNIA HBAAPI library
Product: Red Hat Enterprise Linux 5
Version: 5.4
Platform: All
OS/Version: Linux
Status: NEW
Severity: medium
Priority: medium
Component: distribution
AssignedTo: pm-rhel(a)redhat.com
ReportedBy: rpacheco(a)redhat.com
QAContact: release-test-team(a)redhat.com
CC: notting(a)redhat.com, mchristi(a)redhat.com,
pm-rhel(a)redhat.com, fedora-package-review(a)redhat.com
Depends on: 494546
Estimated Hours: 0.0
Classification: Red Hat
Target Release: ---
Clone Of: 494546
Ronald Pacheco <rpacheco(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flag| |pm_ack?, devel_ack?,
| |qa_ack?
+++ This bug was initially created as a clone of Bug #494546 +++
+++ This bug was initially created as a clone of Bug #489929 +++
Spec URL: http://jzeleny.fedorapeople.org/packages/libhbaapi/libhbaapi.spec
SRPM URL:
http://jzeleny.fedorapeople.org/packages/libhbaapi/libHBAAPI-2.2-2.fc10.s...
Description:
Package contains HBA API library, used as a wrapper for other vendor specific
libraries. Package will be used as a connector between FCoE Utilities and
libhalinux.
--- Additional comment from dan(a)danny.cz on 2009-03-30 10:13:18 EDT ---
formal review is here, see the notes below:
BAD source files match upstream:
BAD package meets naming and versioning guidelines.
OK specfile is properly named, is cleanly written and uses macros consistently.
OK dist tag is present.
OK license field matches the actual license.
OK license is open source-compatible. License text not included upstream.
OK latest version is being packaged.
OK BuildRequires are proper.
OK compiler flags are appropriate.
OK %clean is present.
OK package builds in mock (Rawhide/x86_64).
OK debuginfo package looks complete.
OK* rpmlint is silent.
OK final provides and requires look sane.
N/A %check is present and all tests pass.
OK shared libraries are added to the regular linker search paths.
OK owns the directories it creates.
OK doesn't own any directories it shouldn't.
OK no duplicates in %files.
OK file permissions are appropriate.
OK correct scriptlets present.
OK code, not content.
OK documentation is small, so no -docs subpackage is necessary.
OK %docs are not necessary for the proper functioning of the package.
OK headers in -devel
OK pkgconfig files in -devel
OK no libtool .la droppings.
OK not a GUI app.
- full URLs for Sources are missing
- the %name tag should be all in lowercase to be consistent with archive name
(https://fedoraproject.org/wiki/Packaging/NamingGuidelines)
- it's preferred to have the Requires for the devel sub-package on separate
lines
- rpmlint complains a bit:
libHBAAPI-debuginfo.x86_64: W: invalid-license SNIA
libHBAAPI-devel.x86_64: W: invalid-license SNIA
libHBAAPI.src: W: invalid-license SNIA
libHBAAPI.x86_64: W: invalid-license SNIA
=> SNIA license was recently added to the list of good licenses and is not yet
known to rpmlint
libHBAAPI.src: E: invalid-spec-name
=> package name and spec filename are not in sync
libHBAAPI-devel.x86_64: W: no-documentation
=> can be ignored
- you can apply the "includes" patch supplied by the hbaapi_build archive
instead of using an own copy
--- Additional comment from jzeleny(a)redhat.com on 2009-03-31 05:42:35 EDT ---
Updated SPEC: http://jzeleny.fedorapeople.org/packages/libhbaapi/libhbaapi.spec
Updated SRPM:
http://jzeleny.fedorapeople.org/packages/libhbaapi/libhbaapi-2.2-3.fc10.s...
--- Additional comment from dan(a)danny.cz on 2009-03-31 06:34:22 EDT ---
- the hbaapi_build_2.2.tar.gz tarball differs between this package and upstream
URL (length 674018 vs. 672470)
- the %description for the main package could be more verbose
--- Additional comment from dan(a)danny.cz on 2009-03-31 06:37:04 EDT ---
link to the thread about the SNIA license on fedora-legal mailing list -
https://www.redhat.com/archives/fedora-legal-list/2009-February/msg00033....
--- Additional comment from jzeleny(a)redhat.com on 2009-04-01 09:09:11 EDT ---
Updated SPEC: http://jzeleny.fedorapeople.org/packages/libhbaapi/libhbaapi.spec
Updated SRPM:
http://jzeleny.fedorapeople.org/packages/libhbaapi/libhbaapi-2.2-4.fc10.s...
I added one line to the description. It's not much, but hopefully it's enough
for now.
--- Additional comment from dan(a)danny.cz on 2009-04-01 10:15:39 EDT ---
All issues are fixed, this package is APPROVED.
--- Additional comment from jzeleny(a)redhat.com on 2009-04-02 03:40:24 EDT ---
New Package CVS Request
=======================
Package Name: libhbaapi
Short Description: Package contains HBA API
library. It will be used as a connector
between FCoE Utilities and libhbalinux.
Owners: jzeleny
Branches:
InitialCC:
--- Additional comment from kevin(a)tummy.com on 2009-04-03 16:41:57 EDT ---
I used "SNIA HBAAPI library" as the Short Description as that seems more
correct.
cvs done.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
15 years, 1 month
[Bug 454010] New: Review Request: iaxclient - Library for creating telephony solutions that interoperate with Asterisk
by Red Hat Bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=454010
Summary: Review Request: iaxclient - Library for creating
telephony solutions that interoperate with Asterisk
Product: Fedora
Version: rawhide
Platform: All
OS/Version: Linux
Status: NEW
Severity: medium
Priority: medium
Component: Package Review
AssignedTo: nobody(a)fedoraproject.org
ReportedBy: tcallawa(a)redhat.com
QAContact: extras-qa(a)fedoraproject.org
CC: fedora-package-review@redhat.com,notting(a)redhat.com
Spec URL: http://auroralinux.org/people/spot/review/coccinella/iaxclient.spec
SRPM URL: http://auroralinux.org/people/spot/review/coccinella/iaxclient-2.1-0.1.be...
Description:
Iaxclient is an open source, multiplatform library for creating telephony
solutions that interoperate with Asterisk, the Open Source PBX.
Although asterisk supports other VOIP protocols (including SIP, and with
patches, H.323), IAX's simple, lightweight nature gives it several advantages,
particularly in that it can operate easily through NAT and packet firewalls,
and it is easily extensible and simple to understand.
Iaxclient pulls together the wide array of open source technologies required
for telephony applications.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
15 years, 1 month
[Bug 488172] New: Package Review: ibus-table-wubi
by Red Hat Bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
Summary: Package Review: ibus-table-wubi
https://bugzilla.redhat.com/show_bug.cgi?id=488172
Summary: Package Review: ibus-table-wubi
Product: Fedora
Version: rawhide
Platform: All
OS/Version: Linux
Status: NEW
Keywords: i18n
Severity: medium
Priority: low
Component: Package Review
AssignedTo: petersen(a)redhat.com
ReportedBy: cchance(a)redhat.com
QAContact: extras-qa(a)fedoraproject.org
CC: notting(a)redhat.com, petersen(a)redhat.com,
fedora-package-review(a)redhat.com, cchance(a)redhat.com,
phuang(a)redhat.com, fedora-i18n-bugs(a)redhat.com
Depends on: 488010
Blocks: 484650
Estimated Hours: 0.0
Classification: Fedora
Target Release: ---
A split from ibus-table-chinese, which was sub-package of ibus-table.
Uploading srpm and spec.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
15 years, 1 month