[Bug 1462412] New: Review Request: tworld - a puzzle game
by bugzilla@redhat.com
https://bugzilla.redhat.com/show_bug.cgi?id=1462412
Bug ID: 1462412
Summary: Review Request: tworld - a puzzle game
Product: Fedora
Version: rawhide
Component: Package Review
Severity: medium
Priority: medium
Assignee: nobody(a)fedoraproject.org
Reporter: fedora(a)svgames.pl
QA Contact: extras-qa(a)fedoraproject.org
CC: package-review(a)lists.fedoraproject.org
Spec URL: https://svgames.pl/fedora/tworld-1.3.2-2.spec
SRPM URL: https://svgames.pl/fedora/tworld-1.3.2-2.src.rpm
koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=20053999
Description: Tile World is an emulation of the game "Chip's Challenge" for the
Atari Lynx. The game has its own graphics set and can be played using
community-created level sets, without the need for the original game's
resources.
Fedora Account System Username: suve
The packaging is a bit unorthodox, as the licences for the level packs are
rather restrictive (basically - free redistribution, no modification). Thus, I
decided to split the package into three: apart from the usual main package and
-data, the level packs go into their own subpackage, -cclp.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
6 years, 10 months
[Bug 1421506] New: Review Request: smlnj - Standard ML of New Jersey
by bugzilla@redhat.com
https://bugzilla.redhat.com/show_bug.cgi?id=1421506
Bug ID: 1421506
Summary: Review Request: smlnj - Standard ML of New Jersey
Product: Fedora
Version: rawhide
Component: Package Review
Severity: medium
Priority: medium
Assignee: nobody(a)fedoraproject.org
Reporter: dmoerner(a)gmail.com
QA Contact: extras-qa(a)fedoraproject.org
CC: package-review(a)lists.fedoraproject.org
Spec URL: https://dmoerner.fedorapeople.org/smlnj/smlnj.spec
SRPM URL: https://dmoerner.fedorapeople.org/smlnj/smlnj-110.80-1.fc26.src.rpm
Description: Standard ML of New Jersey (SML/NJ) is a compiler and programming
environment
for the Standard ML programming language. It was originally developed jointly
at Bell Laboratories and Princeton University, and is now a joint project
between researchers at Bell Laboratories, Lucent Technologies, Princeton
University, Yale University (The FLINT Project), AT&T Research, and the
University of Chicago.
Fedora Account System Username: dmoerner
This is a complicated spec and review. I welcome all feedback, even if you are
not in a position to offer a full review. I have built on previous work by
Ricky Zhou in an older review request,
https://bugzilla.redhat.com/show_bug.cgi?id=670088
Comments for potential reviewers:
1. Note that this package is self-bootstrapping, and so will need Fedora
Packaging Committee approval.
Successful koji build using upstream precompiled binaries:
https://koji.fedoraproject.org/koji/taskinfo?taskID=17823150
Logs and rpms from successful local mock self-bootstrapping using the koji
rpms:
https://dmoerner.fedorapeople.org/smlnj/self-bootstrap-logs/
2. SML/NJ is 32-bit only, and of the 32 bit arches available in Fedora, has
only been bootstrapped on x86. After asking around in IRC, I made the package
ExclusiveArch: %{ix86}. If this is incorrect, and I should use ExcludeArch, it
is easy to change.
(I do not believe that being only available on x86 makes SML/NJ a bad candidate
for the archive. Upstream is still active, and very slowly working on 64-bit
support, and SML/NJ is actively used in a variety of academic environments.)
3. Upstream builds a static library, which can be used by the user to build
statically linked SML binaries using the supplied heap2exec script. I have
chosen to package this library in a separate -static subpackage. It could,
however, just be removed entirely.
4. rpmlint output and commentary:
smlnj.i686: E: missing-call-to-setgroups-before-setuid
/usr/lib/smlnj/bin/.run/run.x86-linux.so
smlnj.i686: E: missing-call-to-setgroups-before-setuid
/usr/lib/smlnj/bin/.run/run.x86-linux
I have looked carefully into this and I believe that this is not an issue. The
setuid calls come base/runtime/c-libs/posix-procenv/setuid.c, part of where
SML/NJ implements an SML function for the C setuid command, as part of
implementing POSIX.1-2001. There could be a risk here that a user-constructed
SML program could use this function in a dangerous way. But so far as I can
see, this is a risk shared by any compiler that only implements POSIX.1-2001,
of which setgroups is not a part.
smlnj.i686: W: hidden-file-or-dir /usr/lib/smlnj/bin/.run-sml
smlnj.i686: W: hidden-file-or-dir /usr/lib/smlnj/bin/.heap
smlnj.i686: W: hidden-file-or-dir /usr/lib/smlnj/bin/.heap
smlnj.i686: W: hidden-file-or-dir /usr/lib/smlnj/bin/.arch-n-opsys
smlnj.i686: W: hidden-file-or-dir /usr/lib/smlnj/bin/.run
smlnj.i686: W: hidden-file-or-dir /usr/lib/smlnj/bin/.run
smlnj.i686: W: hidden-file-or-dir /usr/lib/smlnj/bin/.link-sml
These hidden files are baked into upstream. I removed about 170 of these
warnings by setting the variable CM_DIR_ARC, but these last 7 cannot be removed
without major patching.
smlnj-static.i686: W: no-documentation
No issue; see note #3 above.
Thanks!
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
6 years, 10 months
[Bug 1449328] New: Review Request:
zfp - Library for compressed numerical arrays with high throughput R/
W random access
by bugzilla@redhat.com
https://bugzilla.redhat.com/show_bug.cgi?id=1449328
Bug ID: 1449328
Summary: Review Request: zfp - Library for compressed numerical
arrays with high throughput R/W random access
Product: Fedora
Version: rawhide
Component: Package Review
Severity: medium
Priority: medium
Assignee: nobody(a)fedoraproject.org
Reporter: orion(a)cora.nwra.com
QA Contact: extras-qa(a)fedoraproject.org
CC: package-review(a)lists.fedoraproject.org
Spec URL: https://www.cora.nwra.com/~orion/fedora/zfp.spec
SRPM URL: https://www.cora.nwra.com/~orion/fedora/zfp-0.5.1-1.el7.src.rpm
Description:
This is zfp, an open source C/C++ library for compressed numerical arrays
that support high throughput read and write random access. zfp was written by
Peter Lindstrom at Lawrence Livermore National Laboratory, and is loosely
based on the algorithm described in the following paper:
Peter Lindstrom
"Fixed-Rate Compressed Floating-Point Arrays"
IEEE Transactions on Visualization and Computer Graphics,
20(12):2674-2683, December 2014
doi:10.1109/TVCG.2014.2346458
zfp was originally designed for floating-point data only, but has been
extended to also support integer data, and could for instance be used to
compress images and quantized volumetric data. To achieve high compression
ratios, zfp uses lossy but optionally error-bounded compression. Although
bit-for-bit lossless compression of floating-point data is not always
possible, zfp is usually accurate to within machine epsilon in near-lossless
mode.
zfp works best for 2D and 3D arrays that exhibit spatial coherence, such as
smooth fields from physics simulations, images, regularly sampled terrain
surfaces, etc. Although zfp also provides a 1D array class that can be used
for 1D signals such as audio, or even unstructured floating-point streams,
the compression scheme has not been well optimized for this use case, and
rate and quality may not be competitive with floating-point compressors
designed specifically for 1D streams.
Fedora Account System Username: orion
https://koji.fedoraproject.org/koji/taskinfo?taskID=19475761
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
6 years, 10 months