[Bug 1546544] Review Request: bear-factory - renaming the bear
package
by bugzilla＠redhat.com
https://bugzilla.redhat.com/show_bug.cgi?id=1546544
MartinKG <mgansser(a)online.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|Re-Review Request: renaming |Review Request:
|package bear to |bear-factory - renaming the
|bear-factory - A engine |bear package
|with a set of tools, namely |
|the bear-factory |
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
5 years, 7 months
[Bug 1546544] Re-Review Request: renaming package bear to
bear-factory
by bugzilla＠redhat.com
https://bugzilla.redhat.com/show_bug.cgi?id=1546544
Till Hofmann <thofmann(a)fedoraproject.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags| |fedora-review+
--- Comment #9 from Till Hofmann <thofmann(a)fedoraproject.org> ---
Package Review
==============
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
=======
- Missing -p parameter for install invocations
- Some files do not have proper license headers
- Afaik, the package should not obsolete bear <= 0.7.0-0.21 because there was
never a bear package (just the source package)
===== MUST items =====
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "GPL (v2 or later)", "Unknown or generated". 1919 files have
unknown license. Detailed output of licensecheck in
/home/thofmann/fedora/reviews/1546544-bear-factory/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[-]: If the package is under multiple licenses, the licensing breakdown
must be documented in the spec.
[x]: Package does not own files or directories owned by other packages.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Development files must be in a -devel package
[-]: Package uses nothing in %doc for runtime.
[x]: The spec file handles locales properly.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 30720 bytes in 3 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or
desktop-file-validate if there is such a file.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in bear-
engine , bear-factory-devel , bear-factory-debugsource
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Scriptlets must be sane, if used.
[x]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[x]: %check is present and all tests pass.
[!]: Packages should try to preserve timestamps of original installed
files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic:
[x]: Rpmlint is run on all installed packages.
Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
is arched.
[x]: Spec file according to URL is the same as in SRPM.
Rpmlint
-------
Checking: bear-factory-0.7.0-0.22.20180825git2a78522.fc28.x86_64.rpm
bear-engine-0.7.0-0.22.20180825git2a78522.fc28.x86_64.rpm
bear-factory-devel-0.7.0-0.22.20180825git2a78522.fc28.x86_64.rpm
bear-factory-debugsource-0.7.0-0.22.20180825git2a78522.fc28.x86_64.rpm
bear-factory-0.7.0-0.22.20180825git2a78522.fc28.src.rpm
bear-factory.x86_64: W: spelling-error %description -l en_US plee -> peel, pee,
lee
bear-factory.x86_64: W: spelling-error %description -l en_US asgp -> asp, gasp,
asap
bear-factory.x86_64: W: obsolete-not-provided bear
bear-factory.x86_64: E: no-binary
bear-factory.x86_64: W: desktopfile-without-binary
/usr/share/applications/bf-animation-editor.desktop bf-animation-editor
bear-factory.x86_64: W: desktopfile-without-binary
/usr/share/applications/bf-level-editor.desktop bf-level-editor
bear-factory.x86_64: W: desktopfile-without-binary
/usr/share/applications/bf-model-editor.desktop bf-model-editor
bear-factory.x86_64: W: desktopfile-without-binary
/usr/share/applications/desc2img.desktop desc2img
bear-engine.x86_64: W: spelling-error %description -l en_US plee -> peel, pee,
lee
bear-engine.x86_64: W: spelling-error %description -l en_US asgp -> asp, gasp,
asap
bear-engine.x86_64: E: invalid-soname /usr/lib64/libbear_audio.so
libbear_audio.so
bear-engine.x86_64: E: invalid-soname /usr/lib64/libbear_communication.so
libbear_communication.so
bear-engine.x86_64: E: invalid-soname /usr/lib64/libbear_debug.so
libbear_debug.so
bear-engine.x86_64: E: invalid-soname /usr/lib64/libbear_engine.so
libbear_engine.so
bear-engine.x86_64: E: invalid-soname /usr/lib64/libbear_expr.so
libbear_expr.so
bear-engine.x86_64: E: invalid-soname /usr/lib64/libbear_generic_items.so
libbear_generic_items.so
bear-engine.x86_64: E: invalid-soname /usr/lib64/libbear_gui.so libbear_gui.so
bear-engine.x86_64: E: invalid-soname /usr/lib64/libbear_input.so
libbear_input.so
bear-engine.x86_64: E: invalid-soname /usr/lib64/libbear_net.so libbear_net.so
bear-engine.x86_64: E: invalid-soname /usr/lib64/libbear_text_interface.so
libbear_text_interface.so
bear-engine.x86_64: E: invalid-soname /usr/lib64/libbear_time.so
libbear_time.so
bear-engine.x86_64: E: invalid-soname /usr/lib64/libbear_universe.so
libbear_universe.so
bear-engine.x86_64: E: invalid-soname /usr/lib64/libbear_visual.so
libbear_visual.so
bear-factory.src: W: spelling-error %description -l en_US plee -> peel, pee,
lee
bear-factory.src: W: spelling-error %description -l en_US asgp -> asp, gasp,
asap
5 packages and 0 specfiles checked; 14 errors, 11 warnings.
Rpmlint (installed packages)
----------------------------
sh: /usr/bin/python: No such file or directory
bear-factory-debugsource.x86_64: W: invalid-url URL:
https://github.com/j-jorge/bear <urlopen error [Errno -2] Name or service not
known>
bear-factory-devel.x86_64: W: invalid-url URL: https://github.com/j-jorge/bear
<urlopen error [Errno -2] Name or service not known>
bear-engine.x86_64: W: spelling-error %description -l en_US plee -> peel, pee,
lee
bear-engine.x86_64: W: spelling-error %description -l en_US asgp -> asp, gasp,
asap
bear-engine.x86_64: W: invalid-url URL: https://github.com/j-jorge/bear
<urlopen error [Errno -2] Name or service not known>
bear-engine.x86_64: E: invalid-soname /usr/lib64/libbear_audio.so
libbear_audio.so
bear-engine.x86_64: E: invalid-soname /usr/lib64/libbear_communication.so
libbear_communication.so
bear-engine.x86_64: E: invalid-soname /usr/lib64/libbear_debug.so
libbear_debug.so
bear-engine.x86_64: E: invalid-soname /usr/lib64/libbear_engine.so
libbear_engine.so
bear-engine.x86_64: E: invalid-soname /usr/lib64/libbear_expr.so
libbear_expr.so
bear-engine.x86_64: E: invalid-soname /usr/lib64/libbear_generic_items.so
libbear_generic_items.so
bear-engine.x86_64: E: invalid-soname /usr/lib64/libbear_gui.so libbear_gui.so
bear-engine.x86_64: E: invalid-soname /usr/lib64/libbear_input.so
libbear_input.so
bear-engine.x86_64: E: invalid-soname /usr/lib64/libbear_net.so libbear_net.so
bear-engine.x86_64: E: invalid-soname /usr/lib64/libbear_text_interface.so
libbear_text_interface.so
bear-engine.x86_64: E: invalid-soname /usr/lib64/libbear_time.so
libbear_time.so
bear-engine.x86_64: E: invalid-soname /usr/lib64/libbear_universe.so
libbear_universe.so
bear-engine.x86_64: E: invalid-soname /usr/lib64/libbear_visual.so
libbear_visual.so
bear-factory.x86_64: W: spelling-error %description -l en_US plee -> peel, pee,
lee
bear-factory.x86_64: W: spelling-error %description -l en_US asgp -> asp, gasp,
asap
bear-factory.x86_64: W: invalid-url URL: https://github.com/j-jorge/bear
<urlopen error [Errno -2] Name or service not known>
bear-factory.x86_64: W: obsolete-not-provided bear
bear-factory.x86_64: E: no-binary
bear-factory.x86_64: W: desktopfile-without-binary
/usr/share/applications/bf-animation-editor.desktop bf-animation-editor
bear-factory.x86_64: W: desktopfile-without-binary
/usr/share/applications/bf-level-editor.desktop bf-level-editor
bear-factory.x86_64: W: desktopfile-without-binary
/usr/share/applications/bf-model-editor.desktop bf-model-editor
bear-factory.x86_64: W: desktopfile-without-binary
/usr/share/applications/desc2img.desktop desc2img
4 packages and 0 specfiles checked; 14 errors, 13 warnings.
Requires
--------
bear-factory-debugsource (rpmlib, GLIBC filtered):
bear-factory-devel (rpmlib, GLIBC filtered):
bear-engine(x86-64)
cmake-filesystem
bear-engine (rpmlib, GLIBC filtered):
libGL.so.1()(64bit)
libGLU.so.1()(64bit)
libSDL2-2.0.so.0()(64bit)
libSDL2_mixer-2.0.so.0()(64bit)
libbear_audio.so()(64bit)
libbear_communication.so()(64bit)
libbear_debug.so()(64bit)
libbear_engine.so()(64bit)
libbear_expr.so()(64bit)
libbear_gui.so()(64bit)
libbear_input.so()(64bit)
libbear_net.so()(64bit)
libbear_text_interface.so()(64bit)
libbear_time.so()(64bit)
libbear_universe.so()(64bit)
libbear_visual.so()(64bit)
libboost_filesystem.so.1.66.0()(64bit)
libboost_regex.so.1.66.0()(64bit)
libboost_system.so.1.66.0()(64bit)
libboost_thread.so.1.66.0()(64bit)
libc.so.6()(64bit)
libclaw_application.so.1()(64bit)
libclaw_dynamic_library.so.1()(64bit)
libclaw_graphic.so.1()(64bit)
libclaw_logger.so.1()(64bit)
libclaw_net.so.1()(64bit)
libclaw_tween.so.1()(64bit)
libdl.so.2()(64bit)
libfreetype.so.6()(64bit)
libgcc_s.so.1()(64bit)
libgcc_s.so.1(GCC_3.0)(64bit)
libjpeg.so.62()(64bit)
libm.so.6()(64bit)
libpng16.so.16()(64bit)
libpthread.so.0()(64bit)
libstdc++.so.6()(64bit)
libstdc++.so.6(CXXABI_1.3)(64bit)
libstdc++.so.6(CXXABI_1.3.5)(64bit)
libstdc++.so.6(CXXABI_1.3.8)(64bit)
libz.so.1()(64bit)
rtld(GNU_HASH)
bear-factory (rpmlib, GLIBC filtered):
hicolor-icon-theme
Provides
--------
bear-factory-debugsource:
bear-factory-debugsource
bear-factory-debugsource(x86-64)
bear-factory-devel:
bear-factory-devel
bear-factory-devel(x86-64)
cmake(bear)
bear-engine:
bear-engine
bear-engine(x86-64)
libbear_audio.so()(64bit)
libbear_communication.so()(64bit)
libbear_debug.so()(64bit)
libbear_engine.so()(64bit)
libbear_expr.so()(64bit)
libbear_generic_items.so()(64bit)
libbear_gui.so()(64bit)
libbear_input.so()(64bit)
libbear_net.so()(64bit)
libbear_text_interface.so()(64bit)
libbear_time.so()(64bit)
libbear_universe.so()(64bit)
libbear_visual.so()(64bit)
bear-factory:
application()
application(bf-animation-editor.desktop)
application(bf-level-editor.desktop)
application(bf-model-editor.desktop)
application(desc2img.desktop)
bear-factory
bear-factory(x86-64)
mimehandler(application/x-bear-animation)
mimehandler(application/x-bear-level)
mimehandler(application/x-bear-model)
mimehandler(application/x-bear-spritedesc)
Unversioned so-files
--------------------
bear-engine: /usr/lib64/libbear_audio.so
bear-engine: /usr/lib64/libbear_communication.so
bear-engine: /usr/lib64/libbear_debug.so
bear-engine: /usr/lib64/libbear_engine.so
bear-engine: /usr/lib64/libbear_expr.so
bear-engine: /usr/lib64/libbear_generic_items.so
bear-engine: /usr/lib64/libbear_gui.so
bear-engine: /usr/lib64/libbear_input.so
bear-engine: /usr/lib64/libbear_net.so
bear-engine: /usr/lib64/libbear_text_interface.so
bear-engine: /usr/lib64/libbear_time.so
bear-engine: /usr/lib64/libbear_universe.so
bear-engine: /usr/lib64/libbear_visual.so
Source checksums
----------------
https://github.com/j-jorge/bear/archive/2a785228d85997dc1682ee71899841528...
:
CHECKSUM(SHA256) this package :
1b174deb53e0231a9438e8a3b6ee379361bbeedfd8db288fa8f7504873f5709a
CHECKSUM(SHA256) upstream package :
1b174deb53e0231a9438e8a3b6ee379361bbeedfd8db288fa8f7504873f5709a
Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02
Command line :/usr/bin/fedora-review -b 1546544
Buildroot used: fedora-28-x86_64
Active plugins: Generic, Shell-api, C/C++
Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R,
PHP
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
APPROVED
Please fix the issues above for the final package.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
5 years, 7 months
[Bug 1637269] New: Review Request: 4ti2 - Algebraic,
geometric and combinatorial problems on linear spaces
by bugzilla＠redhat.com
https://bugzilla.redhat.com/show_bug.cgi?id=1637269
Bug ID: 1637269
Summary: Review Request: 4ti2 - Algebraic, geometric and
combinatorial problems on linear spaces
Product: Fedora
Version: rawhide
Component: Package Review
Severity: medium
Priority: medium
Assignee: nobody(a)fedoraproject.org
Reporter: loganjerry(a)gmail.com
QA Contact: extras-qa(a)fedoraproject.org
CC: package-review(a)lists.fedoraproject.org
Spec URL: https://jjames.fedorapeople.org/4ti2/4ti2.spec
SRPM URL: https://jjames.fedorapeople.org/4ti2/4ti2-1.6.9-1.fc30.src.rpm
Fedora Account System Username: jjames
Description: A software package for algebraic, geometric and combinatorial
problems on linear spaces.
This package uses Environment Modules. Prior to invoking the binaries, you
must run "module load 4ti2-%{arch}" to modify your PATH.
This once was a separate package. Then it was bundled into the latte-integrale
distribution, and so was merged into the latte-integrale package. Now upstream
has split it back out as a separate package once more, so this review is to
revive the old 4ti2 package.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
5 years, 7 months