[Bug 1626231] Review Request: python-pyvirtualize - Python module to
access and manage VMware
by bugzilla@redhat.com
https://bugzilla.redhat.com/show_bug.cgi?id=1626231
Fedora Update System <updates(a)fedoraproject.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ON_QA |CLOSED
Resolution|--- |ERRATA
Last Closed| |2019-02-04 10:00:00
--- Comment #15 from Fedora Update System <updates(a)fedoraproject.org> ---
python-pyvirtualize-0.9-2.20181003git57d2307.el7 has been pushed to the Fedora
EPEL 7 stable repository. If problems still persist, please make note of it in
this bug report.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
5 years, 3 months
[Bug 1266594] Review Request: playerctl - Command-line
MPRIS-compatible Media Player Controller
by bugzilla@redhat.com
https://bugzilla.redhat.com/show_bug.cgi?id=1266594
Dridi Boukelmoune <dridi.boukelmoune(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |CLOSED
Resolution|--- |WONTFIX
Last Closed| |2019-02-04 08:18:45
--- Comment #5 from Dridi Boukelmoune <dridi.boukelmoune(a)gmail.com> ---
I'm closing this dead review as per guidelines, and we are making progress in
bug 1671571. Jan, if you are still interested in playerctl, I'm sure Justin
won't mind one more co-maintainer once he is sponsored.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
5 years, 3 months
[Bug 1649059] Review Request: golang-contrib-opencensus-exporter -
OpenCensus Go exporters for OpenCensus Agent
by bugzilla@redhat.com
https://bugzilla.redhat.com/show_bug.cgi?id=1649059
--- Comment #2 from Ankur Sinha (FranciscoD) <sanjay.ankur(a)gmail.com> ---
Looks good. Only, the spec (and the srpm) do not match the package name and
this needs to be corrected.
Package Review
==============
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
===== MUST items =====
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: There is no build directory. Running licensecheck on vanilla
upstream sources. Licenses found: "*No copyright* Apache License
(v2.0)", "Unknown or generated", "Apache License (v2.0)". 5 files have
unknown license. Detailed output of licensecheck in /home/asinha/dump
/fedora-reviews/1649059-golang-contrib-opencensus-
exporter/licensecheck.txt
[x]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/share/gocode/src,
/usr/share/gocode
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[-]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
^ Please check this.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic:
[!]: Spec file according to URL is the same as in SRPM.
Note: Bad spec filename: /home/asinha/dump/fedora-reviews/1649059
-golang-contrib-opencensus-exporter/srpm-unpacked/golang-github-
census-ecosystem-opencensus-go-exporter-ocagent.spec
See: (this test has no URL)
^ spec file should match the bug, and the srpm. Please double check this.
[x]: Rpmlint is run on all installed packages.
Note: There are rpmlint messages (see attachment).
Rpmlint
-------
Checking: golang-contrib-opencensus-exporter-devel-0.3.0-1.fc30.noarch.rpm
golang-contrib-opencensus-exporter-0.3.0-1.fc30.src.rpm
golang-contrib-opencensus-exporter-devel.noarch: W: spelling-error %description
-l en_US deamon -> daemon, demon, deacon
golang-contrib-opencensus-exporter-devel.noarch: W: hidden-file-or-dir
/usr/share/gocode/src/contrib.go.opencensus.io/exporter/.goipath
^ This is required, iirc?
golang-contrib-opencensus-exporter.src: W: spelling-error %description -l en_US
deamon -> daemon, demon, deacon
golang-contrib-opencensus-exporter.src: E: invalid-spec-name
^ This needs correction.
golang-contrib-opencensus-exporter.src: W: no-%build-section
2 packages and 0 specfiles checked; 1 errors, 4 warnings.
Rpmlint (installed packages)
----------------------------
Cannot parse rpmlint output:
Requires
--------
golang-contrib-opencensus-exporter-devel (rpmlib, GLIBC filtered):
golang(github.com/census-instrumentation/opencensus-proto/gen-go/agent/co...
golang(github.com/census-instrumentation/opencensus-proto/gen-go/agent/tr...
golang(github.com/census-instrumentation/opencensus-proto/gen-go/trace/v1)
golang(github.com/golang/protobuf/ptypes/timestamp)
golang(go.opencensus.io)
golang(go.opencensus.io/trace)
golang(go.opencensus.io/trace/tracestate)
golang(google.golang.org/api/support/bundler)
golang(google.golang.org/grpc)
Provides
--------
golang-contrib-opencensus-exporter-devel:
golang(contrib.go.opencensus.io/exporter)
golang-contrib-opencensus-exporter-devel
golang-ipath(contrib.go.opencensus.io/exporter)
Source checksums
----------------
https://github.com/census-ecosystem/opencensus-go-exporter-ocagent/archiv...
:
CHECKSUM(SHA256) this package :
e8628d1611bdcaec6979e43f0aa8189e11a7a6fdea59c46651272a2eb806d4bd
CHECKSUM(SHA256) upstream package :
e8628d1611bdcaec6979e43f0aa8189e11a7a6fdea59c46651272a2eb806d4bd
Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02
Command line :/usr/bin/fedora-review -b 1649059
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Shell-api
Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl,
Haskell, R, PHP
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
5 years, 3 months
[Bug 1658199] Review Request: netatalk - Open Source Apple Filing
Protocol(AFP) File Server
by bugzilla@redhat.com
https://bugzilla.redhat.com/show_bug.cgi?id=1658199
--- Comment #22 from Andrew Bauer <zonexpertconsulting(a)outlook.com> ---
rpmlint seems okay (nothing new):
$ rpmlint *.rpm
netatalk.x86_64: E: missing-call-to-setgroups-before-setuid /usr/sbin/afpd
netatalk.x86_64: E: missing-call-to-setgroups-before-setuid /usr/sbin/cnid_dbd
netatalk.x86_64: E: setuid-binary /usr/bin/afppasswd root 4755
netatalk.x86_64: E: non-standard-executable-perm /usr/bin/afppasswd 4755
netatalk.x86_64: W: no-manual-page-for-binary cnid2_create
5 packages and 0 specfiles checked; 4 errors, 1 warnings.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
5 years, 3 months