[Bug 1690046] New: Review Request: <main package name here> - <short
summary here>
by bugzilla@redhat.com
https://bugzilla.redhat.com/show_bug.cgi?id=1690046
Bug ID: 1690046
Summary: Review Request: <main package name here> - <short
summary here>
Product: Fedora
Version: rawhide
Hardware: All
OS: Linux
Status: NEW
Component: Package Review
Severity: medium
Assignee: nobody(a)fedoraproject.org
Reporter: jogas(a)lanl.gov
QA Contact: extras-qa(a)fedoraproject.org
CC: package-review(a)lists.fedoraproject.org
Target Milestone: ---
Classification: Fedora
Spec URL:
https://copr-be.cloud.fedoraproject.org/results/jogas/charliecloud/epel-7...
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/jogas/charliecloud/epel-7...
Description:
Greetings, I am opening this review request with hopes of getting this package
into Fedora Extras.
Charliecloud is a 2018 R&D award winning container runtime. It leverages Linux
user namespaces to run containers with no privileged operations, no setuid
helpers, no daemons, and minimal (if any) configuration changes on center
resources. Container images can be built using Docker or anything else that can
generate a standard Linux filesystem tree.
Fedora Account System Username:
Jogas
rpmlint for charliecloud.spec:
$ rpmlint ~/rpmbuild/SPECS/charliecloud.spec
/home/jogas/rpmbuild/SPECS/charliecloud.spec: W: invalid-url Source0:
https://github.com/hpc/charliecloud/releases/download/v0.9.8/charliecloud...
HTTP Error 403: Forbidden
0 packages and 1 specfiles checked; 0 errors, 1 warnings.
The source URL points to an asset tarball with pre-built man pages. You can
download it just fine with `wget`, but the `HEAD` request that rpmlint sends
github is met with a 403 forbidden error. See:
https://github.com/rpm-software-management/rpmlint/issues/71
rpmlint log for charliecloud package:
$ rpmlint charliecloud
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
Rpmlint log for charliecloud-doc subpackage:
$ rpmlint charliecloud-doc
charliecloud-doc.x86_64: E: no-ldconfig-symlink
/usr/libexec/charliecloud/test/sotest/lib/libsotest.so.1.0
charliecloud-doc.x86_64: W: devel-file-in-non-devel-package
/usr/libexec/charliecloud/examples/mpi/mpihello/hello.c
charliecloud-doc.x86_64: E: library-without-ldconfig-postin
/usr/libexec/charliecloud/test/sotest/lib/libsotest.so.1.0
charliecloud-doc.x86_64: E: library-without-ldconfig-postun
/usr/libexec/charliecloud/test/sotest/lib/libsotest.so.1.0
charliecloud-doc.x86_64: W: devel-file-in-non-devel-package
/usr/libexec/charliecloud/test/chtest/chroot-escape.c
charliecloud-doc.x86_64: W: dangling-relative-symlink
/usr/libexec/charliecloud/test/bin ../../../bin
charliecloud-doc.x86_64: W: devel-file-in-non-devel-package
/usr/libexec/charliecloud/test/sotest/sotest.c
charliecloud-doc.x86_64: W: devel-file-in-non-devel-package
/usr/libexec/charliecloud/test/chtest/setgroups.c
charliecloud-doc.x86_64: W: devel-file-in-non-devel-package
/usr/libexec/charliecloud/examples/syscalls/userns.c
charliecloud-doc.x86_64: W: devel-file-in-non-devel-package
/usr/libexec/charliecloud/test/chtest/mknods.c
charliecloud-doc.x86_64: W: devel-file-in-non-devel-package
/usr/libexec/charliecloud/examples/syscalls/pivot_root.c
charliecloud-doc.x86_64: W: devel-file-in-non-devel-package
/usr/libexec/charliecloud/test/chtest/setuid.c
1 packages and 0 specfiles checked; 3 errors, 9 warnings.
charliecloud-doc rpmlint comments:
1. E: no-ldconfig-symlink
/usr/libexec/charliecloud/test/sotest/lib/libsotest.so.1.0
Charliecloud is a container runtime. These shared objects are never used in the
host environment; rather, they are compiled by the test suite (both running and
examination of which serve as end-user documentation) and injected into the
container (guest) via utility script 'ch-fromhost'. The ldconfig links are
generated inside the container runtime environment. For more information, see
the test file:
https://github.com/hpc/charliecloud/blob/master/test/run/ch-fromhost.bats (line
108).
2. W: devel-file-in-non-devel-package
/usr/libexec/charliecloud/examples/mpi/mpihello/hello.c
The test suite has a few C files, e.g. userns.c, pivot_root.c, chroot-escape.c,
sotest.c, setgroups.c, mknods.c, setuid.c, .etc, that document — line-by-line
in many cases — various components of the open source runtime. These C files
are part of our documentation to show end users how containers work.
3. E: library-without-ldconfig-postin
/usr/libexec/charliecloud/test/sotest/lib/libsotest.so.1.0
See response to #1.
4.: library-without-ldconfig-postun
/usr/libexec/charliecloud/test/sotest/lib/libsotest.so.1.0
See response to #1.
5. devel-file-in-non-devel-package
/usr/libexec/charliecloud/test/chtest/chroot-escape.c
See response to #2.
6. dangling-relative-symlink /usr/libexec/charliecloud/test/bin ../../../bin
This is a false positive. The symlink is to /usr/bin, which is not in the
package.
7..12.
W: devel-file-in-non-devel-package
/usr/libexec/charliecloud/test/sotest/sotest.c
W: devel-file-in-non-devel-package
/usr/libexec/charliecloud/test/chtest/setgroups.c
W: devel-file-in-non-devel-package
/usr/libexec/charliecloud/examples/syscalls/userns.c
W: devel-file-in-non-devel-package
/usr/libexec/charliecloud/test/chtest/mknods.c
W: devel-file-in-non-devel-package
/usr/libexec/charliecloud/examples/syscalls/pivot_root.c
W: devel-file-in-non-devel-package
/usr/libexec/charliecloud/test/chtest/setuid.c
See response to #2.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
4 years, 6 months