[Bug 1353169] Review Request: python-nikola - A static website and
blog generator
by bugzilla@redhat.com
https://bugzilla.redhat.com/show_bug.cgi?id=1353169
--- Comment #50 from Neal Gompa <ngompa13(a)gmail.com> ---
Package Review
==============
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
===== MUST items =====
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: License file installed when any subpackage combination is installed.
[x]: If the package is under multiple licenses, the licensing breakdown
must be documented in the spec.
[!]: Package requires other packages for directories it uses.
Note: No known owner of /usr/share/doc/nikola
[!]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/share/doc/nikola
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 184320 bytes in 4 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[x]: Python eggs must not download any dependencies during the build
process.
[x]: A package which is used by another package via an egg interface should
provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
packages named with the unversioned python- prefix unless no properly
versioned package exists. Dependencies on Python packages instead MUST
use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
[x]: Binary eggs must be removed in %prep
===== SHOULD items =====
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise
justified.
[-]: Sources are verified with gpgverify first in %prep if upstream
publishes signatures.
Note: gpgverify is not used.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic:
[x]: Rpmlint is run on all installed packages.
Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.
Rpmlint
-------
Checking: python3-nikola-8.0.4-8.fc33.noarch.rpm
python-nikola-doc-8.0.4-8.fc33.noarch.rpm
nikola-8.0.4-8.fc33.noarch.rpm
python-nikola-8.0.4-8.fc33.src.rpm
python3-nikola.noarch: W: spelling-error %description -l en_US unformatted ->
unformulated, formatted, unfortunate
python3-nikola.noarch: W: spelling-error %description -l en_US reStructuredText
-> restructured Text, restructured-text, restructuring
python3-nikola.noarch: E: non-executable-script
/usr/lib/python3.8/site-packages/nikola/data/samplesite/listings/hello.py 644
/usr/bin/python
python3-nikola.noarch: E: non-executable-script
/usr/lib/python3.8/site-packages/nikola/packages/datecond/__init__.py 644
/usr/bin/env python
python-nikola-doc.noarch: W: summary-not-capitalized C python-nikola
documentation
python-nikola-doc.noarch: W: obsolete-not-provided python2-nikola
python-nikola-doc.noarch: W: obsolete-not-provided python3-nikola
nikola.noarch: W: summary-not-capitalized C python-nikola documentation
nikola.noarch: W: spelling-error %description -l en_US unformatted ->
unformulated, formatted, unfortunate
nikola.noarch: W: spelling-error %description -l en_US reStructuredText ->
restructured Text, restructured-text, restructuring
python-nikola.src: W: spelling-error %description -l en_US unformatted ->
unformulated, formatted, unfortunate
python-nikola.src: W: spelling-error %description -l en_US reStructuredText ->
restructured Text, restructured-text, restructuring
python-nikola.src:96: W: unversioned-explicit-provides
bundled(python3-pytzlocal)
4 packages and 0 specfiles checked; 2 errors, 11 warnings.
Rpmlint (installed packages)
----------------------------
nikola.noarch: W: summary-not-capitalized C python-nikola documentation
nikola.noarch: W: spelling-error %description -l en_US unformatted ->
unformulated, formatted, unfortunate
nikola.noarch: W: spelling-error %description -l en_US reStructuredText ->
restructured Text, restructured-text, restructuring
nikola.noarch: W: invalid-url URL: https://getnikola.com/ <urlopen error [Errno
-2] Name or service not known>
python-nikola-doc.noarch: W: summary-not-capitalized C python-nikola
documentation
python-nikola-doc.noarch: W: invalid-url URL: https://getnikola.com/ <urlopen
error [Errno -2] Name or service not known>
python-nikola-doc.noarch: W: obsolete-not-provided python2-nikola
python-nikola-doc.noarch: W: obsolete-not-provided python3-nikola
python3-nikola.noarch: W: spelling-error %description -l en_US unformatted ->
unformulated, formatted, unfortunate
python3-nikola.noarch: W: spelling-error %description -l en_US reStructuredText
-> restructured Text, restructured-text, restructuring
python3-nikola.noarch: W: invalid-url URL: https://getnikola.com/ <urlopen
error [Errno -2] Name or service not known>
python3-nikola.noarch: E: non-executable-script
/usr/lib/python3.8/site-packages/nikola/data/samplesite/listings/hello.py 644
/usr/bin/python
python3-nikola.noarch: E: non-executable-script
/usr/lib/python3.8/site-packages/nikola/packages/datecond/__init__.py 644
/usr/bin/env python
3 packages and 0 specfiles checked; 2 errors, 11 warnings.
Source checksums
----------------
https://github.com/getnikola/nikola/archive/v8.0.4/nikola-8.0.4.tar.gz :
CHECKSUM(SHA256) this package :
558c715b5df4ec065e410a084dafb96e50291f4972e378770532e9c930768610
CHECKSUM(SHA256) upstream package :
558c715b5df4ec065e410a084dafb96e50291f4972e378770532e9c930768610
Requires
--------
python3-nikola (rpmlib, GLIBC filtered):
glyphicons-halflings-fonts
python(abi)
python3.8dist(babel)
python3.8dist(blinker)
python3.8dist(docutils)
python3.8dist(doit)
python3.8dist(lxml)
python3.8dist(mako)
python3.8dist(markdown)
python3.8dist(natsort)
python3.8dist(piexif)
python3.8dist(pillow)
python3.8dist(pygments)
python3.8dist(pyrss2gen)
python3.8dist(python-dateutil)
python3.8dist(requests)
python3.8dist(setuptools)
python3.8dist(unidecode)
python3.8dist(yapsy)
python3dist(aiohttp)
python3dist(ghp-import2)
python3dist(husl)
python3dist(ipykernel)
python3dist(jinja2)
python3dist(micawber)
python3dist(notebook)
python3dist(phpserialize)
python3dist(pygal)
python3dist(pyphen)
python3dist(ruamel.yaml)
python3dist(toml)
python3dist(typogrify)
python3dist(watchdog)
python-nikola-doc (rpmlib, GLIBC filtered):
nikola (rpmlib, GLIBC filtered):
/usr/bin/python3
python3-nikola
Provides
--------
python3-nikola:
bundled(python3-datecond)
bundled(python3-pytzlocal)
python-nikola
python3-nikola
python3.8dist(nikola)
python3dist(nikola)
python-nikola-doc:
python-nikola-doc
nikola:
nikola
Generated by fedora-review 0.7.5 (5fa5b7e) last change: 2020-02-16
Command line :/usr/bin/fedora-review -b 1353169 -m fedora-rawhide-x86_64
Buildroot used: fedora-rawhide-x86_64
Active plugins: Python, Generic, Shell-api
Disabled plugins: PHP, R, fonts, Haskell, C/C++, Ocaml, SugarActivity, Perl,
Java
Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
4 years, 1 month
[Bug 1789146] New: Review Request: systemd-networkd - System daemon
that manages network configurations
by bugzilla@redhat.com
https://bugzilla.redhat.com/show_bug.cgi?id=1789146
Bug ID: 1789146
Summary: Review Request: systemd-networkd - System daemon that
manages network configurations
Product: Fedora
Version: rawhide
Hardware: All
OS: Linux
Status: NEW
Component: Package Review
Severity: medium
Assignee: nobody(a)fedoraproject.org
Reporter: redhat-bugzilla(a)linuxnetz.de
QA Contact: extras-qa(a)fedoraproject.org
CC: package-review(a)lists.fedoraproject.org
Target Milestone: ---
Classification: Fedora
Spec URL: https://labs.linuxnetz.de/bugzilla/systemd-networkd.spec
SRPM URL:
https://labs.linuxnetz.de/bugzilla/systemd-networkd-244.1-1.el8.src.rpm
Description: systemd-networkd is a system service that manages networks. It
detects and configures network devices as they appear, as well as creating
virtual network devices.
Fedora Account System Username: robert
Important: This package is intended to be only for EPEL 8 in order to address
bug #1650342. In difference to the frozen systemd v239 in RHEL 8, which
obviously does not receive any systemd-networkd patches/backports, this package
shall be updated with new systemd-networkd versions to cover bug and security
fixes as well as new features (I'm likely unable to perform larger backports
like Red Hat is doing for systemd in general). If a reviewer thinks the package
should be then called systemd-networkd-latest (or similar), please let me know.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
4 years, 1 month
[Bug 1792741] New: Review Request: openssl11 - Utilities from the
general purpose cryptography library with TLS implementation
by bugzilla@redhat.com
https://bugzilla.redhat.com/show_bug.cgi?id=1792741
Bug ID: 1792741
Summary: Review Request: openssl11 - Utilities from the general
purpose cryptography library with TLS implementation
Product: Fedora
Version: rawhide
Hardware: All
OS: Linux
Status: NEW
Component: Package Review
Severity: medium
Assignee: nobody(a)fedoraproject.org
Reporter: redhat-bugzilla(a)linuxnetz.de
QA Contact: extras-qa(a)fedoraproject.org
CC: package-review(a)lists.fedoraproject.org
Target Milestone: ---
Classification: Fedora
Spec URL: http://labs.linuxnetz.de/bugzilla/openssl11.spec
SRPM URL: http://labs.linuxnetz.de/bugzilla/openssl11-1.1.1c-1.el7.src.rpm
Description: The OpenSSL toolkit provides support for secure communications
between machines. OpenSSL includes a certificate management tool and shared
libraries which provide various cryptographic algorithms and protocols.
Fedora Account System Username: robert
This package is intended only for EPEL 7 to provide some kind of forward
compatibility for specific applications. RHEL 7 is only shipping the old
openssl-1.0.2k-19.el7 (and it won't change that as stated in bug #1416715). So
this is openssl-1.1.1c-2.el8 from RHEL 8 modified to be installable along with
the regular package. The package itself was as less modified as possible to
make the differences hopefully easily reviewable.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
4 years, 1 month