[Bug 1937868] New: Review Request: golang-github-msprev-fzf-bibtex -
A BibTeX source for fzf
by bugzilla@redhat.com
https://bugzilla.redhat.com/show_bug.cgi?id=1937868
Bug ID: 1937868
Summary: Review Request: golang-github-msprev-fzf-bibtex - A
BibTeX source for fzf
Product: Fedora
Version: rawhide
Hardware: All
OS: Linux
Status: NEW
Component: Package Review
Severity: medium
Priority: medium
Assignee: nobody(a)fedoraproject.org
Reporter: dmoerner(a)gmail.com
QA Contact: extras-qa(a)fedoraproject.org
CC: package-review(a)lists.fedoraproject.org
Target Milestone: ---
Classification: Fedora
Spec URL: https://moerner.com/fedora/golang-github-msprev-fzf-bibtex.spec
SRPM URL:
https://moerner.com/fedora/golang-github-msprev-fzf-bibtex-1.1-0.1.202103...
Description: A BibTeX source for fzf. fzf-bibtex uses BibTool parse BibTeX
files, caches the results, and supports vim integration for users of the
fzf.vim plugin. It includes support for Markdown and LaTeX citation formats.
Fedora Account System Username: dmoerner
Comments:
- I do not need sponsoring, but this is my first solo-maintained package and my
first golang package, so any comments will be helpful.
- Since this is really just a set of binaries, not a library, I decided it
would be appropriate to not ship the code with %gopkginstall and %gopkgfiles.
I'm happy to add these back in if I should.
- Upstream's github includes release notes for a 1.1 release from Feb 2020.
However, I cannot find this release packaged in a tarball, and all development
seems to just use git.
- rpmlint reports "E: shared-lib-without-dependency-information". I believe
this is a false positive:
https://github.com/rpm-software-management/rpmlint/issues/598.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
3 years, 2 months
[Bug 1927033] Review Request: eth-fast-fabric - Intel Ethernet Fast
Fabric Tools
by bugzilla@redhat.com
https://bugzilla.redhat.com/show_bug.cgi?id=1927033
--- Comment #6 from Jijun Wang <jijun.wang(a)intel.com> ---
Please see my response below. I also updated github with the suggested changes,
and did a koji build
(https://koji.fedoraproject.org/koji/taskinfo?taskID=63926205).
>> So we cannot directly use the source
>> tarball.
>>
>I don't follow. Even if you generate the spe file with a script, why can't you use your tool to generate the correct archive url? Using macro like %{version} would automatically keep the archive up to >date. I don't understand why you need to use a manually created archive while the github url would work as much.
Got what you meant. Changed spec file to use referencing source.
>> eth-fast-fabric includes some mpi_apps in source form so end users can
>> select the desired MPI to build them against such as openmpi, Intel MPI, or
>> others. During uninstall, the makefile the user would use to clean the
>> binaries is gone, so best to clean now.
>>
>Could you use the %ghost directive to reset the files generated by the user that are not present at install?
Removed %preun. A user supposes copy mpi-apps src to another location and
build. The make clean here is unnecessary.
Below is the generated spec file:
Name: eth-tools
Version: 11.0.0.0~pre
Release: 163%{?dist}
Summary: Intel Ethernet Fabric Suite basic tools and libraries for fabric
management
License: BSD
Url: https://github.com/intel/eth-fast-fabric
Source:
%url/archive/%{version_no_tilde}/eth-fast-fabric-%{version_no_tilde}.tar.gz
ExclusiveArch: x86_64
# The Intel(R) Ethernet Fabric Suite product line is only available on x86_64
platforms at this time.
%description
This package contains the tools necessary to manage an Intel Ethernet fabric.
%package basic
Summary: Management level tools and scripts
Requires: rdma bc
Requires: expect%{?_isa}, tcl%{?_isa}, net-snmp-utils%{?_isa}
BuildRequires: make
BuildRequires: expat-devel
BuildRequires: gcc-c++
BuildRequires: openssl-devel
BuildRequires: ncurses-devel
BuildRequires: tcl-devel
BuildRequires: zlib-devel
BuildRequires: rdma-core-devel
BuildRequires: ibacm-devel
BuildRequires: net-snmp-devel
Epoch: 1
%description basic
Contains basic tools for fabric management necessary on all compute nodes.
%package fastfabric
Summary: Management level tools and scripts
Requires: eth-tools-basic%{?_isa} >= %{version}-%{release}
Requires: cronie
Epoch: 1
%description fastfabric
Contains tools for managing fabric on a management node.
%prep
%autosetup -n eth-fast-fabric-%{version_no_tilde}
%build
cd OpenIb_Host
OPA_FEATURE_SET= CLOCAL='%build_cflags' CCLOCAL='%build_cxxflags'
LDLOCAL='%build_ldflags' ./ff_build.sh %{_builddir}
%install
BUILDDIR=%{_builddir} DESTDIR=%{buildroot} LIBDIR=%{_prefix}/lib
DSAP_LIBDIR=%{_libdir} ./OpenIb_Host/ff_install.sh
%files basic
%{_sbindir}/ethcapture
%{_prefix}/lib/eth-tools/setup_self_ssh
%{_prefix}/lib/eth-tools/usemem
%{_prefix}/lib/eth-tools/ethipcalc
%{_prefix}/lib/eth-tools/stream
%{_mandir}/man1/ethcapture.1*
%{_datadir}/eth-tools/samples/mgt_config.xml-sample
%dir %{_sysconfdir}/eth-tools/
%config(noreplace) %{_sysconfdir}/eth-tools/mgt_config.xml
%files fastfabric
%{_sbindir}/*
%exclude %{_sbindir}/ethcapture
%{_prefix}/lib/eth-tools/*
%exclude %{_prefix}/lib/eth-tools/setup_self_ssh
%exclude %{_prefix}/lib/eth-tools/usemem
%exclude %{_prefix}/lib/eth-tools/ethipcalc
%exclude %{_prefix}/lib/eth-tools/stream
%{_datadir}/eth-tools/*
%exclude %{_datadir}/eth-tools/samples/mgt_config.xml-sample
%{_mandir}/man8/eth*.8*
%{_usrsrc}/eth/*
%{_sysconfdir}/eth-tools/ethmon.si.conf
# Replace ethmon.si.conf, as it's a template config file.
%config(noreplace) %{_sysconfdir}/eth-tools/ethfastfabric.conf
%config(noreplace) %{_sysconfdir}/eth-tools/ethmon.conf
%config(noreplace) %{_sysconfdir}/eth-tools/allhosts
%config(noreplace) %{_sysconfdir}/eth-tools/chassis
%config(noreplace) %{_sysconfdir}/eth-tools/hosts
%config(noreplace) %{_sysconfdir}/eth-tools/switches
%config(noreplace) /usr/lib/eth-tools/osid_wrapper
%changelog
* Fri Feb 05 2021 Jijun Wang <jijun.wang(a)intel.com> - 11.0.0.0-163
- Cleaned up for upstream
* Mon Feb 26 2018 Jijun Wang <jijun.wang(a)intel.com> - 10.8.0.0-1
- Added epoch for RHEL address-resolution, basic and fastfabric
- Added component information in description for all rpms
* Thu Apr 13 2017 Scott Breyer <scott.j.breyer(a)intel.com> - 10.5.0.0-1
- Updates for spec file cleanup
* Fri Oct 10 2014 Erik E. Kahn <erik.kahn(a)intel.com> - 1.0.0-ifs-1
- Initial version
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
3 years, 2 months
[Bug 1886700] New: Review Request: golang-github-saintfish-chardet -
Charset detector library
by bugzilla@redhat.com
https://bugzilla.redhat.com/show_bug.cgi?id=1886700
Bug ID: 1886700
Summary: Review Request: golang-github-saintfish-chardet -
Charset detector library
Product: Fedora
Version: rawhide
Hardware: All
OS: Linux
Status: NEW
Component: Package Review
Severity: medium
Assignee: nobody(a)fedoraproject.org
Reporter: mail(a)fabian-affolter.ch
QA Contact: extras-qa(a)fedoraproject.org
CC: package-review(a)lists.fedoraproject.org
Target Milestone: ---
Classification: Fedora
Spec URL:
https://fab.fedorapeople.org/packages/SRPMS/golang-github-saintfish-chard...
SRPM URL:
https://fab.fedorapeople.org/packages/SRPMS/golang-github-saintfish-chard...
Project URL: https://github.com/saintfish/chardet
Description:
Charset detector library for Golang derived from ICU.
Koji scratch build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=53063210
rpmlint output:
$ rpmlint golang-github-saintfish-chardet-0-0.1.20201009git3af4cd4.fc32.src.rpm
golang-github-saintfish-chardet.src: W: spelling-error Summary(en_US) Charset
-> Char set, Char-set, Catharses
golang-github-saintfish-chardet.src: W: spelling-error %description -l en_US
Charset -> Char set, Char-set, Catharses
golang-github-saintfish-chardet.src: W: no-%build-section
1 packages and 0 specfiles checked; 0 errors, 3 warnings.
$ rpmlint
golang-github-saintfish-chardet-devel-0-0.1.20201009git3af4cd4.fc32.noarch.rpm
golang-github-saintfish-chardet-devel.noarch: W: spelling-error Summary(en_US)
Charset -> Char set, Char-set, Catharses
golang-github-saintfish-chardet-devel.noarch: W: spelling-error %description -l
en_US Charset -> Char set, Char-set, Catharses
golang-github-saintfish-chardet-devel.noarch: W: hidden-file-or-dir
/usr/share/gocode/src/github.com/saintfish/chardet/.goipath
1 packages and 0 specfiles checked; 0 errors, 3 warnings.
Fedora Account System Username: fab
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
3 years, 2 months
[Bug 1916190] New: Review Request: overlayfs-tools - OverlayFS
layers manipulation tools
by bugzilla@redhat.com
https://bugzilla.redhat.com/show_bug.cgi?id=1916190
Bug ID: 1916190
Summary: Review Request: overlayfs-tools - OverlayFS layers
manipulation tools
Product: Fedora
Version: rawhide
Hardware: All
OS: Linux
Status: NEW
Component: Package Review
Severity: medium
Priority: medium
Assignee: nobody(a)fedoraproject.org
Reporter: dominik(a)greysector.net
QA Contact: extras-qa(a)fedoraproject.org
CC: package-review(a)lists.fedoraproject.org
Target Milestone: ---
Classification: Fedora
Spec URL:
https://rathann.fedorapeople.org/review/overlayfs-tools/overlayfs-tools.spec
SRPM URL:
https://rathann.fedorapeople.org/review/overlayfs-tools/overlayfs-tools-0...
Description:
OverlayFS is the union filesystem provided by Linux kernel.
This program comes provides three tools:
* vacuum - remove duplicated files in upperdir where copy_up is done but the
file is not actually modified (see the sentence "the copy_up may turn out to
be unnecessary" in the Linux documentation). This may reduce the size of
upperdir without changing lowerdir or overlay.
* diff - show the list of actually changed files (the difference between
overlay
and lowerdir). A file with its type changed (i.e. from symbolic link to
regular file) will shown as deleted then added, rather than modified.
Similarly, for a opaque directory in upperdir, the corresponding directory in
lowerdir (if exists) will be shown as entirely deleted, and a new directory
with the same name added. File permission/owner changes will be simply shown
as modified.
* merge - merge down the changes from upperdir to lowerdir. Unlike aubrsync for
AuFS which bypasses the union filesystem mechanism, overlayfs-utils emulates
the OverlayFS logic, which will be far more efficient. After this operation,
upperdir will be empty and lowerdir will be the same as original overlay.
* deref - copy changes from upperdir to uppernew while unfolding redirect
directories and metacopy regular files, so that new upperdir is compatible
with legacy overlayfs driver.
For safety reasons, vacuum and merge will not actually modify the filesystem,
but generate a shell script to do the changes instead.
Fedora Account System Username: rathann
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
3 years, 2 months
[Bug 1885684] New: Review Request: rocm-smi - AMD ROCm System
Management Interface
by bugzilla@redhat.com
https://bugzilla.redhat.com/show_bug.cgi?id=1885684
Bug ID: 1885684
Summary: Review Request: rocm-smi - AMD ROCm System Management
Interface
Product: Fedora
Version: rawhide
Hardware: All
OS: Linux
Status: NEW
Component: Package Review
Severity: medium
Assignee: nobody(a)fedoraproject.org
Reporter: code(a)musicinmybrain.net
QA Contact: extras-qa(a)fedoraproject.org
CC: package-review(a)lists.fedoraproject.org
Target Milestone: ---
Classification: Fedora
Spec URL:
https://gitlab.com/musicinmybrain/rocm-smi-rpm/-/raw/master/rocm-smi.spec
SRPM URL:
https://kojipkgs.fedoraproject.org//work/tasks/6769/52876769/rocm-smi-3.8...
Description: AMD ROCm System Management Interface
Fedora Account System Username: music
This is a command-line tool for clock and temperature management of a ROCm
enabled system, i.e., one with an AMD GPU.
It does not directly depend on the AMDGPU (open-source) or AMDGPU-PRO
(proprietary) GPU driver; instead, it is a monolithic pure-Python script that
interacts with any supported GPU via sysfs.
Koji build for Fedora 34:
https://koji.fedoraproject.org/koji/taskinfo?taskID=52876746
Koji build for Fedora 33:
https://koji.fedoraproject.org/koji/taskinfo?taskID=52876923
Koji build for Fedora 32:
https://koji.fedoraproject.org/koji/taskinfo?taskID=52877091
Koji build for EPEL8:
https://koji.fedoraproject.org/koji/taskinfo?taskID=52877312
Koji build for EPEL7:
https://koji.fedoraproject.org/koji/taskinfo?taskID=52877482
----
This is my first package for Fedora, and I am seeking a sponsor. As instructed
on https://pagure.io/packager-sponsors/, I will apply for sponsorship once the
package review process is completed for this package. Once the package is in
Fedora, I plan to request EPEL branches as well. I have also added the upstream
package to release monitoring: https://release-monitoring.org/project/138112/.
While I have about a decade of experience with RPM packaging, this has
generally not been public work. I offer the following recent contributions to
demonstrate my understanding of RPM packaging and of Fedora guidelines and
processes.
My PR to build rasqal against system libraries (libgcrypt) instead of using
bundled cryptographic hash implementations was accepted, resolving a
six-year-old issue: https://bugzilla.redhat.com/show_bug.cgi?id=1099251.
My PR to unbundle mathjax from spyder was accepted, resolving a seven-year-old
issue: https://bugzilla.redhat.com/show_bug.cgi?id=1017213.
I fixed a couple of cases where applications showed a generic fallback icon
under GNOME/Wayland. In the case of spyder, the correct fix was to make an
upstream bug report and supply an upstream PR, which was accepted:
https://bugzilla.redhat.com/show_bug.cgi?id=1832579. In the case of
boinc-client, the correct fix was a change in the Fedora packaging:
https://bugzilla.redhat.com/show_bug.cgi?id=1880553.
I have also written a spec file for the SLEEF Vectorized Math Library, which
demonstrates my ability to correctly handle more complicated packages than this
one: https://gitlab.com/musicinmybrain/sleef-rpm/-/blob/master/sleef.spec. I
have not submitted a review request for that package because there are still a
few unresolved test failures on the s390x platform.
Thanks for your time.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
3 years, 2 months