Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: libXrandr
https://bugzilla.redhat.com/show_bug.cgi?id=226083
bugzilla@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |medium Priority|normal |medium Product|Fedora Extras |Fedora Version|devel |rawhide
panemade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@fedoraproject.org |panemade@gmail.com Status|NEW |CLOSED Resolution| |RAWHIDE Flag| |fedora-review+
------- Additional Comments From panemade@gmail.com 2008-01-14 23:32 EST ------- Review: + package builds in mock (rawhide i386). + rpmlint output is Silent. + source match upstream 1b244b5d19f0ccab01d7083436cd3558 libXrandr-1.2.2.tar.bz2 + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc files present. + BuildRequires are proper. + Compiler flags are used correctly. + defattr usage is correct. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains contents. + no static libraries. + xrandr.pc file present. + -devel subpackage exists. + no .la files. + no translations are available. + Does owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. + ldconfig scriptlets are used. + Not a GUI app.
APPROVED.