https://bugzilla.redhat.com/show_bug.cgi?id=1250025
Augusto Caringi acaringi@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(acaringi@redhat.c |needinfo+ |om) |
--- Comment #9 from Augusto Caringi acaringi@redhat.com --- (In reply to Matej Mužila from comment #8)
Hi,
I have a few comments to the pakcage review.
MUST: - Bundled gtest is removed before compilation so it shouldn't be a problem. (rocksdb.spec:35 rm -rf third-party/gtest-1.7.0)
- fbson doesn't seem to be released separately. Facebook just bundles it into its projects.
SHOULD: - Yes, new versions are released very often. At the time of submitting rocksdb package for review, the highiest available version was packaged. - Package can be built on all supported architectures [1]. It was not intended to be added to fedora < f26. - The Makefile bug (use of parallel jobs) was already fixed by upstream so we do not need to fix it downstream.
Could you please reconsider the package review?
For me it's ok... Just suggestions.