Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: bitlbee
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196591
paul@xelerance.com changed:
What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO|163778 |163779 nThis| |
------- Additional Comments From paul@xelerance.com 2006-10-22 23:32 EST ------- Good:
- package meets naming guidelines - package meets packaging guidelines - license (GPL) OK, text in %doc, matches source - source matches upstream - spec in american english - compiles and builds on one arch at least. - no forbidden buildrequires included - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file - doesn't own any files/dirs that are already owned by other packages
Minor: - rpmlint clean except a warning on not using %configure macro, but upstream only provides limited non-auto{conf|make} support, which is specified on the configure line.
APPROVED