https://bugzilla.redhat.com/show_bug.cgi?id=1262470
Pete Travis me@petetravis.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED
--- Comment #2 from Pete Travis me@petetravis.com --- Hey Major, a few concerns remaining:
- LICENSE file should go in every subpackage, not only -doc
- rpmlint doesn't like shebangs on non-executable files. None of the files in %python?_sitelib should be executable, and should not have shebangs.
- rpmlint also complains about shebangs and executables for sample code in %doc. I don't think that executables there are especially *wrong*, but they're done incorrectly here; please check over the files in %doc and patch/sed/chmod them so that they're only executable if they should be, and only have a shebang if they are directly executable.
Note that makesimple.sh invokes enscript, which is not a declared dependency; %doc should not add additional requires, but Suggests: might be more appropriate. Shipping an executable that doesn't work seems awkward, even in %doc.
Otherwise, all seems well.