Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: PackageKit - Package management with dbus and policykit
https://bugzilla.redhat.com/show_bug.cgi?id=333451
------- Additional Comments From rnorwood@redhat.com 2007-10-16 13:41 EST ------- Thanks for the feedback - applied your fixes here:
http://people.redhat.com/rnorwood/rpms/PackageKit-0.1.0-2.fc8.src.rpm http://people.redhat.com/rnorwood/rpms/PackageKit.spec
Also, there's still some rpmlint output:
PackageKit.i386: E: non-executable-script /usr/lib/python2.5/site-packages/packagekit/backend.py 0644 PackageKit.i386: E: non-executable-script /usr/lib/python2.5/site-packages/packagekit/frontend.py 0644 PackageKit.i386: W: file-not-utf8 /usr/share/doc/packagekit/reference.html PackageKit.i386: W: non-standard-dir-in-var db
I'm working with upstream to fix these issues - they should all be fixed in the next release.
Finally, the license should be GPLv2+ - most of the source files state this explicitly, a few are unclear. This should also be fixed in the next upstream version.