Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: perl-Params-Coerce - Allows your classes to do coercion of
parameters
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=205319
tibbs(a)math.uh.edu changed:
What |Removed |Added
----------------------------------------------------------------------------
OtherBugsDependingO|163778 |163779
nThis| |
------- Additional Comments From tibbs(a)math.uh.edu 2006-09-07 01:25 EST -------
I have to say that the %description leaves a bit to be desired. Could you
perhaps add the second paragraph from the DESCRIPTION section of the documentation?
* source files match upstream:
b87babce7c8c5869045fff7d1fc9958f Params-Coerce-0.13.tar.gz
* package meets naming and packaging guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* build root is correct.
* license field matches the actual license.
* license is open source-compatible. License text included in package.
* latest version is being packaged.
* BuildRequires are proper.
* compiler flags are appropriate.
* %clean is present.
* package builds in mock (development, x86_64).
* rpmlint is silent.
* final provides and requires are sane:
perl(Params::Coerce) = 0.13
perl-Params-Coerce = 0.13-1.fc6
=
perl(:MODULE_COMPAT_5.8.8)
perl(Carp)
perl(Params::Util)
perl(Scalar::Util)
perl(strict)
perl(vars)
* %check is present and all tests pass:
All tests successful.
Files=5, Tests=48, 0 wallclock secs ( 0.16 cusr + 0.08 csys = 0.24 CPU)
* package is not relocatable.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
APPROVED
--
Configure bugmail:
https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.