https://bugzilla.redhat.com/show_bug.cgi?id=1359402
--- Comment #12 from Tim Fenn tim.fenn@gmail.com --- (In reply to Antonio Trande from comment #11)
OK, so just switch this to GPLv3+ and delete all the other stuff?
Yes.
Done.
Package Review
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
Issues:
- Package does not use a name that already exists. Note: A package with this name already exists. Please check https://admin.fedoraproject.org/pkgdb/package/coot See:
https://fedoraproject.org/wiki/Packaging/ NamingGuidelines#Conflicting_Package_Names
- Main package requires libcoot, not viceversa:
Fixed.
- License and doc should be under '%files -n libcoot'
Done.
Python libraries should be packed separately in an arched 'python2-libcoot' sub-package (sorry, i didn't seen it before).
Main package should require it.
Done.
- doc subpackage provides PDF files only, it should not require the main one in my opinion.
OK, done.
- Useless ldconfig:
%post /sbin/ldconfig /bin/touch --no-create %{_datadir}/icons/hicolor &>/dev/null || :
Oops, this was a result of moving things to libcoot. Fixed.
- coot-data ?
Done (oops missed this one before).
- I don't see any tests ran with 'make check'
There are checks compiled in several subdirectories - they're not defined as TESTS however. I could run them manually - I'll check with upstream.
Please, remove commands and macros in the comments
AutoTools: Obsoleted m4s found
AM_PROG_CC_STDC found in: coot-0.8.6.2/configure.ac:38
This is commented out by Patch0, and autoconf is then re-run. Acceptable?
https://timfenn.fedorapeople.org/coot.spec https://timfenn.fedorapeople.org/coot-0.8.6.2-2.fc24.src.rpm