https://bugzilla.redhat.com/show_bug.cgi?id=1795068
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |decathorpe@gmail.com Assignee|nobody@fedoraproject.org |decathorpe@gmail.com Doc Type|--- |If docs needed, set a value Flags| |fedora-review?
--- Comment #1 from Fabio Valentini decathorpe@gmail.com --- I can review this package.
Initial comments / suggestions / recommendations:
1) It looks like you're using pypi source tarball. You should be able to just use "%{pypi_source}" for that.
2) You could deduplicate the %descriptions (like I commented on python-shodan).
3) Please use trailing slashes for directories in %files:
%{python3_sitelib}/%{pypi_name}/ %{python3_sitelib}/%{pypi_name}-%{version}-py%{python3_version}.egg-info/
Other than that, looks good.
Let me know when the package is ready for the formal review.