https://bugzilla.redhat.com/show_bug.cgi?id=1919347
--- Comment #9 from d.hatayama(a)fujitsu.com ---
Dominik, Lianbo,
Thanks for your comments.
I've updated the spec file and source rpm file.
Spec URL:
http://raw.githubusercontent.com/d-hatayama/crash-modules-fedora-package-...
SRPM URL:
https://github.com/d-hatayama/crash-modules-fedora-package-review/raw/mas...
(In reply to Dominik 'Rathann' Mierzejewski from comment #7)
Please use %make_build instead of plain `make' in %build unless
you have a
good reason.
Please use install -dm755 instead of `mkdir -p' in %install.
As Lianbo mentioned, I didn't update the spec file. Sorry.
I confirmed this time I've updated both.
(In reply to lijiang from comment #8)
Hi, Hatayama
Maybe it might look like this according to Dominik's comment#7.
%build
%make_build -C src -f gcore.mk
%install
install -dm755 %{buildroot}%{_libdir}/crash/extensions/
install -m 0755 -t %{buildroot}%{_libdir}/crash/extensions/
%{_builddir}/%{reponame}-%{version}/src/gcore.so
In addition, I also noticed that some content should be updated in the
README, because we have planned to support on the x86_64/aarch64/ppc64le
architectures, for example:
Support Range
~~~~~~~~~~~~~
| ARCH | X86, X86_64 |
| Kernel Version | RHEL4.8, RHEL5.5, RHEL6.0 and Vanilla 2.6.36 |
I'm aware of this. This README is very old. I had not intended to put
this in public. I think I'll update this soon in the upstream but not
during this review because the README is not shipped with the rpm package.
BTW: would you mind checking that the following dependencies of
packages
should be added to the build requires?
BuildRequires: zlib-devel lzo-devel snappy-devel
I intentionally dropped these dependencies because gcore.so doesn't need
these packages; actually not linked with these compression libraries
corresponding to each package at runtime.
I think the current configuration that only crash and crash-devel has build
dependencies for zlib-devel, lzo-devel and snappy-devel is correct.
Thanks.
HATAYAMA, Daisuke
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component