Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: rb_libtorrent - A C++ BitTorrent library aiming to be the best alternative Alias: rb_libtorrent
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221372
------- Additional Comments From peter@thecodergeek.com 2007-01-17 15:37 EST -------
Re-check "License:" as it is _not_ GPL.
Gaah. I just copied that from the Gentoo ebuild without verifying it. Thanks for the catch.
IMO this conflict is unacceptable. Actually, "libtorrent" is libtorrent.so.9, this one is libtorrent.so.0, and "libtorrent-devel" uses /usr/include/torrent/ while this one uses /usr/include/libtorrent/. So, theoretically they could even co-exist at this point of time, provided that they got some love from upstream. But so far, the rename is half-hearted.
On further investigation, only some of the -devel files conflict (libtorrent.pc and the unsuffixed libtorrent.so symlink). I'll make only the -devel subpackage conflict with that of libtorrent, then.
For a library package and the limited /usr/bin namespace, these two file names are far too generic. They ought to be moved or renamed.
Well, these binaries are actually just examples of what can be done with this libtorrent. Would they be better suited as %doc perhaps?
The file COPYING is included in the main package already.
Perhaps; but as a matter of personal preference and to keep things explicitly clear, I prefer to package such files as %doc for every subpackage in a build.
This file is tuned for static linking, unfortunately, in that it links libraries which libtorrent.so.0 is linked against already.
Hmm. I was under the [apparently mistaken] impression that forcing the use of the system zlib would offset that from the ./configure script. A patch is underway.
Requires: openssl-devel
Where do you see this requirement?
Several OpenSSL headers are used via #include directives from files in the /include/libtorrent/asio/ssl directory (used for asynchronous SSL handshaking and whatnot). Thus, I have it pull in openssl-devel so that any potential build finds those headers as well.
When I home this evening, I'll bug upstream about the dump_torrent/make_torrent naming, as well as fix the issues presented in your comment.
Thanks.