https://bugzilla.redhat.com/show_bug.cgi?id=1515053
--- Comment #9 from Elliott Sales de Andrade <quantum.analyst(a)gmail.com> ---
(In reply to Ankur Sinha (FranciscoD) from comment #8)
In general, the build is fine, but there are a few bundling issues
that must
be
looked at.
Issues:
=======
- All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
Note: These BR are not needed: gcc-c++
See:
http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2
Please double check if g++ is required by this package.
That lint is outdated. gcc-c++ must be listed now.
There are a few bundling issues here:
- I'm not sure whether the various JS libraries that you're including can be
bundled. The guidelines here say they must be packaged separately too:
https://fedoraproject.org/wiki/JavaScript_libraries_packaging_guideline_d...
Unfortunately, the JS ecosystem never really seemed to have taken off as far as
packages go... As you can see that guideline has been a draft for 10 years.
- extern/asizeof is part of Pympler which is in Fedora. So that
should be
used
instead of the bundled copy:
https://src.fedoraproject.org/rpms/python-Pympler
It's a bundled library in pympler too.
- extern/json-minify is bundled too. I expect this needs to be
packaged
separately also as I've not been able to find it in the repos:
https://pypi.org/project/JSON_minify/
I think the package never existed before, so I will see if I can unbundle it
upstream.
===== SHOULD items =====
Generic:
[!]: Avoid bundling fonts in non-fonts packages.
Note: Package contains font files
I haven't been able to locate them. Please check for these.
I don't see any either.
===== EXTRA items =====
Rpmlint (installed packages)
----------------------------
- This could be improved as "Documentation for %{name}" which would also get
rid of this error.
asv-doc.x86_64: W: summary-not-capitalized C asv documentation
Will fix.
- These should likely be removed (see comment on bundling above)
asv.x86_64: E: wrong-script-interpreter
/usr/lib64/python3.6/site-packages/asv/extern/asizeof.py /usr/bin/env python
asv.x86_64: E: non-executable-script
/usr/lib64/python3.6/site-packages/asv/extern/asizeof.py 644 /usr/bin/env
python
Will fix.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component