https://bugzilla.redhat.com/show_bug.cgi?id=863795
--- Comment #2 from Karol Trzcionka <karlikt(a)gmail.com> ---
Spec URL:
http://karlik.fedorapeople.org/kadu.spec
SRPM URL:
http://karlik.fedorapeople.org/kadu-0.12.2-2.fc19.src.rpm
I do some cleanup. Most of the problems was the heritage of previous
maintainer.
Use %global instead of %define.
DONE
There's a libiris bundle. Rex managed to create a separate package:
https://bugzilla.redhat.com/show_bug.cgi?id=749885
I've disabled temporarily jabber_protocol because there is not origin libiris
but it is modified. I try to contact with devs, maybe it would be exception:
http://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries#Needing_unre...
It doesn't provide own iris library (in fact, it is compiled and statically
linked).
Don't BR phonon, sqlite and the likes. Only BR the devel sub-packages.
DONE
Since you can't go for EPEL 5, please remove buildroot definition, clean
section and the first rm in the install section. defattr is no longer necessary
either.
DONE
What's the idea of having -k with make?
I didn't notice it, removed.
I can't see why several sub-packages should be GPLv3+. Sub-packages should use
the ?_isa macro when requiring the base package.
I'm not the lawyer, I think it was added because the external plugins are
GPLv3+, the core client is GPL2v+.
You can use the name macro in Source0. You can drop "-n kadu-%{version}" from
the setup macro.
DONE
I noticed this warning:
+ desktop-file-install --vendor fedora --delete-original --dir
/home/makerpm/rpmbuild/BUILDROOT/kadu-0.12.2-1.fc16.x86_64/usr/share/applications
/home/makerpm/rpmbuild/BUILDROOT/kadu-0.12.2-1.fc16.x86_64/usr/share/applications/kadu.desktop
/home/makerpm/rpmbuild/BUILDROOT/kadu-0.12.2-1.fc16.x86_64/usr/share/applications/fedora-kadu.desktop:
warning: value "Instant Messenger" for key "Comment" in group
"Desktop Entry"
looks redundant with value "Instant Messenger" of key "GenericName"
/home/makerpm/rpmbuild/BUILDROOT/kadu-0.12.2-1.fc16.x86_64/usr/share/applications/fedora-kadu.desktop:
warning: value "Komunikator internetowy" for key "Comment[pl]" in
group
"Desktop Entry" looks redundant with value "Komunikator internetowy"
of key
"GenericName[pl]"
I think it is not a problem, the desktop file is provided by upstream.
The locales are not handled properly, please compare
http://fedoraproject.org/wiki/Packaging:Guidelines#Handling_Locale_Files
DONE.
I personally consider the files section a bit over-detailled.
I think now it's better.
--
You are receiving this mail because:
You are on the CC list for the bug.