Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: gnome-themes-extras - extra themes for gnome
https://bugzilla.redhat.com/show_bug.cgi?id=372161
------- Additional Comments From alexl@users.sourceforge.net 2008-01-09 07:16 EST ------- MUST FIX items:
1) OK, I think that we should go back to the monolithic package for the moment, to avoid duplication of docs and to make sure upgrades from the old gnome-themes-extras goes smoothly.
The good news is that I did a koji build on rawhide that worked:
http://koji.fedoraproject.org/koji/taskinfo?taskID=336678
Also there are some (mostly) small issues with running rpmlint on the packages
$ rpmlint *.rpm
gnome-themes-extras.src: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 20) gnome-themes-extras-darklooks.noarch: W: summary-not-capitalized darklooks theme gnome-themes-extras-darklooks.noarch: E: description-line-too-long Darklooks is a meta-theme that is part of the gnome-themes-extras package. This package gnome-themes-extras-foxtrot.noarch: E: description-line-too-long Foxtrot is a meta-theme that is part of the gnome-themes-extras package. This package gnome-themes-extras-gion.noarch: E: description-line-too-long Gion is a meta-theme that is part of the gnome-themes-extras package. This package gnome-themes-extras-neu.noarch: W: spelling-error-in-description pacakge package gnome-themes-extras-neu.noarch: E: description-line-too-long Neu is a meta-theme that is part of the gnome-themes-extras pacakge. This package
2) Remember, Description lines should be no longer than 80 chars, and that Summary should start with a capital letter.
3) You are also mixing tabs and spaces in the spec file which makes the spec file look odd in different editors, for example in Emacs it looks like this:
%package foxtrot Requires: gnome-icon-theme, gnome-themes Group: User Interface/Desktops Summary: Foxtrot metatheme %description foxtrot Foxtrot is a meta-theme that is part of the gnome-themes-extras package. This package requires that you use a Gnome 2.2 release or newer.
4) * Mon Jan 7 2008 Marc Wiriadisastra marc@mwiriadi.id.au - 2.20-3 - Added patches to remove non-licensed themes
isn't true any more, so should be removed/updated.