https://bugzilla.redhat.com/show_bug.cgi?id=1475483
Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |zbyszek@in.waw.pl Assignee|nobody@fedoraproject.org |zbyszek@in.waw.pl Flags| |fedora-review?
--- Comment #1 from Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl --- http://wiki.qt.io/Qbs → https:// http://download.qt.io/official_releases/ → https://
LGPLv2 and LGPLv3, with exceptions
I think this should be "LGPLv2 with exceptions and LGPLv3 with exceptions" (following https://fedoraproject.org/wiki/Licensing:Main#Software_License_List).
# qbs was previously packaged as part of qt-creator, using the qt-creator version Obsoletes: %{name} < 0:4.4.0
Shouldn't this be "qt-creator < 0:4.4.0" instead? Also, note that the new qt-creator package should have Obsoletes: %{name} < 0:4.4.0, so called self-obsoletes, so that both packages are installed during upgrade.
s/Examples for projects/Example projects/
https://fedoraproject.org/wiki/Packaging:Scriptlets#Shared_libraries are needed.
Looks good otherwise.