Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=544628
Thomas Spura tomspur@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Blocks| |544629, 544630 AssignedTo|nobody@fedoraproject.org |tomspur@fedoraproject.org Flag| |fedora-review+
--- Comment #3 from Thomas Spura tomspur@fedoraproject.org 2009-12-21 07:37:37 EDT --- Review:
Good: - license ok - name ok - buildroot ok (unneeded in fedora) - parallel make - %clean section there - %files section ok * owns all directories it creates * requires d-bus for one folder - buildrequires/requires ok - builds in koji http://koji.fedoraproject.org/koji/taskinfo?taskID=1882908 - noarch not possible - no *.la files - no shared libs - %doc ok
Needswork: - URL still wrong, see comment #1 - from https://fedoraproject.org/wiki/Packaging/Guidelines#Libexecdir 'Packagers are highly encouraged to store libexecdir files in a package-specific subdirectory of %{_libexecdir}, such as %{_libexecdir}/%{name}' - What's the status of the xslt script?
############################
Please fix the url; subdirectory of %{_libexecdir} and 'Is programm working as expected?' are just 'should' items.
############################
APPROVED