Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=468189
--- Comment #11 from Fabian Affolter fabian@bernewireless.net 2008-11-10 16:39:04 EDT --- I really think that the remove of the SuSE releated stuff from the spec file would make it more readable.
- sorry, the right URL is Source0: http://downloads.sourceforge.net/%%7Bname%7D/%%7Bname%7D-%%7Bversion%7D.tar....
- Your Buildroot don't match the Guidelines https://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag
- %defattr(-,root,root) is often %defattr(-,root,root,-) to leave the default directory permissions in place
- Changelog: After every entry a blank line would be nice. It's definitely easier to read
- License: Spec file: GPLv3+ rear GPLv2+
- Clean your Buildroot before you start doing stuff there rm -rf %{buildroot} or rm -rf $RPM_BUILD_ROOT
- cp -a usr etc $RPM_BUILD_ROOT/ Please preserve the timestamps https://fedoraproject.org/wiki/Packaging/Guidelines#Timestamps
- Warning during rpm build process warning: File listed twice: /etc/rear/Debian/ia64.conf warning: File listed twice: /etc/rear/GNU/Linux.conf ... ... only add %config(noreplace) %{_sysconfdir}/rear/ (delete all other lines with %config(noreplace) %{_sysconfdir}/rear/*.*) to add that directory and its contents recursively (beware not tested and not sure about the permissions)