Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: xmlroff - A XSL-FO processor
https://bugzilla.redhat.com/show_bug.cgi?id=261581
mtasaka@ioa.s.u-tokyo.ac.jp changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mtasaka@ioa.s.u-tokyo.ac.jp
------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2007-10-15 13:38 EST ------- Please check your packages by rpmlint before submitting to review request.
For 0.5.2-1:
* Dependency between subpackags - Please check the dependency between subpackages of this srpm - xmlroff should have "libfo = %{version}-%{release}" - libfo-devel should have "libfo = %{version}-%{release}".
* Requires - Would you explain why libfo-devel should require libxslt-devel?
* ldconfig - Please call ldconfig for libraries under %_libdir on scriptlets.
* Documents - The dependency order is that xmlroff requires libfo. So if only libfo is installed, no documents (COPYING, AUTHORS and so on) are installed, which is not proper.
* Directory ownership - Please check the owner of %_datadir/xml . On my system, -------------------------------------------------------- $ rpm -qf /usr/share/xml xml-common-0.6.3-21.fc8 libglade2-2.6.2-3.fc8 -------------------------------------------------------- However xmlroff requires neither of these packages.
* pkgconfig .pc file - should be installed in -devel package. - And the package containing .pc file must have "Requires: pkgconfig".
* Timestamp - To keep timestamps, please use ------------------------------------------------------- make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p" ------------------------------------------------------- This method usually works for recent Makefiles.