https://bugzilla.redhat.com/show_bug.cgi?id=1361659
Douglas Schilling Landgraf dougsland@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Flags| |fedora-review?
--- Comment #1 from Douglas Schilling Landgraf dougsland@redhat.com --- Hi Yaniv,
fedora-review initially shared below, could you please review the following?
- All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. Note: These BR are not needed: rpm-build
- Uses parallel make %{?_smp_mflags} macro.
- Do not use config for tmpfilesdir (%config(noreplace) %{_tmpfilesdir}/%{vdsm_name}.conf)
%{_tmpfilesdir} expands to %{_prefix}/lib/tmpfiles.d which is the location that the package's default tmpfile creation scripts should install into. %{_tmpfilesdir}/%{name}.conf is not marked as a %config file because it is not supposed to be edited by administrators. Administrators can override the package's %{name}.conf by placing an identically named file in /etc/tmpfiles.d/, but this should very rarely be needed.
The requires of python-devel must be updated - Package contains BR: python2-devel or python3-devel
- Try to reduce the number of output of rpmlint