Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=478388
--- Comment #2 from D Haley mycae@yahoo.com 2009-01-09 08:07:14 EDT --- SPEC URL: http://dhd.selfip.com/427e/udav-2.spec SRPM URL: http://dhd.selfip.com/427e/udav-0.5-2.fc10.src.rpm
- '%prep rm -rf $RPM_BUILD_ROOT' looks a bit unusual.
OK, it now uses %setup -q
- You should preserve the time stamps
- cp -p ...
Done. Pixmap now preserves timestamp.
make install ..... INSTALL="install -p"
Not required. The supplied makefile already does this (not an autoconf makefile anyway, so setting INSTALL won't do the right thing.)
Is 'Requires: qt4' necessary? I guess that rpm will pick this up
automatically. No, it isn't. Yes rpm will get it as mathgl has it as a Requires.Fixed.
- Please use %defattr(-,root,root,-) instead of %defattr(-,root,root)
OK. done.