Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: dojo - javascript library
https://bugzilla.redhat.com/show_bug.cgi?id=455541
sundaram@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |sundaram@redhat.com
------- Additional Comments From sundaram@redhat.com 2008-07-20 22:52 EST -------
rpmlint is not clean:
dojo.src: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 42) dojo.src: W: invalid-license AFL2.1 ---
dojo.noarch: W: file-not-utf8 /usr/share/dojo/dojo/cldr/LICENSE dojo.noarch: E: non-executable-script /usr/share/dojo/dojox/storage/buildFlashStorage.sh 0644 dojo.noarch: W: wrong-file-end-of-line-encoding /usr/share/dojo/dojox/encoding/LICENSE dojo.noarch: E: zero-length /usr/share/dojo/dojox/rpc/test.txt dojo.noarch: E: non-executable-script /usr/share/dojo/dojox/flash/tests/buildFlashTest.sh 0644 dojo.noarch: E: non-executable-script /usr/share/dojo/dojo/tests/io/upload.cgi 0644 dojo.noarch: E: non-executable-script /usr/share/dojo/util/doh/runner.sh 0644 dojo.noarch: W: invalid-license AFL2.1
---
You are listing these files for both macros, doc and datadir. The text files should all go under /usr/share/doc aka %doc.
warning: File listed twice: /usr/share/dojo/dijit/LICENSE warning: File listed twice: /usr/share/dojo/dojo/LICENSE warning: File listed twice: /usr/share/dojo/dojo/_firebug/LICENSE warning: File listed twice: /usr/share/dojo/dojo/cldr/LICENSE warning: File listed twice: /usr/share/dojo/dojo/cldr/README warning: File listed twice: /usr/share/dojo/dojo/resources/LICENSE warning: File listed twice: /usr/share/dojo/dojox/LICENSE warning: File listed twice: /usr/share/dojo/dojox/_sql/LICENSE warning: File listed twice: /usr/share/dojo/dojox/encoding/LICENSE warning: File listed twice: /usr/share/dojo/dojox/encoding/README warning: File listed twice: /usr/share/dojo/dojox/lang/LICENSE warning: File listed twice: /usr/share/dojo/dojox/lang/README warning: File listed twice: /usr/share/dojo/util/doh/LICENSE warning: File listed twice: /usr/share/dojo/util/doh/README
--
Your spec claims you are deleting the sounds. Yet on my installation of the package, I see
/usr/share/dojo/util/doh/_sounds/LICENSE /usr/share/dojo/util/doh/_sounds/doh.wav /usr/share/dojo/util/doh/_sounds/dohaaa.wav /usr/share/dojo/util/doh/_sounds/woohoo.wav
You should contact upstream and clarify licensing.