https://bugzilla.redhat.com/show_bug.cgi?id=1816858
--- Comment #7 from Cole Robinson crobinso@redhat.com --- (In reply to Christophe de Dinechin from comment #5)
Reviewed the spec file rapidly. Looks good to me with two notes:
- Do we need the -Sgit option for autosetup?
If using git format-patch output for .patch files in the repo, using -Sgit can be required in some instances IIRC, but I don't remember the details. We can probably get away with out it, it's just what I use by default.
- I would use the same DESTDIR for both make and make install. Often,
makefiles introduce hard-to-debug dependencies on make variables, we don't want some mysterious failure down the line.
Good point, I will add that before committing