https://bugzilla.redhat.com/show_bug.cgi?id=1540335
--- Comment #5 from Kim Walisch kim.walisch@gmail.com --- Hi Micheal,
Thanks for your feedback. I have fixed the issues you pointed out and pushed a new version of the spec and SRPM to GitHub:
Spec URL: https://raw.githubusercontent.com/kimwalisch/primesieve-rpm/master/primesiev... SRPM URL: https://raw.githubusercontent.com/kimwalisch/primesieve-rpm/master/primesiev...
Note that I have also fixed the following issues pointed out by Jerry James:
%post -p /sbin/ldconfig %postun -p /sbin/ldconfig
should be replaced with this: %ldconfig_scriptlets
1) Done, use ldconfig_scriptlets.
Also, the spec file at the URL given in the review bug has release number 2, but the one inside the SRPM has release number 1. Make sure those match.
2) Done, spec release number now matches SRPM release number.
...it is a good idea for the binary and the library to
be in separate packages.
3) I have now put the binary in the primesieve package, the shared libprimesieve and the header files are in the libprimesieve-devel package and the static libprimesieve is in the libprimesieve-static package. The naming of the packages is similar to Debian/Ubuntu where the binary is in primesieve and the libraries and header in libprimesieve-dev.