Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: bitlbee
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=196591
panemade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |panemade@gmail.com
------- Additional Comments From panemade@gmail.com 2006-06-26 01:27 EST ------- Not an official review as I'm not yet sponsored Mock build for development i386 is successfull with some warnings as warning: dereferencing type-punned pointer will break strict-aliasing rules
MUST Items: - MUST: rpmlint shows error E: bitlbee configure-without-libdir-spec A configure script is run without specifying the libdir. configure options must be augmented with something like --libdir=%{_libdir}. - MUST: dist tag is present - MUST: The package is named according to the Package Naming Guidelines. - MUST: The spec file name matching the base package bitlbee, in the format bitlbee.spec - MUST: This package meets the Packaging Guidelines. - MUST: The package is licensed with an open-source compatible license GPL. - MUST: The License field in the package bitlbee.spec file matches the actual license file COPYING in tarball. - MUST: The sources used to build the package matches the upstream source, as provided in the spec URL. md5sum is correct. - MUST: This package owns all directories that it creates. - MUST: This package did not contain any duplicate files in the %files listing. - MUST: This package have a %clean section, which contains rm -rf $RPM_BUILD_ROOT. - MUST: This package used macros. - MUST: Document files are included like INSTALL README. - MUST: This Package include a bitlbee.desktop file, and that file is installed with desktop-file-install in the %install section successfully. - MUST: Package is calling ldconfig on postun post successfully. * Source URL is present. * BuildRoot is correct BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) * BuildRequires is correct
What You Need to Do:- * Add --libdir=%{_libdir) to %configure * Add subpackage -doc as document files are more in base package.