Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=468189
Fabian Affolter fabian@bernewireless.net changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |fabian@bernewireless.net
--- Comment #2 from Fabian Affolter fabian@bernewireless.net 2008-10-24 03:31:44 EDT --- Just a few comments on your spec file.
Release: 1
- add %{?dist} -> Release: 1%{?dist}
Source: rear-%{version}.tar.gz
- The source should come from upstream. Source0: http://downloads.sourceforge.net/%%7Bname%7D/%%7Bname%7D-%%7Bversion%7D.tar.... https://fedoraproject.org/wiki/Packaging/SourceURL
License: GPL
- is GPLv3+ https://fedoraproject.org/wiki/Packaging/LicensingGuidelines
Packager: Schlomo Schapiro sschapiro@probusiness.de, Gratien D'haese gratien.dhaese@it3.be
- Packager tag is not used in Fedora
Provides: rear
- This package doesn't provide any virtual packages. I think it's save to remove
https://fedoraproject.org/wiki/PackageMaintainers/CreatingPackageHowTo#Other...
Vendor: probusiness Berlin AG and IT3 Consultants
- Vendor tag is not used in Fedora
%files section
- Please use macros it will be easier to maintain the package in the future https://fedoraproject.org/wiki/PackageMaintainers/CreatingPackageHowTo#Macro...
Details about the changelog https://fedoraproject.org/wiki/Packaging/Guidelines#Changelogs
Please check https://fedoraproject.org/wiki/PackageMaintainers/CreatingPackageHowTo or https://fedoraproject.org/wiki/Packaging/Guidelines for further details.