https://bugzilla.redhat.com/show_bug.cgi?id=1529824

Martin Juhl mj@casalogic.dk changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |mj@casalogic.dk Component|Package Review |Package Review Version|rawhide |epel7 Product|Fedora |Fedora EPEL

https://bugzilla.redhat.com/show_bug.cgi?id=1529824

Neal Gompa ngompa13@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |ngompa13@gmail.com Component|Package Review |Package Review Version|epel7 |rawhide Product|Fedora EPEL |Fedora

https://bugzilla.redhat.com/show_bug.cgi?id=1529824

--- Comment #3 from Neal Gompa ngompa13@gmail.com --- This package spec is terribly broken, and doesn't follow *any* of the packaging guidelines at all.

Please review the guidelines and rework the spec accordingly: https://fedoraproject.org/wiki/Packaging:Guidelines

https://bugzilla.redhat.com/show_bug.cgi?id=1529824

--- Comment #5 from Neal Gompa ngompa13@gmail.com --- This covers the major issues:

* Amazon Linux doesn't use Upstart anymore. They just released Amazon Linux 2, which uses systemd and they're no longer supporting Amazon Linux AMI v1 (which used upstart). Aside from that, packages for Fedora and EPEL cannot have Amazon Linux specific conditionals.

c.f.: https://fedoraproject.org/wiki/Packaging:Guidelines#Spec_Legibility

* Your Source0 is invalid. It needs to point to valid URL or have a comment of some kind describing where it came from.

c.f.: https://fedoraproject.org/wiki/Packaging:SourceURL

* License is wrong. It's "ASL 2.0", not GPLv3: https://github.com/ansible/awx/blob/devel/LICENSE.md

* Vendor, Prefix, and BuildRoot tags MUST NOT be used. * Group is not mandatory, but when used, should match one of the following groups: https://fedoraproject.org/wiki/RPMGroups

c.f.: https://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections c.f.: https://fedoraproject.org/wiki/Packaging:Guidelines#Relocatable_packages

* Packaging virtualenvs is not permitted in Fedora. Moreover, there is no internet access in the build environment, so packaging virtualenvs is functionally impossible.

c.f.: https://fedoraproject.org/wiki/Packaging:Guidelines#Build_time_network_acces...

* Web app files should be installed into `/usr/share/%{name}` rather than in a weird virtualenv location.

c.f.: https://fedoraproject.org/wiki/Packaging:Guidelines#Web_Applications

Packages like AWX can absolutely work in Fedora and EPEL, you just need to leverage the system packages for its dependent components.

https://bugzilla.redhat.com/show_bug.cgi?id=1529824

Raphael Groner projects.rg@smart.ms changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |projects.rg@smart.ms

--- Comment #7 from Raphael Groner projects.rg@smart.ms ---

Source0: /dist/awx-1.0.2.0.tar.gz

Where do you get the sources from? Please add some comments or URL. https://fedoraproject.org/wiki/Licensing:Main https://fedoraproject.org/wiki/Packaging:Guidelines#Code_Vs_Content

aws is already choosen as a package name. We would have to use another name, maybe try aws-management? https://src.fedoraproject.org/rpms/aws https://fedoraproject.org/wiki/Packaging:Guidelines#Spec_File_Naming

Propably we need some help from legal team.

https://bugzilla.redhat.com/show_bug.cgi?id=1529824

--- Comment #9 from Martin Juhl mj@casalogic.dk --- @Raphael: the package is right now named awx, not aws.. should it still be named ansible-awx?

Thanks for the suggestions.. right now i'm trying to sort out the dependency hell, that is need for AWX to run (pip packages for most).. and how many of them are already in EPEL/RHEL/CentOS and in which versions..