Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: perl-HTML-PrettyPrinter - Generate nice HTML files from HTML syntax trees

https://bugzilla.redhat.com/show_bug.cgi?id=428112

------- Additional Comments From huzaifas@redhat.com 2008-01-09 06:06 EST ------- Just one small thing i saw that is: i would replace %{__perl} Makefile.PL INSTALLDIRS=vendor with %{__perl} Makefile.PL INSTALLDIRS=vendor OPTIMIZE="$RPM_OPT_FLAGS"

I am also not sure if we need " || :" after check

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: perl-HTML-PrettyPrinter - Generate nice HTML files from HTML syntax trees

https://bugzilla.redhat.com/show_bug.cgi?id=428112

panemade@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@fedoraproject.org |panemade@gmail.com Status|NEW |ASSIGNED Flag| |fedora-review+

------- Additional Comments From panemade@gmail.com 2008-01-09 07:07 EST ------- As this package is not compiling anything in build stage no need of OPTIMIZE="$RPM_OPT_FLAGS"

I don't think you need to set -x and set +x

Don't think you need %check ||:

Review: + package builds in mock (development i386). + rpmlint is silent for SRPM and for RPM. + source files match upstream url 4d3f84ba4e35cb7fac863b828b7f2b68 HTML-PrettyPrinter-0.03.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave PERL_DL_NONLAZY=1 /usr/bin/perl "-Iblib/lib" "-Iblib/arch" test.pl 1..3 # Running under perl version 5.008008 for linux # Current time local: Wed Jan 9 06:55:34 2008 # Current time GMT: Wed Jan 9 11:55:34 2008 # Using Test.pm version 1.25 ok 1 ok 1 ok 2 ok 3 exit 0 + Package perl-HTML-PrettyPrinter-0.03-1.fc9 -> Provides: perl(HTML::PrettyPrinter) = 0.03 Requires: perl(:MODULE_COMPAT_5.8.8) perl(Carp) perl(Exporter) perl(strict) perl(vars) APPROVED.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: perl-HTML-PrettyPrinter - Generate nice HTML files from HTML syntax trees

https://bugzilla.redhat.com/show_bug.cgi?id=428112

kevin@tummy.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+

------- Additional Comments From kevin@tummy.com 2008-01-09 13:22 EST ------- cvs done.