9:02 p.m.
https://bugzilla.redhat.com/show_bug.cgi?id=1280141
Bug ID: 1280141
Summary: Review Request: python-psychopy - Psychophysics
toolkit for Python
Product: Fedora
Version: rawhide
Component: Package Review
Severity: medium
Priority: medium
Assignee: nobody(a)fedoraproject.org
Reporter: aalves(a)gmail.com
QA Contact: extras-qa(a)fedoraproject.org
CC: package-review(a)lists.fedoraproject.org
Spec URL: https://alvesadrian.fedorapeople.org/neurofedora/python-psychopy.spec
SRPM URL:
https://alvesadrian.fedorapeople.org/neurofedora/python-psychopy-1.83.01-...
Description: PsychoPy uses OpenGL and Python to create a toolkit
for running psychology/neuroscience/psychophysics
experiments.
Fedora Account System Username: alvesadrian
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
1:31 a.m.
New subject: [Bug 1280141] Review Request: python-psychopy - Psychophysics toolkit for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1280141
Igor Gnatenko <i.gnatenko.brain(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |i.gnatenko.brain(a)gmail.com
Blocks| |1276941 (fedora-neuro)
Alias| |python-psychopy
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1276941
[Bug 1276941] Fedora NeuroImaging and NeuroScience tracking bug
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
1:32 a.m.
New subject: [Bug 1280141] Review Request: python-psychopy - Psychophysics toolkit for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1280141
Igor Gnatenko <i.gnatenko.brain(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
Assignee|nobody(a)fedoraproject.org |i.gnatenko.brain(a)gmail.com
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
1:45 a.m.
New subject: [Bug 1280141] Review Request: python-psychopy - Psychophysics toolkit for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1280141
--- Comment #1 from Igor Gnatenko <i.gnatenko.brain(a)gmail.com> ---
Before I will do full review fix major issues:
psychopy/LICENSES.txt. You should unbundle those. For ttf - patch to use system
--------------------------------------------------------------------------------
- pyparallel (http://pyserial.sourceforge.net/pyparallel.html). License: Python
Software Foundation
- quest (http://www.visionegg.org/Quest). License: BSD
- psychopy/app/Resources/DejaVuSerif.ttf. License: BSD-like (see below for full
list of terms)
--------------------------------------------------------------------------------
I don't see any adventures why you packaging latest commit. It's not acceptable
without good reason because since last release was only 44 commits.
--------------------------------------------------------------------------------
Source0:
https://github.com/psychopy/psychopy/archive/%{commit}/%{modname}-%{short...
--------------------------------------------------------------------------------
You don't have any BuildRequires/Requires for this package. I opened only one
file and already see dependency on wxPython.
https://github.com/psychopy/psychopy/blob/master/psychopy/app/_psychopyAp...
From .travis.yml I see at least pygame, gevent, psutil, msgpack,
pandas and
many others.
This wildcard I think not good, because I guess there only 1 directory.
--------------------------------------------------------------------------------
%{python2_sitelib}/%{modname}*
--------------------------------------------------------------------------------
If you're using version you should use macros! But I'd recommend to use
%{python2_sitelib}/PsychoPy*.egg-info
--------------------------------------------------------------------------------
%{python2_sitelib}/PsychoPy-1.83.1-py2.7.egg-info/*
--------------------------------------------------------------------------------
Changelog for sure incorrect. Release is incorrect (you must bump version and
use 0.1.git...., but don't do this and stick to release).
And last BIG issue: You DONT run tests. You MUST.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
1:50 a.m.
New subject: [Bug 1280141] Review Request: python-psychopy - Psychophysics toolkit for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1280141
--- Comment #2 from Igor Gnatenko <i.gnatenko.brain(a)gmail.com> ---
and one more comment:
- Package installs a %{name}.desktop using desktop-file-install or desktop-
file-validate if there is such a file.
- update-desktop-database is invoked in %post and %postun if package
contains desktop file(s) with a MimeType: entry.
Note: desktop file(s) with MimeType entry in python2-psychopy
See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#desktop-
database
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
9:16 a.m.
New subject: [Bug 1280141] Review Request: python-psychopy - Psychophysics toolkit for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1280141
Igor Gnatenko <i.gnatenko.brain(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |1290995
| |(python-visionegg-quest)
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1290995
[Bug 1290995] Review Request: python-visionegg-quest - QUEST algorithm for
finding threshold
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
9:20 a.m.
New subject: [Bug 1280141] Review Request: python-psychopy - Psychophysics toolkit for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1280141
Igor Gnatenko <i.gnatenko.brain(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks|1290995 |
|(python-visionegg-quest) |
Depends On| |1290995
| |(python-visionegg-quest)
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1290995
[Bug 1290995] Review Request: python-visionegg-quest - QUEST algorithm for
finding threshold
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
12:55 a.m.
New subject: [Bug 1280141] Review Request:
python-psychopy - Psychophysics toolkit for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1280141
Igor Gnatenko <ignatenko(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |aalves(a)gmail.com
Flags| |needinfo?(aalves(a)gmail.com)
--- Comment #3 from Igor Gnatenko <ignatenko(a)redhat.com> ---
ping?
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
10:04 a.m.
New subject: [Bug 1280141] Review Request:
python-psychopy - Psychophysics toolkit for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1280141
--- Comment #4 from Igor Gnatenko <ignatenko(a)redhat.com> ---
ping once more?
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
4:20 p.m.
New subject: [Bug 1280141] Review Request:
python-psychopy - Psychophysics toolkit for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1280141
Paul W. Frields <pfrields(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|ignatenko(a)redhat.com |i.gnatenko.brain(a)gmail.com
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
4:08 a.m.
New subject: [Bug 1280141] Review Request:
python-psychopy - Psychophysics toolkit for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1280141
Ankur Sinha (FranciscoD) <sanjay.ankur(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |sanjay.ankur(a)gmail.com
--- Comment #5 from Ankur Sinha (FranciscoD) <sanjay.ankur(a)gmail.com> ---
Adrian,
Would you like to continue the review? Otherwise I can submit the package for
review to be included in neuro-fedora.
Cheers,
Ankur
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
2:29 a.m.
New subject: [Bug 1280141] Review Request:
python-psychopy - Psychophysics toolkit for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1280141
Bug 1280141 depends on bug 1290995, which changed state.
Bug 1290995 Summary: Review Request: python-visionegg-quest - QUEST algorithm for finding
threshold
https://bugzilla.redhat.com/show_bug.cgi?id=1290995
What |Removed |Added
----------------------------------------------------------------------------
Status|POST |CLOSED
Resolution|--- |WONTFIX
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
5:27 a.m.
New subject: [Bug 1280141] Review Request:
python-psychopy - Psychophysics toolkit for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1280141
Ankur Sinha (FranciscoD) <sanjay.ankur(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |CLOSED
Blocks|1276941 (fedora-neuro) |201449 (FE-DEADREVIEW)
Resolution|--- |WONTFIX
Flags|needinfo?(aalves(a)gmail.com) |
Last Closed| |2018-08-22 06:27:45
--- Comment #6 from Ankur Sinha (FranciscoD) <sanjay.ankur(a)gmail.com> ---
Closing this one too. We'll do a fresh review when time permits.
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=201449
[Bug 201449] FE-DEADREVIEW -- Reviews stalled due to lack of submitter
response should be blocking this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=1276941
[Bug 1276941] Fedora NeuroImaging and NeuroScience tracking bug
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
7:13 a.m.
New subject: [Bug 1280141] Review Request:
python-psychopy - Psychophysics toolkit for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1280141
Bug 1280141 depends on bug 1290995, which changed state.
Bug 1290995 Summary: Review Request: python-visionegg-quest - QUEST algorithm for finding
threshold
https://bugzilla.redhat.com/show_bug.cgi?id=1290995
What |Removed |Added
----------------------------------------------------------------------------
Status|CLOSED |POST
Resolution|WONTFIX |---
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
8:13 p.m.
New subject: [Bug 1280141] Review Request:
python-psychopy - Psychophysics toolkit for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1280141
Bug 1280141 depends on bug 1290995, which changed state.
Bug 1290995 Summary: Review Request: python-visionegg-quest - QUEST algorithm for finding
threshold
https://bugzilla.redhat.com/show_bug.cgi?id=1290995
What |Removed |Added
----------------------------------------------------------------------------
Status|ON_QA |CLOSED
Resolution|--- |ERRATA
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
1986
days inactive
3083
days old
package-review@lists.fedoraproject.org
14 comments
2 participants
participants (2)
-
bugzilla＠redhat.com -
Red Hat Bugzilla