Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: perl-MooseX-GlobRef-Object - Store a Moose object in glob reference
https://bugzilla.redhat.com/show_bug.cgi?id=485963
Summary: Review Request: perl-MooseX-GlobRef-Object - Store a Moose object in glob reference Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: allisson@gmail.com QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora
Spec URL: http://allisson.fedorapeople.org/packages/perl-MooseX-GlobRef-Object/perl-Mo...
SRPM URL: http://allisson.fedorapeople.org/packages/perl-MooseX-GlobRef-Object/perl-Mo...
Description: This meta-policy allows to store Moose object in glob reference or file handle. The class attributes will be stored in anonymous hash associated with glob reference. It allows to create a Moose version of IO::Handle.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=485963
manuel wolfshant wolfy@nobugconsulting.ro changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@fedoraproject.org |wolfy@nobugconsulting.ro Flag| |fedora-review?
--- Comment #1 from manuel wolfshant wolfy@nobugconsulting.ro 2009-02-17 19:59:18 EDT --- ==============
Key: - = N/A x = Check ! = Problem ? = Not evaluated
=== REQUIRED ITEMS === [x] Package is named according to the Package Naming Guidelines. [x] Spec file name must match the base package %{name}, in the format %{name}.spec. [x] Package meets the Packaging Guidelines including the Perl specific items [x] Package successfully compiles and builds into binary rpms on at least one supported architecture. Tested on: devel/x86_64 [x] Rpmlint output: source RPM: empty binary RPM:empty [x] Package is not relocatable. [x] Buildroot is correct (%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)) [x] Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x] License field in the package spec file matches the actual license. License type: GPL+ or Artistic (same as perl) [x] If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x] Spec file is legible and written in American English. [x] Sources used to build the package matches the upstream source, as provided in the spec URL. SHA1SUM of package: 82d43233eb7f585b6523cdc8fe2f133a150e9752 MooseX-GlobRef-Object-0.04.tar.gz [x] Package is not known to require ExcludeArch [x] All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [-] The spec file handles locales properly. [-] ldconfig called in %post and %postun if required. [x] Package must own all directories that it creates. [x] Package requires other packages for directories it uses. [x] Package does not contain duplicates in %files. [x] Package does not contain duplicates in %files. [x] Permissions on files are set properly. [x] Package has a %clean section, which contains rm -fR $RPM_BUILD_ROOT. [x] Package consistently uses macros. [x] Package contains code, or permissable content. [-] Large documentation files are in a -doc subpackage, if required. [x] Package uses nothing in %doc for runtime. [-] Header files in -devel subpackage, if present. [-] Static libraries in -devel subpackage, if present. [-] Package requires pkgconfig, if .pc files are present. [-] Development .so files in -devel subpackage, if present. [-] Fully versioned dependency in subpackages, if present. [x] Package does not contain any libtool archives (.la). [-] Package contains a properly installed %{name}.desktop file if it is a GUI application. [x] Package does not own files or directories owned by other packages.
=== SUGGESTED ITEMS === [x] Latest version is packaged. [x] Package does not include license text files separate from upstream. [-] Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x] Reviewer should test that the package builds in mock. Tested on: devel/x86_64 [?] Package should compile and build into binary rpms on all supported architectures. Tested on: [?] Package functions as described. [-] Scriptlets must be sane, if used. [-] The placement of pkgconfig(.pc) files is correct. [-] File based requires are sane. [x] %check is present and the tests pass.
----Issue----- All seem well but according to http://search.cpan.org/dist/MooseX-GlobRef-Object/ the latest release is 0.06, which makes packaging 0.04 a bit odd. Any special reason to use an older version of the tarball ?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=485963
--- Comment #2 from Allisson Azevedo allisson@gmail.com 2009-02-17 20:41:34 EDT --- Thanks for report, i'll update to use latest release.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=485963
manuel wolfshant wolfy@nobugconsulting.ro changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
--- Comment #3 from manuel wolfshant wolfy@nobugconsulting.ro 2009-02-18 02:43:16 EDT --- I am going to trust you to do it before import. APPROVED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=485963
Allisson Azevedo allisson@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
--- Comment #4 from Allisson Azevedo allisson@gmail.com 2009-02-18 05:24:30 EDT --- New Package CVS Request ======================= Package Name: perl-MooseX-GlobRef-Object Short Description: Store a Moose object in glob reference Owners: allisson Branches: F-9 F-10
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=485963
Kevin Fenzi kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
--- Comment #5 from Kevin Fenzi kevin@tummy.com 2009-02-18 15:03:25 EDT --- cvs done.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=485963
Allisson Azevedo allisson@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=485963
Petr Pisar ppisar@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |ppisar@redhat.com Flag|fedora-cvs+ |fedora-cvs?
--- Comment #6 from Petr Pisar ppisar@redhat.com 2012-01-12 06:32:48 EST --- Package Change Request ====================== Package Name: perl-MooseX-GlobRef-Object New Branches: Owners: InitialCC: perl-sig
Please add perl-sig user with watch* permissions only to all Fedora branches.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=485963
--- Comment #7 from Jon Ciesla limburgher@gmail.com 2012-01-12 08:08:49 EST --- Done.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=485963
Iain Arnell iarnell@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |iarnell@gmail.com
--- Comment #8 from Iain Arnell iarnell@gmail.com 2012-01-12 08:22:49 EST --- NOTE. This package has been replaced by perl-MooseX-GlobRef (see bug 591775 and bug 682754). It was already blocked in koji since f16 and I completed the formal retirement earlier today after it was orphaned from cweyl. Please don't try to resurrect it.
package-review@lists.fedoraproject.org