https://bugzilla.redhat.com/show_bug.cgi?id=771297
Michal Fojtik <mfojtik(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC|package-review(a)lists.fedora |
|project.org |
--- Comment #8 from Michal Fojtik <mfojtik(a)redhat.com> ---
(In reply to Vít Ondruch from comment #7)
* Remove BuildRoot
- BuildRoot is not needed, unles you plan to ship this in EPE5 (but in that
case, you miss a whole lot of stuff there ;)
check.
* Remove %clean section
- Not needed anymore.
check.
* Use the library from %{buildroot}%{gem_instdir}/lib/
- I.e. you should replace:
- mv %{buildroot}%{gem_instdir}/ext/bluecloth_ext.so \
%{buildroot}%{gem_extdir_mri}/ext/%{gem_name}/
+ mv %{buildroot}%{gem_libdir}/bluecloth_ext.so \
%{buildroot}%{gem_extdir_mri}/ext/%{gem_name}/
check.
* man pages
- Do not compress man pages. That should be done automatically by build
check.
system
- Refer them as "%doc %{_mandir}/man1/*" in %files section should be
enough.
check.
* Directory ownership
- %{gem_instdir} is not owned. Please uncomment the "%dir %{gem_instdir}"
macro.
check.
* Mark documentation by %doc macro
- Documentation should be marked by %doc macro. I am referring to the
following files:
%{gem_instdir}/LICENSE
%{gem_instdir}/LICENSE.discount
%{gem_instdir}/README.rdoc
%{gem_instdir}/History.rdoc
%{gem_instdir}/Manifest.txt
%{gem_instdir}/bluecloth.1.pod
check.
* Do not BR: rubygem(hoe)
- Not sure why are you requiring it.
check.
* Test suite
- It is definitely not RSpec 1.x only. It runs quite OK with RSpec 2.x.
There fails only several specs from spec/markdowntest_spec.rb, due to
missing tidy-ext. Please omit just the failing tests.
done.
* License
- Not sure about the licenses though. This is the licensecheck output:
$ licensecheck LICENSE
LICENSE: BSD (2 clause)
$ licensecheck LICENSE.discount
LICENSE.discount: MIT/X11 (BSD like)
The 'discount' license is for the 'discount' ruby gem which I guess this
gem
was bundling or something. However we are not bundling anything, so I think BSD
is correct here.
Thanks Vit for this review!
Spec URL:
http://omicron.mifo.sk/rubygem-bluecloth.spec
SRPM URL:
http://omicron.mifo.sk/rubygem-bluecloth-2.2.0-4.fc19.src.rpm
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=v97yomeClb&a=cc_unsubscribe