https://bugzilla.redhat.com/show_bug.cgi?id=1701810
Petr Pisar <ppisar(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags|fedora-review? |fedora-review+
--- Comment #3 from Petr Pisar <ppisar(a)redhat.com> ---
Changes in the spec file:
--- perl-Net-BGP.spec.old 2019-04-22 05:22:35.000000000 +0200
+++ perl-Net-BGP.spec 2019-04-24 23:30:07.000000000 +0200
@@ -6,7 +6,7 @@
Summary: Perl module for object-oriented API to the BGP protocol
Name: perl-Net-BGP
Version: 0.16
-Release: 1%{?dist}
+Release: 2%{?dist}
License: GPL+ or Artistic
URL:
https://metacpan.org/release/%{pkgname}
Source:
https://cpan.metacpan.org/authors/id/S/SS/SSCHECK/%{pkgname}-%{version}.t...
@@ -14,7 +14,11 @@
BuildRequires: perl-generators
BuildRequires: perl-interpreter
BuildRequires: make
+%if 0%{?rhel} && 0%{?rhel} <= 7
BuildRequires: perl(ExtUtils::MakeMaker)
+%else
+BuildRequires: perl(ExtUtils::MakeMaker) >= 6.77
+%endif
# Run-time
BuildRequires: perl(bytes)
BuildRequires: perl(Carp)
@@ -23,23 +27,23 @@
BuildRequires: perl(IO::Select)
BuildRequires: perl(IO::Socket)
BuildRequires: perl(overload)
-BuildRequires: perl(Scalar::Util)
+BuildRequires: perl(Scalar::Util) >= 1.01
BuildRequires: perl(strict)
BuildRequires: perl(vars)
# Tests
-BuildRequires: perl(Test::Harness) >= 2.00
+BuildRequires: perl(File::Find)
+BuildRequires: perl(File::Spec)
BuildRequires: perl(Test::More) >= 0.47
-BuildRequires: perl(Test::Signature)
BuildRequires: perl(Test::Pod) >= 0.95
BuildArch: noarch
%description
-An implementation of the BGP-4 inter-domain routing protocol as perl module.
+An implementation of the BGP-4 inter-domain routing protocol as Perl module.
It encapsulates all of the functionality needed to establish and maintain a
BGP peering session and exchange routing update information with the peer.
It aims to provide a simple API to the BGP protocol for the purposes of
automation, logging, monitoring, testing, and similar tasks using the power
-and flexibility of perl. The module does not implement the functionality of
+and flexibility of Perl. The module does not implement the functionality of
a RIB (Routing Information Base) nor does it modify the kernel routing table
of the host system. However, such operations could be implemented using the
API provided by the module.
@@ -48,23 +52,31 @@
%setup -q -n %{pkgname}-%{version}
%build
-perl Makefile.PL PREFIX=$RPM_BUILD_ROOT%{_prefix} INSTALLDIRS=vendor
-make %{?_smp_mflags}
+perl Makefile.PL INSTALLDIRS=vendor NO_PACKLIST=1 NO_PERLLOCAL=1
+%make_build
%install
-%makeinstall
+%make_install
+%if 0%{?rhel} && 0%{?rhel} <= 7
find $RPM_BUILD_ROOT \( -name perllocal.pod -o -name .packlist \) -exec rm -f
{} \;
+%endif
chmod -R u+w $RPM_BUILD_ROOT/*
+# Remove signature test (#1701810)
+rm -f t/00-Signature.t
+
%check
make test
%files
-%doc Changes
+%doc Changes README
%{perl_vendorlib}/Net/
%{_mandir}/man3/*.3pm*
%changelog
+* Wed Apr 24 2019 Robert Scheck <robert(a)fedoraproject.org> 0.16-2
+- Add corrections from package review (#1701810 #c1)
+
All issues resolved. Ok.
TODO: The version in 'perl(ExtUtils::MakeMaker) >= 6.77' should be
'6.76'. I
made a typo. Sorry.
TODO: Build-require coreutils for the 'rm' command.
TODO: Conditionally build-require findutils for the 'find' command.
All tests pass. Ok.
$ rpmlint perl-Net-BGP.spec ../SRPMS/perl-Net-BGP-0.16-2.fc31.src.rpm
../RPMS/noarch/perl-Net-BGP-0.16-2.fc31.noarch.rpm
/usr/share/rpmlint/Pkg.py:168: UnicodeWarning: decode() called on unicode
string, see
https://bugzilla.redhat.com/show_bug.cgi?id=1693751
s.decode('UTF-8')
/usr/share/rpmlint/Pkg.py:168: UnicodeWarning: decode() called on unicode
string, see
https://bugzilla.redhat.com/show_bug.cgi?id=1693751
s.decode('UTF-8')
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
rpmlint is Ok.
$ rpm -q -lv -p ../RPMS/noarch/perl-Net-BGP-0.16-2.fc31.noarch.rpm
drwxr-xr-x 2 root root 0 Apr 25 10:53
/usr/share/doc/perl-Net-BGP
-rw-r--r-- 1 root root 7647 Jan 28 2015
/usr/share/doc/perl-Net-BGP/Changes
-rw-r--r-- 1 root root 1257 Jan 28 2015
/usr/share/doc/perl-Net-BGP/README
-rw-r--r-- 1 root root 3279 Apr 25 10:52
/usr/share/man/man3/Net::BGP.3pm.gz
-rw-r--r-- 1 root root 3349 Apr 25 10:52
/usr/share/man/man3/Net::BGP::ASPath.3pm.gz
-rw-r--r-- 1 root root 3327 Apr 25 10:52
/usr/share/man/man3/Net::BGP::NLRI.3pm.gz
-rw-r--r-- 1 root root 2045 Apr 25 10:52
/usr/share/man/man3/Net::BGP::Notification.3pm.gz
-rw-r--r-- 1 root root 6796 Apr 25 10:52
/usr/share/man/man3/Net::BGP::Peer.3pm.gz
-rw-r--r-- 1 root root 2548 Apr 25 10:52
/usr/share/man/man3/Net::BGP::Process.3pm.gz
-rw-r--r-- 1 root root 1847 Apr 25 10:52
/usr/share/man/man3/Net::BGP::Refresh.3pm.gz
-rw-r--r-- 1 root root 2104 Apr 25 10:52
/usr/share/man/man3/Net::BGP::Transport.3pm.gz
-rw-r--r-- 1 root root 3040 Apr 25 10:52
/usr/share/man/man3/Net::BGP::Update.3pm.gz
drwxr-xr-x 2 root root 0 Apr 25 10:52
/usr/share/perl5/vendor_perl/Net
drwxr-xr-x 2 root root 0 Apr 25 10:52
/usr/share/perl5/vendor_perl/Net/BGP
-rw-r--r-- 1 root root 5334 Jan 28 2015
/usr/share/perl5/vendor_perl/Net/BGP.pm
drwxr-xr-x 2 root root 0 Apr 25 10:52
/usr/share/perl5/vendor_perl/Net/BGP/ASPath
-rw-r--r-- 1 root root 17098 Jan 28 2015
/usr/share/perl5/vendor_perl/Net/BGP/ASPath.pm
-rw-r--r-- 1 root root 5596 Jan 28 2015
/usr/share/perl5/vendor_perl/Net/BGP/ASPath/AS.pm
-rw-r--r-- 1 root root 581 Jan 28 2015
/usr/share/perl5/vendor_perl/Net/BGP/ASPath/AS_CONFED_SEQUENCE.pm
-rw-r--r-- 1 root root 472 Jan 28 2015
/usr/share/perl5/vendor_perl/Net/BGP/ASPath/AS_CONFED_SET.pm
-rw-r--r-- 1 root root 681 Jan 28 2015
/usr/share/perl5/vendor_perl/Net/BGP/ASPath/AS_SEQUENCE.pm
-rw-r--r-- 1 root root 995 Jan 28 2015
/usr/share/perl5/vendor_perl/Net/BGP/ASPath/AS_SET.pm
-rw-r--r-- 1 root root 13924 Jan 28 2015
/usr/share/perl5/vendor_perl/Net/BGP/NLRI.pm
-rw-r--r-- 1 root root 6842 Jan 28 2015
/usr/share/perl5/vendor_perl/Net/BGP/Notification.pm
-rw-r--r-- 1 root root 30083 Jan 28 2015
/usr/share/perl5/vendor_perl/Net/BGP/Peer.pm
-rw-r--r-- 1 root root 11937 Jan 28 2015
/usr/share/perl5/vendor_perl/Net/BGP/Process.pm
-rw-r--r-- 1 root root 4149 Jan 28 2015
/usr/share/perl5/vendor_perl/Net/BGP/Refresh.pm
-rw-r--r-- 1 root root 43171 Jan 28 2015
/usr/share/perl5/vendor_perl/Net/BGP/Transport.pm
-rw-r--r-- 1 root root 30217 Jan 28 2015
/usr/share/perl5/vendor_perl/Net/BGP/Update.pm
File location and permissions are Ok.
$ rpm -q --requires -p ../RPMS/noarch/perl-Net-BGP-0.16-2.fc31.noarch.rpm |
sort -f | uniq -c
1 perl(:MODULE_COMPAT_5.28.2)
1 perl(bytes)
1 perl(Carp)
1 perl(Errno)
1 perl(Exporter)
1 perl(IO::Select)
1 perl(IO::Socket)
1 perl(Net::BGP::ASPath)
1 perl(Net::BGP::ASPath::AS)
1 perl(Net::BGP::ASPath::AS_CONFED_SEQUENCE)
1 perl(Net::BGP::ASPath::AS_CONFED_SET)
1 perl(Net::BGP::ASPath::AS_SEQUENCE)
1 perl(Net::BGP::ASPath::AS_SET)
1 perl(Net::BGP::NLRI)
1 perl(Net::BGP::Notification)
1 perl(Net::BGP::Peer)
1 perl(Net::BGP::Refresh)
1 perl(Net::BGP::Transport)
1 perl(Net::BGP::Update)
1 perl(overload)
1 perl(Scalar::Util)
1 perl(strict)
1 perl(vars)
1 rpmlib(CompressedFileNames) <= 3.0.4-1
1 rpmlib(FileDigests) <= 4.6.0-1
1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
1 rpmlib(PayloadIsXz) <= 5.2-1
TODO: Add '>= 1.01' contstraint to 'perl(Scalar::Util)' run-time
dependency.
After that you should also filter the unversioned one.
$ rpm -q --provides -p ../RPMS/noarch/perl-Net-BGP-0.16-2.fc31.noarch.rpm |
sort -f | uniq -c
1 perl(Net::BGP) = 0.16
1 perl(Net::BGP::ASPath) = 0.16
1 perl(Net::BGP::ASPath::AS) = 0.16
1 perl(Net::BGP::ASPath::AS_CONFED_SEQUENCE) = 0.16
1 perl(Net::BGP::ASPath::AS_CONFED_SET) = 0.16
1 perl(Net::BGP::ASPath::AS_SEQUENCE) = 0.16
1 perl(Net::BGP::ASPath::AS_SET) = 0.16
1 perl(Net::BGP::NLRI) = 0.16
1 perl(Net::BGP::Notification) = 0.07
1 perl(Net::BGP::Peer) = 0.16
1 perl(Net::BGP::Process) = 0.15
1 perl(Net::BGP::Refresh) = 0.07
1 perl(Net::BGP::Transport) = 0.16
1 perl(Net::BGP::Update) = 0.16
1 perl-Net-BGP = 0.16-2.fc31
Binary provides are Ok.
$ resolvedeps rawhide ../RPMS/noarch/perl-Net-BGP-0.16-2.fc31.noarch.rpm
Binary dependencies are resolvable. Ok.
The package builds in F31
(
https://koji.fedoraproject.org/koji/taskinfo?taskID=34417844). Ok.
Otherwise the package is in line with Fedora and Perl packaging guidelines.
Please consider fixing the 'TODO' items before building this package.
Resolution: Package APPROVED.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component