https://bugzilla.redhat.com/show_bug.cgi?id=1765731

Anna Khaitovich akhaitov@redhat.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(loganjerry@gmail. | |com)

--- Comment #1 from Anna Khaitovich akhaitov@redhat.com --- There are two explicit dependencies specified: gap-pkg-tomlib and gap-pkg-ctbllib. If I understood correctly, those packages are only needed to build gap-pkg-recog, so there is no need to have them both in Requires and BuildRequires. Having them in BuildRequires would be enough.

https://bugzilla.redhat.com/show_bug.cgi?id=1765731

Anna Khaitovich akhaitov@redhat.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags| |fedora-review+

--- Comment #3 from Anna Khaitovich akhaitov@redhat.com --- Package Review ==============

Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed

===== MUST items =====

Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: There is no build directory. Running licensecheck on vanilla upstream sources. No licenses found. Please check the source files for licenses manually. [x]: License file installed when any subpackage combination is installed. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf %{buildroot} present but not required [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 5 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments [x]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM.

Rpmlint ------- Checking: gap-pkg-recog-1.3.2-2.fc32.noarch.rpm gap-pkg-recog-doc-1.3.2-2.fc32.noarch.rpm gap-pkg-recog-1.3.2-2.fc32.src.rpm gap-pkg-recog.noarch: W: only-non-binary-in-usr-lib gap-pkg-recog-doc.noarch: W: only-non-binary-in-usr-lib gap-pkg-recog-doc.noarch: W: no-documentation gap-pkg-recog.src: W: invalid-url Source1: gap-pkg-recog-testdata.tar.xz 3 packages and 0 specfiles checked; 0 errors, 4 warnings.

Rpmlint (installed packages) ---------------------------- perl: warning: Setting locale failed. perl: warning: Please check that your locale settings: LANGUAGE = (unset), LC_ALL = (unset), LC_CTYPE = "C.UTF-8", LANG = "en_US.UTF-8" are supported and installed on your system. perl: warning: Falling back to the standard locale ("C"). perl: warning: Setting locale failed. perl: warning: Please check that your locale settings: LANGUAGE = (unset), LC_ALL = (unset), LC_CTYPE = "C.UTF-8", LANG = "en_US.UTF-8" are supported and installed on your system. perl: warning: Falling back to the standard locale ("C"). gap-pkg-recog-doc.noarch: W: invalid-url URL: https://gap-packages.github.io/recog/ <urlopen error [Errno -2] Name or service not known> gap-pkg-recog-doc.noarch: W: only-non-binary-in-usr-lib gap-pkg-recog-doc.noarch: W: no-documentation gap-pkg-recog.noarch: W: invalid-url URL: https://gap-packages.github.io/recog/ <urlopen error [Errno -2] Name or service not known> gap-pkg-recog.noarch: W: only-non-binary-in-usr-lib 2 packages and 0 specfiles checked; 0 errors, 5 warnings.

Source checksums ---------------- https://github.com/gap-packages/recog/releases/download/v1.3.2/recog-1.3.2.t... : CHECKSUM(SHA256) this package : b22771762564aa80c2a36569eab2a36f4d976dae6598407d36897b8fa554513d CHECKSUM(SHA256) upstream package : b22771762564aa80c2a36569eab2a36f4d976dae6598407d36897b8fa554513d

Requires -------- gap-pkg-recog (rpmlib, GLIBC filtered): gap-pkg-atlasrep gap-pkg-factint gap-pkg-forms gap-pkg-genss

gap-pkg-recog-doc (rpmlib, GLIBC filtered): gap-online-help gap-pkg-recog

Provides -------- gap-pkg-recog: gap-pkg-recog

gap-pkg-recog-doc: gap-pkg-recog-doc

Generated by fedora-review 0.7.3 (44b83c7) last change: 2019-09-18 Command line :/usr/bin/fedora-review -b 1765731 Buildroot used: fedora-rawhide-{{ target_arch }} Active plugins: Shell-api, Generic Disabled plugins: Perl, Haskell, fonts, Python, Java, R, Ocaml, SugarActivity, C/C++, PHP Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH

https://bugzilla.redhat.com/show_bug.cgi?id=1765731

Fedora Update System updates@fedoraproject.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|POST |MODIFIED

--- Comment #5 from Fedora Update System updates@fedoraproject.org --- FEDORA-2019-6b9a7bca41 has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2019-6b9a7bca41

https://bugzilla.redhat.com/show_bug.cgi?id=1765731

Fedora Update System updates@fedoraproject.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed| |2019-12-12 01:54:00

--- Comment #7 from Fedora Update System updates@fedoraproject.org --- gap-pkg-recog-1.3.2-2.fc31 has been pushed to the Fedora 31 stable repository. If problems still persist, please make note of it in this bug report.