Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=684006 Bill Pemberton <wfp5p(a)virginia.edu&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |177841(FE-NEEDSPONSOR) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=684006 --- Comment #2 from Bill Pemberton <wfp5p(a)virginia.edu&gt; 2011-03-21 14:56:00 EDT --- package and spec updated to address the quibbles. I use this rpm locally on EPEL-5, so yes, I'd expect to build it for EPEL-5 repo. Spec URL: http://wfp.fedorapeople.org/perl-XML-Rules.spec SRPM URL: http://wfp.fedorapeople.org/perl-XML-Rules-1.10-2.fc14.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=684006 --- Comment #4 from Bill Pemberton <wfp5p(a)virginia.edu&gt; 2012-02-16 09:53:57 EST --- Here's an update that addresses the comments, minus packaging XML::DTDParser -- I'll package that up shortly. Spec URL: http://wfp.fedorapeople.org/perl-XML-Rules.spec SRPM URL: http://wfp.fedorapeople.org/perl-XML-Rules-1.10-3.fc16.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=684006 --- Comment #6 from Bill Pemberton <wfp5p(a)virginia.edu&gt; 2012-02-16 15:24:06 EST --- Another update to address previous comment. Spec URL: http://wfp.fedorapeople.org/perl-XML-Rules.spec SRPM URL: http://wfp.fedorapeople.org/perl-XML-Rules-1.10-4.fc16.src.rpm I'll make a separate review request for XML::DTDParser -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=684006 Bill Pemberton <wfp5p(a)virginia.edu&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs? --- Comment #7 from Bill Pemberton <wfp5p(a)virginia.edu&gt; 2012-02-22 13:49:14 EST --- New Package SCM Request ======================= Package Name: perl-XML-Rules Short Description: Parse XML and specify what and how to keep/process for individual tags Owners: wfp Branches: f16 f17 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=684006 --- Comment #9 from Paul Howarth <paul(a)city-fan.org&gt; 2012-02-22 15:36:39 EST --- Hopefully I'll have time to look at this tomorrow. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=684006 --- Comment #11 from Paul Howarth <paul(a)city-fan.org&gt; 2012-02-22 16:44:38 EST --- Please fix the line endings in %prep rather than %build. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=684006 Paul Howarth <paul(a)city-fan.org&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|177841(FE-NEEDSPONSOR) | Flag|fedora-review? |fedora-review+ --- Comment #13 from Paul Howarth <paul(a)city-fan.org&gt; 2012-02-23 11:10:33 EST --- perl-XML-Rules review ===================== rpmlint output: perl-XML-Rules.noarch: E: incorrect-fsf-address /usr/share/doc/perl-XML-Rules-1.10/LICENSE perl-XML-Rules.noarch: W: file-not-utf8 /usr/share/doc/perl-XML-Rules-1.10/example/testUTF.txt perl-XML-Rules.noarch: W: file-not-utf8 /usr/share/doc/perl-XML-Rules-1.10/example/testUTF.pl perl-XML-Rules.noarch: W: file-not-utf8 /usr/share/doc/perl-XML-Rules-1.10/example/test19.txt perl-XML-Rules.noarch: W: file-not-utf8 /usr/share/doc/perl-XML-Rules-1.10/example/test18.xml perl-XML-Rules.noarch: W: no-manual-page-for-binary xml2XMLRules.pl perl-XML-Rules.noarch: W: no-manual-page-for-binary dtd2XMLRules.pl You should contact upstream and suggest they update the GPL license text in any future release to fix the address (they can download this text from http://www.gnu.org/licenses/old-licenses/gpl-1.0.txt). The non-UTF8 files are explicitly using other encodings, so that can be ignored. This is quite common with XML-handling packages. The scripts without manpages are small and self-explanatory so I don't think there's anything to worry about there. - package and spec naming OK - package meets guidelines - license matches upstream and is OK for Fedora - upstream LICENSE file included in package - spec written in English and is legible - source tarball content matches upstream - package builds and runs OK on Fedora - buildreqs comprehensive and appropriate - no locale data or libraries to worry about - package is not intended to be relocatable - file and directory ownership OK - no duplicate files - file and directory permissions sane - macro usage inconsistent - see below - code, not content - no large documentation - docs don't affect runtime - no devel-type content to worry about - not a GUI app so no desktop file needed - filenames all plain ASCII - no scriptlets or subpackages to worry about Suggestions: My preference for handling addition/removal of shellbangs (or re-coding of documentation to UTF-8) is to use a patch rather than running sed (or iconv) in %prep. The reason for this is that future updates from upstream may include the shellbangs or have been recoded to UTF8 there, and if you don't notice that, you can end up with two shellbangs (ugly but harmless), or mangled documentation in the iconv case. Not a blocker though. The timestamp of the source tarball is more recent than the upstream tarball, though the content is the same. It would be neater to re-download it prior to putting in the Fedora lookaside cache so that the timestamp would match. You've used both "sed" and "%{__sed}" in the spec, which is inconsistent. You should just use "sed" - see http://fedoraproject.org/wiki/Packaging:Guidelines#Macros You can fix that in git before building the package. APPROVED, assuming you're going to fix the macro usage. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=684006 --- Comment #15 from Jon Ciesla <limburgher(a)gmail.com&gt; 2012-02-23 13:03:56 EST --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=684006 --- Comment #17 from Bill Pemberton <wfp5p(a)virginia.edu&gt; 2012-03-19 08:38:55 EDT --- No problems, just me being new to the process and missing those steps. I'll get on it now. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=684006 --- Comment #18 from Fedora Update System <updates(a)fedoraproject.org&gt; 2012-03-19 08:47:03 EDT --- perl-XML-Rules-1.10-7.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/perl-XML-Rules-1.10-7.fc16 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=684006 Fedora Update System <updates(a)fedoraproject.org&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA --- Comment #20 from Fedora Update System <updates(a)fedoraproject.org&gt; 2012-03-20 02:05:22 EDT --- perl-XML-Rules-1.10-7.fc17 has been pushed to the Fedora 17 testing repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=684006 Fedora Update System <updates(a)fedoraproject.org&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|perl-XML-Rules-1.10-7.fc16 |perl-XML-Rules-1.10-7.fc17 --- Comment #22 from Fedora Update System <updates(a)fedoraproject.org&gt; 2012-04-11 23:13:00 EDT --- perl-XML-Rules-1.10-7.fc17 has been pushed to the Fedora 17 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.