11:50 a.m.
https://bugzilla.redhat.com/show_bug.cgi?id=1689552
Bug ID: 1689552
Summary: Review Request: gnatcoll-bindings - The GNAT
Components Collection – bindings
Product: Fedora
Version: rawhide
Hardware: All
OS: Linux
Status: NEW
Component: Package Review
Severity: medium
Priority: medium
Assignee: nobody(a)fedoraproject.org
Reporter: bjorn(a)xn--rombobjrn-67a.se
QA Contact: extras-qa(a)fedoraproject.org
CC: package-review(a)lists.fedoraproject.org
Target Milestone: ---
Classification: Fedora
Spec URL:
https://www.rombobjörn.se/packages/gnatcoll-bindings-2018-1/gnatcoll-bind...
SRPM URL:
https://www.rombobjörn.se/packages/gnatcoll-bindings-2018-1/gnatcoll-bind...
This is the second of three packages to replace the current gnatcoll package –
the bindings module. It provides bindings to GMP, Iconv, Readline and Syslog.
Some details may need to change depending on how we decide to package the core
module. Currently this package assumes that the current gnatcoll package will
become the source package for gnatcoll-core.
Fedora Account System Username: rombobeorn
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
11:52 a.m.
New subject: [Bug 1689552] Review Request: gnatcoll-bindings - The GNAT Components Collection – bindings
https://bugzilla.redhat.com/show_bug.cgi?id=1689552
Björn Persson <bjorn(a)xn--rombobjrn-67a.se> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |pzhukov(a)redhat.com
Depends On| |1685226
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1685226
[Bug 1685226] Review Request: gnatcoll-core - The GNAT Components Collection –
core packages
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
4:13 a.m.
New subject: [Bug 1689552] Review Request: gnatcoll-bindings - The GNAT Components Collection – bindings
https://bugzilla.redhat.com/show_bug.cgi?id=1689552
Pavel Zhukov <pzhukov(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
Assignee|nobody(a)fedoraproject.org |pzhukov(a)redhat.com
--- Comment #1 from Pavel Zhukov <pzhukov(a)redhat.com> ---
I'll review it
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
4:13 a.m.
New subject: [Bug 1689552] Review Request: gnatcoll-bindings - The GNAT Components Collection – bindings
https://bugzilla.redhat.com/show_bug.cgi?id=1689552
Pavel Zhukov <pzhukov(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags| |fedora-review?
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
5:50 a.m.
New subject: [Bug 1689552] Review Request: gnatcoll-bindings - The GNAT Components Collection – bindings
https://bugzilla.redhat.com/show_bug.cgi?id=1689552
Bug 1689552 depends on bug 1685226, which changed state.
Bug 1685226 Summary: Review Request: gnatcoll-core - The GNAT Components Collection – core
packages
https://bugzilla.redhat.com/show_bug.cgi?id=1685226
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |CLOSED
Resolution|--- |NOTABUG
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
6:09 a.m.
New subject: [Bug 1689552] Review Request: gnatcoll-bindings - The GNAT Components Collection – bindings
https://bugzilla.redhat.com/show_bug.cgi?id=1689552
--- Comment #2 from Björn Persson <bjorn(a)xn--rombobjrn-67a.se> ---
It builds: https://koji.fedoraproject.org/koji/taskinfo?taskID=33629810
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
3:03 p.m.
New subject: [Bug 1689552] Review Request: gnatcoll-bindings - The GNAT Components Collection – bindings
https://bugzilla.redhat.com/show_bug.cgi?id=1689552
Björn Persson <bjorn(a)xn--rombobjrn-67a.se> changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |1692166
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1692166
[Bug 1692166] Review Request: gnatcoll-db - The GNAT Components Collection –
database packages
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
7:15 a.m.
New subject: [Bug 1689552] Review Request: gnatcoll-bindings - The GNAT Components Collection – bindings
https://bugzilla.redhat.com/show_bug.cgi?id=1689552
--- Comment #3 from Pavel Zhukov <pzhukov(a)redhat.com> ---
Few remarks:
BuildRequires: gnatcoll-core-devel = 2018 <== Can be changed %{version} for
better maintainability same for %autosetup -n gnatcoll-bindings-gpl-2018-src
COPYING and README are duplicated 4 and 3 times in subpackages. Isn't it
better to ship them in main package or different subpackage (like -common
-license whatever) which all subpackages must depend on?
P.S. Huge sed expression makes me scared :) but it's kind of ok for
autogenerated files.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
1:45 p.m.
New subject: [Bug 1689552] Review Request: gnatcoll-bindings - The GNAT Components Collection – bindings
https://bugzilla.redhat.com/show_bug.cgi?id=1689552
--- Comment #4 from Björn Persson <bjorn(a)xn--rombobjrn-67a.se> ---
(In reply to Pavel Zhukov from comment #3)
BuildRequires: gnatcoll-core-devel = 2018 <== Can be changed
%{version} for
better maintainability same for %autosetup -n gnatcoll-bindings-gpl-2018-src
OK – and maybe I should also add a comment on why I require an exact version.
COPYING and README are duplicated 4 and 3 times in subpackages.
Isn't it
better to ship them in main package or different subpackage (like -common
-license whatever) which all subpackages must depend on?
The readme files aren't duplicated. They are different, and are all in the
-devel subpackage as only developers might have a use for them.
That leaves the license. I'm rather sceptical to making a separate subpackage
just for the license file. Do you really think that's worthwhile? Note that
there is no duplication once the packages are installed. There is just one
file, /usr/share/licenses/gnatcoll-bindings/COPYING3, with shared ownership.
P.S. Huge sed expression makes me scared :) but it's kind of ok
for
autogenerated files.
The Sed syntax is admittedly hard to read. Very unlike Ada. :-) I have added an
explanation.
I also noticed that the directory /usr/share/doc/gnatcoll was unowned if
gnatcoll-bindings-devel was installed but gnatcoll-doc was not. That is now
fixed.
https://www.rombobjörn.se/packages/gnatcoll-bindings-2018-2/gnatcoll-bind...
https://www.rombobjörn.se/packages/gnatcoll-bindings-2018-2/gnatcoll-bind...
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
2:57 a.m.
New subject: [Bug 1689552] Review Request: gnatcoll-bindings - The GNAT Components Collection – bindings
https://bugzilla.redhat.com/show_bug.cgi?id=1689552
Pavel Zhukov <pzhukov(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags|fedora-review? |fedora-review+
--- Comment #5 from Pavel Zhukov <pzhukov(a)redhat.com> ---
Looks good now.
rpmlint reports no error but few warning. no important ones:
gnatcoll-readline.x86_64: W: executable-stack
/usr/lib64/libgnatcoll_readline.so.2018
gnatcoll-bindings-devel.x86_64: W: no-dependency-on
gnatcoll-bindings/gnatcoll-bindings-libs/libgnatcoll-bindings
gnatcoll-gmp.x86_64: I: enchant-dictionary-not-found sv
gnatcoll-gmp.x86_64: W: no-documentation
APPROVED.
Thank you Bjorn.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
8:16 a.m.
New subject: [Bug 1689552] Review Request: gnatcoll-bindings - The GNAT Components Collection – bindings
https://bugzilla.redhat.com/show_bug.cgi?id=1689552
--- Comment #6 from Gwyn Ciesla <gwync(a)protonmail.com> ---
(fedscm-admin): The Pagure repository was created at
https://src.fedoraproject.org/rpms/gnatcoll-bindings
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
9:50 a.m.
New subject: [Bug 1689552] Review Request: gnatcoll-bindings - The GNAT Components Collection – bindings
https://bugzilla.redhat.com/show_bug.cgi?id=1689552
Björn Persson <bjorn(a)xn--rombobjrn-67a.se> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |CLOSED
Resolution|--- |NEXTRELEASE
Last Closed| |2019-04-08 14:50:19
--- Comment #7 from Björn Persson <bjorn(a)xn--rombobjrn-67a.se> ---
Thanks for the review. I've built the package for Rawhide. I'll build for F30
when the gnatcoll-db review is done.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
11:19 a.m.
New subject: [Bug 1689552] Review Request: gnatcoll-bindings - The GNAT Components Collection – bindings
https://bugzilla.redhat.com/show_bug.cgi?id=1689552
--- Comment #8 from Fedora Update System <updates(a)fedoraproject.org> ---
FEDORA-2019-cfeb86a4bf has been submitted as an update to Fedora 30.
https://bodhi.fedoraproject.org/updates/FEDORA-2019-cfeb86a4bf
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
8:58 a.m.
New subject: [Bug 1689552] Review Request: gnatcoll-bindings - The GNAT Components Collection – bindings
https://bugzilla.redhat.com/show_bug.cgi?id=1689552
--- Comment #9 from Fedora Update System <updates(a)fedoraproject.org> ---
gnatcoll-2018-2.fc30, gnatcoll-bindings-2018-3.fc30, gnatcoll-db-2018-3.fc30
has been pushed to the Fedora 30 testing repository. If problems still persist,
please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2019-cfeb86a4bf
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
9:41 p.m.
New subject: [Bug 1689552] Review Request: gnatcoll-bindings - The GNAT Components Collection – bindings
https://bugzilla.redhat.com/show_bug.cgi?id=1689552
--- Comment #10 from Fedora Update System <updates(a)fedoraproject.org> ---
gnatcoll-2018-2.fc30, gnatcoll-bindings-2018-3.fc30, gnatcoll-db-2018-3.fc30
has been pushed to the Fedora 30 stable repository. If problems still persist,
please make note of it in this bug report.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
1774
days inactive
1861
days old
package-review@lists.fedoraproject.org
14 comments
1 participants
participants (1)
-
bugzilla＠redhat.com