Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: gnome-libs
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=198245
------- Additional Comments From paul(a)city-fan.org 2006-09-13 14:18 EST -------
(In reply to comment #3)
Issues:
1. You include COPYING as a %doc, but this package is released under
the LGPL. Should change that to the COPYING.LIB file instead.
Actually the libraries are LGPL but the support tools are GPL, so I've added
COPYING.LIB rather than replace COPYING.
2. Are there any upstream/full links for the other source files?
Source2: gnome-libs-pofiles.tar.gz
Source3: db.1.85.tar.gz
Source4: utf8-ta.po
I've added a full URL for db.1.85.tar.gz; the others appear only to exist in Red
Hat/Fedora CVS (probably created by the Red Hat maintainer at some point during
the package's long spell in Core), though I've added some comments about where
to find them.
3. I assume that this package won't work with db4, and needs the
old db-1.85 thats included?
Gnome specifically uses db version 1.85 so that there's a consistent database
format across different platforms/distribution releases etc. So yes, db 1.85 is
needed.
4. Is this needed, since extras doesn't ship on ia64?
## from db1
%ifnarch ia64
Conflicts: glibc-devel < 2.1.90
%endif
Well, it doesn't stop us adding sparc support where needed, so I don't think
there's any harm in supporting ia64. However, since this is a package for FC6
onwards and the conflict is with a rather ancient glibc version, I removed it
anyway.
5. rpmlint has (on fc6/i386):
W: gnome-libs conffile-without-noreplace-flag /etc/gnome/gtkrc
W: gnome-libs conffile-without-noreplace-flag /etc/gnome/gtkrc.el
W: gnome-libs conffile-without-noreplace-flag /etc/gnome/gtkrc.eo
W: gnome-libs conffile-without-noreplace-flag /etc/gnome/gtkrc.he
W: gnome-libs conffile-without-noreplace-flag /etc/gnome/gtkrc.hy
W: gnome-libs conffile-without-noreplace-flag /etc/gnome/gtkrc.iso88592
W: gnome-libs conffile-without-noreplace-flag /etc/gnome/gtkrc.iso88595
W: gnome-libs conffile-without-noreplace-flag /etc/gnome/gtkrc.ja
W: gnome-libs conffile-without-noreplace-flag /etc/gnome/
gtkrc.ka_GE.georgianacademy
W: gnome-libs conffile-without-noreplace-flag /etc/gnome/gtkrc.ka_GE.georgianps
W: gnome-libs conffile-without-noreplace-flag /etc/gnome/gtkrc.ko
W: gnome-libs conffile-without-noreplace-flag /etc/gnome/gtkrc.ru
W: gnome-libs conffile-without-noreplace-flag /etc/gnome/gtkrc.th
W: gnome-libs conffile-without-noreplace-flag /etc/gnome/gtkrc.tr
W: gnome-libs conffile-without-noreplace-flag /etc/gnome/gtkrc.uk
W: gnome-libs conffile-without-noreplace-flag /etc/gnome/gtkrc.vi_VN.tcvn
W: gnome-libs conffile-without-noreplace-flag /etc/gnome/gtkrc.vi_VN.viscii
W: gnome-libs conffile-without-noreplace-flag /etc/gnome/gtkrc.zh_CN
W: gnome-libs conffile-without-noreplace-flag /etc/gnome/gtkrc.zh_TW.Big5
W: gnome-libs conffile-without-noreplace-flag /etc/mime-magic
W: gnome-libs conffile-without-noreplace-flag /etc/mime-magic.dat
W: gnome-libs conffile-without-noreplace-flag /etc/paper.config
W: gnome-libs conffile-without-noreplace-flag /etc/sound/events/gnome.soundlist
W: gnome-libs conffile-without-noreplace-flag /etc/sound/events/gtk-
events.soundlist
Perhaps these should all be (noreplace)?
Debatable. gnome-libs has historically always been packaged without the
noreplace for these files. I'll change it if you insist though.
E: gnome-libs non-standard-gid /usr/sbin/gnome-pty-helper utmp
E: gnome-libs setgid-binary /usr/sbin/gnome-pty-helper utmp 02755
E: gnome-libs non-standard-executable-perm /usr/sbin/gnome-pty-helper 02755
E: gnome-libs-devel only-non-binary-in-usr-lib
W: gnome-libs-devel no-documentation
Can be ignored I think.
Agreed.
on (fc6/x86_64):
E: gnome-libs binary-or-shlib-defines-rpath /usr/bin/gconfigger ['/usr/lib64']
E: gnome-libs binary-or-shlib-defines-rpath /usr/bin/gnome-dump-metadata ['/usr/
lib64']
E: gnome-libs binary-or-shlib-defines-rpath /usr/bin/gnome-name-service ['/usr/
lib64']
E: gnome-libs binary-or-shlib-defines-rpath /usr/bin/loadshlib ['/usr/lib64']
E: gnome-libs binary-or-shlib-defines-rpath /usr/bin/gnome_segv ['/usr/lib64']
E: gnome-libs binary-or-shlib-defines-rpath /usr/bin/gnome-gen-mimedb ['/usr/
lib64']
E: gnome-libs binary-or-shlib-defines-rpath /usr/bin/gnome-moz-remote ['/usr/
lib64']
E: gnome-libs binary-or-shlib-defines-rpath /usr/bin/goad-browser ['/usr/lib64']
Is there some way to remove the rpath?
I used the FC6 libtool instead of the bundled one and that seems to have fixed it.
Update packages:
Spec URL:
http://www.city-fan.org/~paul/extras/Gnome-1/gnome-libs.spec
SRPM URL:
http://www.city-fan.org/~paul/extras/Gnome-1/gnome-libs-1.4.2-3.src.rpm
--
Configure bugmail:
https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.