Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226361
Summary: Merge Review: readline Product: Fedora Extras Version: devel Platform: All OS/Version: Linux Status: NEW Severity: normal Priority: normal Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: nobody@fedoraproject.org QAContact: fedora-package-review@redhat.com CC: mlichvar@redhat.com
Fedora Merge Review: readline
http://cvs.fedora.redhat.com/viewcvs/devel/readline/ Initial Owner: mlichvar@redhat.com
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: readline
https://bugzilla.redhat.com/show_bug.cgi?id=226361
bugzilla@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |medium Priority|normal |medium Product|Fedora Extras |Fedora
panemade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@fedoraproject.org |panemade@gmail.com Status|NEW |ASSIGNED Flag| |fedora-review?
------- Additional Comments From panemade@gmail.com 2007-08-31 07:28 EST ------- like to review this
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: readline
https://bugzilla.redhat.com/show_bug.cgi?id=226361
------- Additional Comments From panemade@gmail.com 2007-10-18 23:42 EST ------- 1)rpmlint complained on RPM readline-devel.i386: W: file-not-utf8 /usr/share/doc/readline-devel-5.2/rl-fgets.c The character encoding of this file is not UTF-8. Consider converting it in the specfile for example using iconv(1).
2) defattr usage should be defattr(-,root,root,-)
3) Good to follow Texinfo scriptlet given at http://fedoraproject.org/wiki/Packaging/ScriptletSnippets#head-47896da5fb266...
4) Do we need static package here?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: readline
https://bugzilla.redhat.com/show_bug.cgi?id=226361
------- Additional Comments From mlichvar@redhat.com 2007-11-05 13:34 EST ------- (In reply to comment #2)
1)rpmlint complained on RPM readline-devel.i386: W: file-not-utf8 /usr/share/doc/readline-devel-5.2/rl-fgets.c The character encoding of this file is not UTF-8. Consider converting it in the specfile for example using iconv(1).
Ok.
- defattr usage should be defattr(-,root,root,-)
Ok. Fixed with 1) in readline-5.2-8.fc9.
- Good to follow Texinfo scriptlet given at
http://fedoraproject.org/wiki/Packaging/ScriptletSnippets#head-47896da5fb266...
With more commands in the script it's IMHO nicer to put : at the end of the script. It's mentioned in the ScriptletSnippets page.
- Do we need static package here?
lvm2 buildrequires readline-static.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: readline
https://bugzilla.redhat.com/show_bug.cgi?id=226361
panemade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
------- Additional Comments From panemade@gmail.com 2007-11-12 06:57 EST ------- Review: + package builds in mock (development i386). + rpmlint is silent for SRPM and for RPM. + source files match upstream. e39331f32ad14009b9ff49cc10c5e751 readline-5.2.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc files present. + BuildRequires are proper. + Compiler flags are honoured correctly. + defattr usage is correct. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code. - static libraries are present. + no .pc file present. + -devel,-static subpackages exists. + no .la files. + no translations are available. + Does owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. + no scriptlets are used. + package readline-5.2-8.fc8 -> Provides: libhistory.so.5 libreadline.so.5 Requires: libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1.3) libc.so.6(GLIBC_2.3) libc.so.6(GLIBC_2.3.4) libc.so.6(GLIBC_2.4) libhistory.so.5 libreadline.so.5 libtinfo.so.5 rtld(GNU_HASH) + package readline-5.2-8.fc8 -> Requires: libhistory.so.5 libreadline.so.5 ncurses-devel readline = 5.2-8.fc8 + package readline-static-5.2-8.fc8 -> Requires: readline-devel = 5.2-8.fc8 + Not a GUI app.
APPROVED.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: readline
https://bugzilla.redhat.com/show_bug.cgi?id=226361
------- Additional Comments From panemade@gmail.com 2007-11-12 07:19 EST ------- oops ldconfig and install-info scriptlets are used.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Merge Review: readline
https://bugzilla.redhat.com/show_bug.cgi?id=226361
panemade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |RAWHIDE
package-review@lists.fedoraproject.org