[Bug 543337] New: Review Request: rubygem-rcov - Code coverage analysis tool for Ruby - package-review

List overview All Threads
Download

newer

[Bug 543337] New: Review Request: rubygem-rcov - Code coverage analysis tool for Ruby

older

[Bug 574977] New: Review Request:...

[Bug 541807] New: Review Request:...

Red Hat Bugzilla

2 Dec 2009 2 Dec '09

7:19 a.m.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

Summary: Review Request: rubygem-rcov - Code coverage analysis tool for Ruby

https://bugzilla.redhat.com/show_bug.cgi?id=543337

Summary: Review Request: rubygem-rcov - Code coverage analysis tool for Ruby Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: mkent@magoazul.com QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora

Spec URL: http://magoazul.com/wip/SPECS/rubygem-rcov.spec SRPM URL: http://magoazul.com/wip/SRPMS/rubygem-rcov-0.9.6-1.fc13.src.rpm Description: rcov is a code coverage tool for Ruby. It is commonly used for viewing overall test unit coverage of target code. It features fast execution (20-300 times faster than previous tools), multiple analysis modes, XHTML and several kinds of text reports, easy automation with Rake via a RcovTask, fairly accurate coverage information through code linkage inference using simple heuristics, colorblind-friendliness...

Background: This package has a bit of a history due to to the project being active -> idle -> forked -> forked to it's current state where the 'rcov' gem is maintained by Relevance. rubyforge/gemcutter considers them the definitive source for it, so I think it's safe to package.

There was a previous review for rcov here https://bugzilla.redhat.com/show_bug.cgi?id=466331 but this version is far newer and well maintained.

mkent@fedora-devel-chef:~/rpmbuild/SPECS$ rpmlint rubygem-rcov.spec /var/tmp/results/rubygem-rcov-* rubygem-rcov.x86_64: W: devel-file-in-non-devel-package /usr/lib/ruby/gems/1.8/gems/rcov-0.9.6/ext/rcovrt/1.8/rcovrt.c rubygem-rcov.x86_64: W: devel-file-in-non-devel-package /usr/lib/ruby/gems/1.8/gems/rcov-0.9.6/ext/rcovrt/1.8/callsite.c rubygem-rcov.x86_64: W: devel-file-in-non-devel-package /usr/lib/ruby/gems/1.8/gems/rcov-0.9.6/ext/rcovrt/1.9/callsite.c rubygem-rcov.x86_64: W: devel-file-in-non-devel-package /usr/lib/ruby/gems/1.8/gems/rcov-0.9.6/ext/rcovrt/1.9/rcovrt.c rubygem-rcov-doc.x86_64: W: no-documentation rubygem-rcov-doc.x86_64: W: misspelled-macro /usr/lib/ruby/gems/1.8/doc/rcov-0.9.6/ri/Rcov/RcovTask/test_files%3d-i.yaml %3d rubygem-rcov-doc.x86_64: W: misspelled-macro /usr/lib/ruby/gems/1.8/doc/rcov-0.9.6/ri/CoverageInfo/%5b%5d-i.yaml %5b rubygem-rcov-doc.x86_64: W: misspelled-macro /usr/lib/ruby/gems/1.8/doc/rcov-0.9.6/ri/Rcov/FileStatistics/is_code%3f-i.yaml %3f 4 packages and 1 specfiles checked; 0 errors, 8 warnings.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Show replies by date

Red Hat Bugzilla

2 Dec 2 Dec

4:17 p.m.

New subject: [Bug 543337] Review Request: rubygem-rcov - Code coverage analysis tool for Ruby

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=543337

Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp changed:

--- Comment #1 from Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp 2009-12-02 11:17:48 EDT --- Some notes:

? Requires - Would you explain the necessity of "R: rubygem(rake)"? ( Maybe for lib/rcov/rcovtask.rb ? If so, I wonder if this script is used by default or not because no other scripts in rcov gem seems to require this script )

! Note that I am not objecting to adding "R: rubygem(rake)".

* ext/ - Files under ext/ are to generate C extension module (rcovrt.so) and should not be needed to be included into binary rpm.

( The trouble is that once we try to execute "rake check" under %geminstdir, rake task tries to regenerate .so file.

In such cases files under ext/ are needed, however anyway this won't work but for root because write permission for %geminstdir is needed. So while you may want to add files under ext to -doc subpackage, these files should not be in main package. )

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

4 Dec 4 Dec

5:48 a.m.

New subject: [Bug 543337] Review Request: rubygem-rcov - Code coverage analysis tool for Ruby

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=543337

--- Comment #2 from Matthew Kent mkent@magoazul.com 2009-12-04 00:48:02 EDT --- Thank you for the review

(In reply to comment #1)

...

Some notes:

? Requires

Would you explain the necessity of "R: rubygem(rake)"? ( Maybe for lib/rcov/rcovtask.rb ? If so, I wonder if this script is used by default or not because no other scripts in rcov gem seems to require this script )

! Note that I am not objecting to adding "R: rubygem(rake)".

That's correct, I added that in an attempt to cover what I thought was a missing dependency. Upon a further examination lib/rcov/rcovtask.rb provides tasks *to* rake rather than depending *on* rake. I'll remove that.

...

ext/

Files under ext/ are to generate C extension module (rcovrt.so) and should not be needed to be included into binary rpm.

( The trouble is that once we try to execute "rake check" under %geminstdir, rake task tries to regenerate .so file.

In such cases files under ext/ are needed, however anyway this won't work but for root because write permission for %geminstdir is needed. So while you may want to add files under ext to -doc subpackage, these files should not be in main package. )

Good catch, thanks.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

5:56 a.m.

New subject: [Bug 543337] Review Request: rubygem-rcov - Code coverage analysis tool for Ruby

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=543337

--- Comment #3 from Matthew Kent mkent@magoazul.com 2009-12-04 00:56:20 EDT --- Spec URL: http://magoazul.com/wip/SPECS/rubygem-rcov.spec SRPM URL: http://magoazul.com/wip/SRPMS/rubygem-rcov-0.9.6-2.fc13.src.rpm

* Thu Dec 03 2009 Matthew Kent mkent@magoazul.com - 0.9.6-2 - Remove Requires for rubygem(rake) (#543337). - Move ext to -doc (#543337).

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

4:10 p.m.

New subject: [Bug 543337] Review Request: rubygem-rcov - Code coverage analysis tool for Ruby

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=543337

Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp changed:

What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+

--- Comment #4 from Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp 2009-12-04 11:10:09 EDT --- Okay.

------------------------------------------------------------ This package (rubygem-rcov) is APPROVED by mtasaka ------------------------------------------------------------

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

5:08 p.m.

New subject: [Bug 543337] Review Request: rubygem-rcov - Code coverage analysis tool for Ruby

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=543337

Matthew Kent mkent@magoazul.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?

--- Comment #5 from Matthew Kent mkent@magoazul.com 2009-12-04 12:08:24 EDT --- New Package CVS Request ======================= Package Name: rubygem-rcov Short Description: Code coverage analysis tool for Ruby Owners: mkent Branches: F-11 F-12 InitialCC:

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

6 Dec 6 Dec

11:25 p.m.

New subject: [Bug 543337] Review Request: rubygem-rcov - Code coverage analysis tool for Ruby

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=543337

Kevin Fenzi kevin@tummy.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+

--- Comment #6 from Kevin Fenzi kevin@tummy.com 2009-12-06 18:25:18 EDT --- cvs done.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

7 Dec 7 Dec

5:52 a.m.

New subject: [Bug 543337] Review Request: rubygem-rcov - Code coverage analysis tool for Ruby

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=543337

--- Comment #7 from Fedora Update System updates@fedoraproject.org 2009-12-07 00:52:57 EDT --- rubygem-rcov-0.9.6-2.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/rubygem-rcov-0.9.6-2.fc11

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

5:53 a.m.

New subject: [Bug 543337] Review Request: rubygem-rcov - Code coverage analysis tool for Ruby

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=543337

--- Comment #8 from Fedora Update System updates@fedoraproject.org 2009-12-07 00:53:55 EDT --- rubygem-rcov-0.9.6-2.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/rubygem-rcov-0.9.6-2.fc12

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

2:39 p.m.

New subject: [Bug 543337] Review Request: rubygem-rcov - Code coverage analysis tool for Ruby

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=543337

Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp changed:

--- Comment #9 from Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp 2009-12-07 09:39:39 EDT --- Closing.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

8 Dec 8 Dec

7:45 a.m.

New subject: [Bug 543337] Review Request: rubygem-rcov - Code coverage analysis tool for Ruby

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=543337

--- Comment #10 from Fedora Update System updates@fedoraproject.org 2009-12-08 02:45:03 EDT --- rubygem-rcov-0.9.6-2.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

7:45 a.m.

New subject: [Bug 543337] Review Request: rubygem-rcov - Code coverage analysis tool for Ruby

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=543337

Fedora Update System updates@fedoraproject.org changed:

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

7:46 a.m.

New subject: [Bug 543337] Review Request: rubygem-rcov - Code coverage analysis tool for Ruby

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=543337

--- Comment #11 from Fedora Update System updates@fedoraproject.org 2009-12-08 02:46:15 EDT --- rubygem-rcov-0.9.6-2.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

7:46 a.m.

New subject: [Bug 543337] Review Request: rubygem-rcov - Code coverage analysis tool for Ruby

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=543337

Fedora Update System updates@fedoraproject.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|0.9.6-2.fc12 |0.9.6-2.fc11

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

10 Sep 10 Sep

6:34 p.m.

New subject: [Bug 543337] Review Request: rubygem-rcov - Code coverage analysis tool for Ruby

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=543337

Michael Stahnke mastahnke@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |mastahnke@gmail.com

--- Comment #12 from Michael Stahnke mastahnke@gmail.com 2010-09-10 14:34:46 EDT --- Package Change Request ====================== Package Name: rubygem-rcov New Branches: el5 el6 Owners: stahnma

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

6:35 p.m.

New subject: [Bug 543337] Review Request: rubygem-rcov - Code coverage analysis tool for Ruby

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=543337

Michael Stahnke mastahnke@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs+ |fedora-cvs?

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

6:40 p.m.

New subject: [Bug 543337] Review Request: rubygem-rcov - Code coverage analysis tool for Ruby

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=543337

--- Comment #13 from Kevin Fenzi kevin@tummy.com 2010-09-10 14:40:49 EDT --- Git done (by process-git-requests).

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

5043

Age (days ago)

5325

Last active (days ago)

package-review@lists.fedoraproject.org

16 comments

1 participants

tags (0)

participants (1)

Red Hat Bugzilla