[Bug 1242886] New: Review Request: openstack-ironic-inspector - Hardware introspection service for OpenStack Ironic
5:47 a.m.
https://bugzilla.redhat.com/show_bug.cgi?id=1242886
Bug ID: 1242886
Summary: Review Request: openstack-ironic-inspector - Hardware
introspection service for OpenStack Ironic
Product: Fedora
Version: rawhide
Component: Package Review
Severity: medium
Priority: medium
Assignee: nobody(a)fedoraproject.org
Reporter: dtantsur(a)redhat.com
QA Contact: extras-qa(a)fedoraproject.org
CC: package-review(a)lists.fedoraproject.org
Spec URL:
https://dl.dropboxusercontent.com/u/1730743/RPM/openstack-ironic-inspecto...
SRPM URL:
https://dl.dropboxusercontent.com/u/1730743/RPM/openstack-ironic-inspecto...
Description: Hardware introspection service for OpenStack Ironic
This is essentially openstack-ironic-discoverd package renamed upstream (in
backward incompatible way).
Fedora Account System Username: divius
Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=10351884
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
12:06 p.m.
New subject: [Bug 1242886] Review Request: openstack-ironic-inspector - Hardware introspection service for OpenStack Ironic
https://bugzilla.redhat.com/show_bug.cgi?id=1242886
Dmitry Tantsur <dtantsur(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |1243533
| |(RDO-LIBERTY-REVIEWS)
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1243533
[Bug 1243533] (RDO) Tracker: Review requests for new RDO Liberty packages
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
4:05 p.m.
New subject: [Bug 1242886] Review Request: openstack-ironic-inspector - Hardware introspection service for OpenStack Ironic
https://bugzilla.redhat.com/show_bug.cgi?id=1242886
bigswitch <rhosp-bugs-internal(a)bigswitch.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |rhosp-bugs-internal@bigswit
| |ch.com
--- Comment #1 from bigswitch <rhosp-bugs-internal(a)bigswitch.com> ---
Hi Dmitry,
I see there's 'oslo.log' as requires on pypi, but its missing in the requires
section in the spec file. Is that intentional (some other oslo package includes
it)? Otherwise it should be added.
Everything else looks good.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
6:30 a.m.
New subject: [Bug 1242886] Review Request: openstack-ironic-inspector - Hardware introspection service for OpenStack Ironic
https://bugzilla.redhat.com/show_bug.cgi?id=1242886
Chandan Kumar <chkumar246(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
CC| |chkumar246(a)gmail.com
Assignee|nobody(a)fedoraproject.org |chkumar246(a)gmail.com
Flags| |fedora-review?
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
11:52 p.m.
New subject: [Bug 1242886] Review Request: openstack-ironic-inspector - Hardware introspection service for OpenStack Ironic
https://bugzilla.redhat.com/show_bug.cgi?id=1242886
Chandan Kumar <chkumar(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |chkumar(a)redhat.com,
| |dtantsur(a)redhat.com
Flags| |needinfo?(dtantsur(a)redhat.c
| |om)
--- Comment #2 from Chandan Kumar <chkumar(a)redhat.com> ---
Hello Dmitry,
Thanks for submitting for Package Review,
Below is my inline comments.
[1.] Since new version of openstack-ironic-inspector i.e. 2.1.0 is available,
Please update the spec file with latest version.
[2.] "Group: System Environment/Base" is not required,
Since this tag is optional, Please remove it,
https://fedoraproject.org/wiki/Packaging:Guidelines#Group_tag
[3.] Please check the requires with requirements.txt and please update it
[4.] Under prep section,
Please rm -rf {test-,}requirements.txt update this to rm -rf {plugin-,
test-,}requirements.txt
[5.] under %files -n python-ironic-inspector section,
please update %{python_sitelib}/ironic_inspector* to
%{python2_sitelib}/ironic_inspector*
and also include %{python2_sitelib}/ironic_inspector-%{version}-py?.?.egg-info
[6.] Please run rpmlint on srpm, rpms and spec file and make a scratch koji
build.
Thanks,
Chandan Kumar
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
12:32 a.m.
New subject: [Bug 1242886] Review Request: openstack-ironic-inspector - Hardware introspection service for OpenStack Ironic
https://bugzilla.redhat.com/show_bug.cgi?id=1242886
--- Comment #3 from bigswitch <rhosp-bugs-internal(a)bigswitch.com> ---
One more thing. My understanding is that documentation is recommended to be put
to a subpackage.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
2:02 p.m.
New subject: [Bug 1242886] Review Request: openstack-ironic-inspector - Hardware introspection service for OpenStack Ironic
https://bugzilla.redhat.com/show_bug.cgi?id=1242886
John Trowbridge <jtrowbri(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jtrowbri(a)redhat.com
--- Comment #4 from John Trowbridge <jtrowbri(a)redhat.com> ---
Dmitry,
I think we also need a line like the following to provide an upgrade path:
Provides:openstack-ironic-discoverd = 2.1.0-1
https://fedoraproject.org/wiki/Packaging:Guidelines#Renaming.2FReplacing_...
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
3:12 p.m.
New subject: [Bug 1242886] Review Request: openstack-ironic-inspector - Hardware introspection service for OpenStack Ironic
https://bugzilla.redhat.com/show_bug.cgi?id=1242886
Haïkel Guémar <karlthered(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |karlthered(a)gmail.com
--- Comment #5 from Haïkel Guémar <karlthered(a)gmail.com> ---
## blockers
This needs to be fixed and carefully tested!
* John is right, it needs provides for older package name
Provides: openstack-ironic-discover = %{version}-%{release} # needs to be
adapted for delorean though.
Obsoletes: openstack-ironic-discoverd < 1.1.0-3
* I haven't had the time to check but there was a python-ironic-discoverd
subpackage.
a) if it has been splitted, the new package needs to provides/obsoletes it
b) if it's been merged back in main package, main packages needs to
provides/obsoletes it.
From Koji last builds
http://koji.fedoraproject.org/koji/buildinfo?buildID=655063
http://koji.fedoraproject.org/koji/rpminfo?rpmID=6438695
http://koji.fedoraproject.org/koji/rpminfo?rpmID=6438696
To check provides/obsoletes in a rpm package
rpm -qp --provides <rpm>
rpm -qp --provides <rpm>
Some very simple sanity checks:
* install older package then rpm -Uvh new package and see if it fails.
* install new packages and then use yum/dnf to install packages requiring them,
see if it fails.
## Minor changes
* changelog was not updated
* %description should be before %prep
* to reduce diff with delorean packages
=> %{python2_sitelib}/ironic_inspector-*.egg-info
https://www.rdoproject.org/packaging/rdo-packaging.html#_differences_betw...
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
2:46 a.m.
New subject: [Bug 1242886] Review Request: openstack-ironic-inspector - Hardware introspection service for OpenStack Ironic
https://bugzilla.redhat.com/show_bug.cgi?id=1242886
--- Comment #6 from Dmitry Tantsur <dtantsur(a)redhat.com> ---
Note that Provides: python-ironic-discoverd would be a lie: inspector Python
modules are not compatible with discoverd.
Will fix, thanks for reviews!
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
12:16 p.m.
New subject: [Bug 1242886] Review Request: openstack-ironic-inspector - Hardware introspection service for OpenStack Ironic
https://bugzilla.redhat.com/show_bug.cgi?id=1242886
John Trowbridge <jtrowbri(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |CLOSED
Resolution|--- |WONTFIX
Flags|needinfo?(dtantsur(a)redhat.c |
|om) |
Last Closed| |2015-09-11 13:16:14
--- Comment #7 from John Trowbridge <jtrowbri(a)redhat.com> ---
I updated the spec and srpm:
https://trown.fedorapeople.org/openstack-ironic-inspector.spec
https://trown.fedorapeople.org/openstack-ironic-inspector-2.1.0-1.fc24.sr...
and successfully built on koji:
http://koji.fedoraproject.org/koji/taskinfo?taskID=11050634
However, F24+ will no longer include openstack-* services. These will only be
in delorean and Centos.[1]
I have started the process to import this to delorean, and Centos packaging
will be cloned from there, so we can close this as WONTFIX.
[1] https://trello.com/c/wzdl1IlZ/52-openstack-in-fedora
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
3176
days inactive
3235
days old
package-review@lists.fedoraproject.org
9 comments
1 participants
participants (1)
-
Red Hat Bugzilla