https://bugzilla.redhat.com/show_bug.cgi?id=1294717 Orion Poplawski <orion(a)cora.nwra.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1294704 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1294704 [Bug 1294704] Review Request: python3-setuptools - Easily build and distribute Python packages -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1294717 Bug 1294717 depends on bug 1294704, which changed state. Bug 1294704 Summary: Review Request: python3-setuptools - Easily build and distribute Python packages https://bugzilla.redhat.com/show_bug.cgi?id=1294704 What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1294717 --- Comment #2 from Denis Fateyev <denis(a)fateyev.com&gt; --- But python2 isn't installed. The line "%global with_python3 1" is superfluous; the spec needs some update. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1294717 --- Comment #4 from Denis Fateyev <denis(a)fateyev.com&gt; --- Well, just cosmetic changes: 1) Please remove Group tag; 2) Better mention Python version in subpackage descriptions, as with other packages; 3) PKG-INFO has no use there and can be omitted. Please also provide updated spec and srpm package. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1294717 Denis Fateyev <denis(a)fateyev.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #6 from Denis Fateyev <denis(a)fateyev.com&gt; --- Assuming http://www.cora.nwra.com/~orion/fedora/python3-PyYAML-3.11-2.el7.src.rpm as SRPM file. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "MIT/X11 (BSD like)", "Unknown or generated". 80 files have unknown license. Detailed output of licensecheck in /home/mock/sandbox/review/python3-PyYAML/licensecheck.txt [x]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/lib64/python3.4/site- packages/yaml/__pycache__(python3-PyYAML), /usr/lib64/python3.4/site- packages/yaml(python3-PyYAML) Note: not related to epel7. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 51200 bytes in 6 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: No rpmlint messages. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: python3-PyYAML-debuginfo-3.11-2.el7.centos.x86_64.rpm python3-PyYAML-3.11-2.el7.centos.src.rpm 2 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (debuginfo) ------------------- Checking: python3-PyYAML-debuginfo-3.11-2.el7.centos.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- python3-PyYAML-debuginfo.x86_64: W: only-non-binary-in-usr-lib 1 packages and 0 specfiles checked; 0 errors, 1 warnings. Separate "python34-PyYAML-3.11-2.el7.centos.x86_64.rpm" checks: ---------------------------------- rpmlint: python34-PyYAML.x86_64: E: non-standard-executable-perm /usr/lib64/python3.4/site-packages/_yaml.cpython-34m.so 775 1 packages and 0 specfiles checked; 1 errors, 0 warnings. $ rpm -qp --requires python34-PyYAML-3.11-2.el7.centos.x86_64.rpm | sort | uniq -c 1 libc.so.6()(64bit) 1 libc.so.6(GLIBC_2.14)(64bit) 1 libc.so.6(GLIBC_2.2.5)(64bit) 1 libc.so.6(GLIBC_2.4)(64bit) 1 libpthread.so.0()(64bit) 1 libpython3.4m.so.1.0()(64bit) 1 libyaml-0.so.2()(64bit) 1 python(abi) = 3.4 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PartialHardlinkSets) <= 4.0.4-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 1 rtld(GNU_HASH) $ rpm -qp --provides python34-PyYAML-3.11-2.el7.centos.x86_64.rpm | sort | uniq -c 1 python34-PyYAML = 3.11-2.el7.centos 1 python34-PyYAML(x86-64) = 3.11-2.el7.centos 1 python34-yaml = 3.11-2.el7.centos 1 python34-yaml(x86-64) = 3.11-2.el7.centos Source checksums ---------------- http://pyyaml.org/download/pyyaml/PyYAML-3.11.tar.gz : CHECKSUM(SHA256) this package : c36c938a872e5ff494938b33b14aaa156cb439ec67548fcab3535bb78b0846e8 CHECKSUM(SHA256) upstream package : c36c938a872e5ff494938b33b14aaa156cb439ec67548fcab3535bb78b0846e8 Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20 Command line :/usr/bin/fedora-review --rpm-spec -n python3-PyYAML-3.11-2.el7.src.rpm -m epel-7-x86_64 Buildroot used: epel-7-x86_64 Active plugins: Python, Generic, Shell-api Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6 Remarks: -------- Package approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1294717 --- Comment #8 from Fedora Update System <updates(a)fedoraproject.org&gt; --- python3-PyYAML-3.11-2.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-33336b22da -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1294717 Fedora Update System <updates(a)fedoraproject.org&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA --- Comment #9 from Fedora Update System <updates(a)fedoraproject.org&gt; --- python3-PyYAML-3.11-2.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-33336b22da -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1294717 Fedora Update System <updates(a)fedoraproject.org&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed| |2016-02-01 17:55:16 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component