[Bug 1672313] New: Review Request: perl-Perl-PrereqScanner-NotQuiteLite - A tool to scan your Perl code for its prerequisites
8:15 a.m.
https://bugzilla.redhat.com/show_bug.cgi?id=1672313
Bug ID: 1672313
Summary: Review Request: perl-Perl-PrereqScanner-NotQuiteLite -
A tool to scan your Perl code for its prerequisites
Product: Fedora
Version: rawhide
Hardware: All
OS: Linux
Status: NEW
Component: Package Review
Severity: medium
Priority: medium
Assignee: nobody(a)fedoraproject.org
Reporter: paul(a)city-fan.org
QA Contact: extras-qa(a)fedoraproject.org
CC: package-review(a)lists.fedoraproject.org
Target Milestone: ---
Classification: Fedora
Spec URL:
http://subversion.city-fan.org/repos/cfo-repo/perl-Perl-PrereqScanner-Not...
SRPM URL:
http://www.city-fan.org/~paul/extras/perl-Perl-PrereqScanner-NotQuiteLite...
Description:
Perl::PrereqScanner::NotQuiteLite is yet another prerequisites scanner. It
passes almost all the scanning tests for Perl::PrereqScanner and
Module::ExtractUse (i.e. except for a few dubious ones), and runs slightly
faster than PPI-based Perl::PrereqScanner. However, it doesn't run as fast as
Perl::PrereqScanner::Lite (which uses an XS lexer).
Perl::PrereqScanner::NotQuiteLite also recognizes eval. Prerequisites in eval
are not considered as requirements, but you can collect them as suggestions.
Conditional requirements or requirements loaded in a block are treated as
recommends. No-ed modules are stored separately (since 0.94). You may or may
not need to merge them into requires.
Fedora Account System Username: pghmcfc
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
8:15 a.m.
New subject: [Bug 1672313] Review Request: perl-Perl-PrereqScanner-NotQuiteLite -
A tool to scan your Perl code for its prerequisites
https://bugzilla.redhat.com/show_bug.cgi?id=1672313
Paul Howarth <paul(a)city-fan.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Depends On| |1672274
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1672274
[Bug 1672274] Review Request: perl-Regexp-Trie - Build trie-ized regexp
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
8:16 a.m.
New subject: [Bug 1672313] Review Request: perl-Perl-PrereqScanner-NotQuiteLite -
A tool to scan your Perl code for its prerequisites
https://bugzilla.redhat.com/show_bug.cgi?id=1672313
Paul Howarth <paul(a)city-fan.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |1672013
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1672013
[Bug 1672013] perl-Module-CPANTS-Analyse-1.00 is available
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
5:35 a.m.
New subject: [Bug 1672313] Review Request: perl-Perl-PrereqScanner-NotQuiteLite -
A tool to scan your Perl code for its prerequisites
https://bugzilla.redhat.com/show_bug.cgi?id=1672313
Jitka Plesnikova <jplesnik(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
CC| |jplesnik(a)redhat.com
Assignee|nobody(a)fedoraproject.org |jplesnik(a)redhat.com
Flags| |fedora-review?
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
8:06 a.m.
New subject: [Bug 1672313] Review Request: perl-Perl-PrereqScanner-NotQuiteLite -
A tool to scan your Perl code for its prerequisites
https://bugzilla.redhat.com/show_bug.cgi?id=1672313
Jitka Plesnikova <jplesnik(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags|fedora-review? |fedora-review+
--- Comment #1 from Jitka Plesnikova <jplesnik(a)redhat.com> ---
Please correct all 'FIX' issues.
Otherwise the package looks good.
Approved
Source file is ok
Summary is ok
License is ok
Description is ok
Source0 are ok
FIX: Please update URL to use link to metacpan.org
https://metacpan.org/release/Perl-PrereqScanner-NotQuiteLite
All tests passed
BuildRequires are almost ok
FIX: Please add 'perl(if)' - t/Util.pm:12, t/scan/Util.pm:8
$ rpm -qp --requires
perl-Perl-PrereqScanner-NotQuiteLite-0.9903-1.fc30.noarch.rpm | grep -v
'rpmlib' |sort | uniq -c
1 perl(Carp)
1 perl(constant)
1 perl(CPAN::Meta::Prereqs)
1 perl(CPAN::Meta::Requirements)
1 perl(Data::Dump)
1 perl(Exporter) >= 5.57
1 perl(File::Basename)
1 perl(File::Find)
1 perl(File::Spec)
1 perl(Getopt::Long)
1 perl(JSON::PP)
1 perl(lib)
1 perl(:MODULE_COMPAT_5.28.1)
1 perl(Module::CoreList)
1 perl(Module::CPANfile)
1 perl(Module::Find)
1 perl(parent)
1 perl(Perl::PrereqScanner::NotQuiteLite)
1 perl(Perl::PrereqScanner::NotQuiteLite::App)
1 perl(Perl::PrereqScanner::NotQuiteLite::Context)
1 perl(Perl::PrereqScanner::NotQuiteLite::Util)
1 perl(Perl::PrereqScanner::NotQuiteLite::Util::Prereqs)
1 perl(Pod::Usage)
1 perl(Regexp::Trie)
1 perl(strict)
1 perl(warnings)
1 /usr/bin/perl
Binary requires are Ok.
$ rpm -qp --provides
perl-Perl-PrereqScanner-NotQuiteLite-0.9903-1.fc30.noarch.rpm | sort | uniq -c
1 perl(Perl::PrereqScanner::NotQuiteLite) = 0.9903
1 perl-Perl-PrereqScanner-NotQuiteLite = 0.9903-1.fc30
1 perl(Perl::PrereqScanner::NotQuiteLite::App)
1 perl(Perl::PrereqScanner::NotQuiteLite::Context)
1 perl(Perl::PrereqScanner::NotQuiteLite::Parser::Aliased)
1 perl(Perl::PrereqScanner::NotQuiteLite::Parser::AnyMoose)
1 perl(Perl::PrereqScanner::NotQuiteLite::Parser::Autouse)
1 perl(Perl::PrereqScanner::NotQuiteLite::Parser::Catalyst)
1 perl(Perl::PrereqScanner::NotQuiteLite::Parser::ClassAccessor)
1 perl(Perl::PrereqScanner::NotQuiteLite::Parser::ClassAutouse)
1 perl(Perl::PrereqScanner::NotQuiteLite::Parser::ClassLoad)
1 perl(Perl::PrereqScanner::NotQuiteLite::Parser::Core)
1 perl(Perl::PrereqScanner::NotQuiteLite::Parser::Inline)
1 perl(Perl::PrereqScanner::NotQuiteLite::Parser::KeywordDeclare)
1 perl(Perl::PrereqScanner::NotQuiteLite::Parser::Later)
1 perl(Perl::PrereqScanner::NotQuiteLite::Parser::Mixin)
1 perl(Perl::PrereqScanner::NotQuiteLite::Parser::ModuleRuntime)
1 perl(Perl::PrereqScanner::NotQuiteLite::Parser::MojoBase)
1 perl(Perl::PrereqScanner::NotQuiteLite::Parser::Moose)
1 perl(Perl::PrereqScanner::NotQuiteLite::Parser::MooseXDeclare)
1 perl(Perl::PrereqScanner::NotQuiteLite::Parser::Only)
1 perl(Perl::PrereqScanner::NotQuiteLite::Parser::PackageVariant)
1 perl(Perl::PrereqScanner::NotQuiteLite::Parser::Plack)
1 perl(Perl::PrereqScanner::NotQuiteLite::Parser::POE)
1 perl(Perl::PrereqScanner::NotQuiteLite::Parser::Prefork)
1 perl(Perl::PrereqScanner::NotQuiteLite::Parser::Superclass)
1 perl(Perl::PrereqScanner::NotQuiteLite::Parser::Syntax)
1 perl(Perl::PrereqScanner::NotQuiteLite::Parser::SyntaxCollector)
1 perl(Perl::PrereqScanner::NotQuiteLite::Parser::TestClassMost)
1 perl(Perl::PrereqScanner::NotQuiteLite::Parser::TestMore)
1 perl(Perl::PrereqScanner::NotQuiteLite::Parser::TestRequires)
1 perl(Perl::PrereqScanner::NotQuiteLite::Parser::UniversalVersion)
1 perl(Perl::PrereqScanner::NotQuiteLite::Parser::Unless)
1 perl(Perl::PrereqScanner::NotQuiteLite::Tokens)
1 perl(Perl::PrereqScanner::NotQuiteLite::Util)
1 perl(Perl::PrereqScanner::NotQuiteLite::Util::CPANfile)
1 perl(Perl::PrereqScanner::NotQuiteLite::Util::Prereqs)
Binary provides are Ok.
$ rpmlint ./perl-Perl-PrereqScanner-NotQuiteLite*
perl-Perl-PrereqScanner-NotQuiteLite.noarch: W: spelling-error %description -l
en_US ExtractUse -> Extract Use, Extract-use, Extract
perl-Perl-PrereqScanner-NotQuiteLite.noarch: W: spelling-error %description -l
en_US eval -> veal, vela, val
perl-Perl-PrereqScanner-NotQuiteLite.src: W: spelling-error %description -l
en_US ExtractUse -> Extract Use, Extract-use, Extract
perl-Perl-PrereqScanner-NotQuiteLite.src: W: spelling-error %description -l
en_US eval -> veal, vela, val
2 packages and 1 specfiles checked; 0 errors, 4 warnings.
Rpmlint is ok
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
8:14 a.m.
New subject: [Bug 1672313] Review Request: perl-Perl-PrereqScanner-NotQuiteLite -
A tool to scan your Perl code for its prerequisites
https://bugzilla.redhat.com/show_bug.cgi?id=1672313
--- Comment #2 from Jitka Plesnikova <jplesnik(a)redhat.com> ---
The 'Suggests' is not supported in EPEL 6/7
perl-Perl-PrereqScanner-NotQuiteLite.spec:Line 50
Suggests: perl(CPAN::Common::Index)
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
8:30 a.m.
New subject: [Bug 1672313] Review Request: perl-Perl-PrereqScanner-NotQuiteLite -
A tool to scan your Perl code for its prerequisites
https://bugzilla.redhat.com/show_bug.cgi?id=1672313
--- Comment #3 from Paul Howarth <paul(a)city-fan.org> ---
(In reply to Jitka Plesnikova from comment #2)
The 'Suggests' is not supported in EPEL 6/7
perl-Perl-PrereqScanner-NotQuiteLite.spec:Line 50
Suggests: perl(CPAN::Common::Index)
I know; we don't have ExtUtils::MakeMaker::CPANfile there either so I'm only
targeting f29/f30 with this package.
Accordingly, I'll update the flow to use %make_build/%make_install too.
Thanks for the review Jitka.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
8:40 a.m.
New subject: [Bug 1672313] Review Request: perl-Perl-PrereqScanner-NotQuiteLite -
A tool to scan your Perl code for its prerequisites
https://bugzilla.redhat.com/show_bug.cgi?id=1672313
--- Comment #4 from Gwyn Ciesla <limburgher(a)gmail.com> ---
(fedscm-admin): The Pagure repository was created at
https://src.fedoraproject.org/rpms/perl-Perl-PrereqScanner-NotQuiteLite
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
10:06 a.m.
New subject: [Bug 1672313] Review Request: perl-Perl-PrereqScanner-NotQuiteLite -
A tool to scan your Perl code for its prerequisites
https://bugzilla.redhat.com/show_bug.cgi?id=1672313
Fedora Update System <updates(a)fedoraproject.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |MODIFIED
--- Comment #5 from Fedora Update System <updates(a)fedoraproject.org> ---
perl-Perl-PrereqScanner-NotQuiteLite-0.9903-2.fc29 perl-Regexp-Trie-0.02-2.fc29
has been submitted as an update to Fedora 29.
https://bodhi.fedoraproject.org/updates/FEDORA-2019-2e81a7f560
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
10:06 a.m.
New subject: [Bug 1672313] Review Request: perl-Perl-PrereqScanner-NotQuiteLite -
A tool to scan your Perl code for its prerequisites
https://bugzilla.redhat.com/show_bug.cgi?id=1672313
--- Comment #6 from Fedora Update System <updates(a)fedoraproject.org> ---
perl-Perl-PrereqScanner-NotQuiteLite-0.9903-2.fc29 perl-Regexp-Trie-0.02-2.fc29
has been submitted as an update to Fedora 29.
https://bodhi.fedoraproject.org/updates/FEDORA-2019-2e81a7f560
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
10:27 p.m.
New subject: [Bug 1672313] Review Request: perl-Perl-PrereqScanner-NotQuiteLite -
A tool to scan your Perl code for its prerequisites
https://bugzilla.redhat.com/show_bug.cgi?id=1672313
Fedora Update System <updates(a)fedoraproject.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|MODIFIED |ON_QA
--- Comment #7 from Fedora Update System <updates(a)fedoraproject.org> ---
perl-Perl-PrereqScanner-NotQuiteLite-0.9903-2.fc29,
perl-Regexp-Trie-0.02-2.fc29 has been pushed to the Fedora 29 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2019-2e81a7f560
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
7:24 p.m.
New subject: [Bug 1672313] Review Request: perl-Perl-PrereqScanner-NotQuiteLite -
A tool to scan your Perl code for its prerequisites
https://bugzilla.redhat.com/show_bug.cgi?id=1672313
Bug 1672313 depends on bug 1672274, which changed state.
Bug 1672274 Summary: Review Request: perl-Regexp-Trie - Build trie-ized regexp
https://bugzilla.redhat.com/show_bug.cgi?id=1672274
What |Removed |Added
----------------------------------------------------------------------------
Status|ON_QA |CLOSED
Resolution|--- |ERRATA
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
8:03 p.m.
New subject: [Bug 1672313] Review Request: perl-Perl-PrereqScanner-NotQuiteLite -
A tool to scan your Perl code for its prerequisites
https://bugzilla.redhat.com/show_bug.cgi?id=1672313
Fedora Update System <updates(a)fedoraproject.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ON_QA |CLOSED
Resolution|--- |ERRATA
Last Closed| |2019-02-18 02:03:47
--- Comment #8 from Fedora Update System <updates(a)fedoraproject.org> ---
perl-Perl-PrereqScanner-NotQuiteLite-0.9903-2.fc29,
perl-Regexp-Trie-0.02-2.fc29 has been pushed to the Fedora 29 stable
repository. If problems still persist, please make note of it in this bug
report.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
1929
days inactive
1943
days old
package-review@lists.fedoraproject.org
12 comments
1 participants
participants (1)
-
bugzilla＠redhat.com