https://bugzilla.redhat.com/show_bug.cgi?id=967333 --- Comment #1 from Anuj More <anujmorex(a)gmail.com&gt; --- Builds on mock: https://raw.github.com/execat/Packages/master/rpmspecs/rubygem-code_analy... rpmlint does not complain: 3 packages and 0 specfiles checked; 0 errors, 0 warnings. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ToR2YuX7nM&a=cc_unsubscribe

https://bugzilla.redhat.com/show_bug.cgi?id=967333 --- Comment #3 from Josef Stribny <jstribny(a)redhat.com&gt; --- * mark LICENSE as %doc * move README.md to the -doc sub-package - it's not needed at runtime * move Gemfile and Rakefile to -doc sub-package rather than excluding them * fix Summary "Helps build custom code analyzer tools" sounds a bit better to me. But please put the summary as a short description here in Bugzilla next time so it's the same as in spec. * fix Description (missing "which IS") - e.g.: The code analyzer tool which is extracted from rails_best_practices helps you easily build your own tool for code analysis. Otherwise, it builds and runs just fine. Please fix the spec file so I can approve. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=TMFEJSz1zA&a=cc_unsubscribe

https://bugzilla.redhat.com/show_bug.cgi?id=967333 Josef Stribny <jstribny(a)redhat.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review+ --- Comment #5 from Josef Stribny <jstribny(a)redhat.com&gt; --- Looks good now. 2 minor things that would be nice to do: * Description of -doc sub-package should end with a dot "." as a normal English sentence, please add it. * Be more specific when listing files %doc %{gem_instdir}/*.gemspec > %doc %{gem_instdir}/%{gem_name}.gemspec Since those are not blockers I APPROVE this package. Please fix above mentioned issues before pushing. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=4Ot589E45e&a=cc_unsubscribe

https://bugzilla.redhat.com/show_bug.cgi?id=967333 John Skeoch <jskeoch(a)redhat.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|jstribny(a)redhat.com |hhorak(a)redhat.com -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=967333 Vít Ondruch <vondruch(a)redhat.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |NOTABUG Flags|fedora-review+ | |needinfo?(anujmorex(a)gmail.c | |om) | Last Closed| |2016-01-04 03:55:48 --- Comment #7 from Vít Ondruch <vondruch(a)redhat.com&gt; --- Closing this stalled review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component