[Bug 333471] New: Review Request: gnome-packagekit - gnome applications for PackageKit - package-review

List overview All Threads
Download

newer

[Bug 333471] New: Review Request: gnome-packagekit - gnome applications for PackageKit

older

[Bug 289681] New: Review Request:...

[Bug 177747] Review Request:...

Red Hat Bugzilla

16 Oct 2007 16 Oct '07

5:15 a.m.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

https://bugzilla.redhat.com/show_bug.cgi?id=333471

Summary: Review Request: gnome-packagekit - gnome applications for PackageKit Product: Fedora Version: devel Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: rnorwood@redhat.com QAContact: extras-qa@fedoraproject.org CC: fedora-package-review@redhat.com,notting@redhat.com

Spec URL: http://people.redhat.com/rnorwood/rpms/gnome-packagekit.spec SRPM URL: http://people.redhat.com/rnorwood/rpms/gnome-packagekit-0.1.0-1.fc8.src.rpm Description: packagekit-gnome provides session applications for the PackageKit API. There are several utilities designed for installing, updating and removing packages on your system.

This requires PackageKit: https://bugzilla.redhat.com/show_bug.cgi?id=333451

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Show replies by date

Red Hat Bugzilla

16 Oct 16 Oct

5:26 a.m.

New subject: [Bug 333471] Review Request: gnome-packagekit - gnome applications for PackageKit

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: gnome-packagekit - gnome applications for PackageKit

https://bugzilla.redhat.com/show_bug.cgi?id=333471

peter@thecodergeek.com changed:

What |Removed |Added ---------------------------------------------------------------------------- BugsThisDependsOn| |333451

------- Additional Comments From peter@thecodergeek.com 2007-10-16 00:26 EST ------- Setting PackageKit bug dependency.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

11:28 a.m.

New subject: [Bug 333471] Review Request: gnome-packagekit - gnome applications for PackageKit

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: gnome-packagekit - gnome applications for PackageKit

https://bugzilla.redhat.com/show_bug.cgi?id=333471

panemade@gmail.com changed:

------- Additional Comments From panemade@gmail.com 2007-10-16 06:28 EST ------- Preliminary review => 1)I will suggest to have this package named as gnome-PackageKit. 2) Use of make should be as given in http://fedoraproject.org/wiki/Packaging/Guidelines#head-525c7d76890cb22df33b... 3) defattr should be defattr(-,root,root,-) 4) Remove following line from SPEC from %files section %{_datadir}/gnome-packagekit/pk-*.glade 5)You should install all .desktop files as given in http://fedoraproject.org/wiki/Packaging/Guidelines#head-254ddf07aae20a23ced8...

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

9:13 p.m.

New subject: [Bug 333471] Review Request: gnome-packagekit - gnome applications for PackageKit

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: gnome-packagekit - gnome applications for PackageKit

https://bugzilla.redhat.com/show_bug.cgi?id=333471

------- Additional Comments From rnorwood@redhat.com 2007-10-16 16:13 EST ------- Thanks again for the nice review:

1) Nope. The upstream tarball is named gnome-packagekit, and in the absence of any guidelines or consistancy for naming gnome addons, I'd rather just match the upstream tarball. 2) Oops...fixed. 3) Fixed 4) Fixed 5) Fixed

Also, fixed the License tag: GPLv2+

http://people.redhat.com/rnorwood/rpms/gnome-packagekit.spec http://people.redhat.com/rnorwood/rpms/gnome-packagekit-0.1.0-2.fc8.src.rpm

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

17 Oct 17 Oct

4:41 a.m.

New subject: [Bug 333471] Review Request: gnome-packagekit - gnome applications for PackageKit

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: gnome-packagekit - gnome applications for PackageKit

https://bugzilla.redhat.com/show_bug.cgi?id=333471

------- Additional Comments From panemade@gmail.com 2007-10-16 23:41 EST ------- Package looks ok. waiting for PackageKit updates now.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

23 Oct 23 Oct

5:14 p.m.

New subject: [Bug 333471] Review Request: gnome-packagekit - gnome applications for PackageKit

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: gnome-packagekit - gnome applications for PackageKit

https://bugzilla.redhat.com/show_bug.cgi?id=333471

------- Additional Comments From rnorwood@redhat.com 2007-10-23 12:14 EST ------- Here are new packages to go with the new upstream version:

http://people.redhat.com/rnorwood/rpms/gnome-packagekit.spec http://people.redhat.com/rnorwood/rpms/gnome-packagekit-0.1.1-1.fc8.src.rpm

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

26 Oct 26 Oct

5:32 a.m.

New subject: [Bug 333471] Review Request: gnome-packagekit - gnome applications for PackageKit

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: gnome-packagekit - gnome applications for PackageKit

https://bugzilla.redhat.com/show_bug.cgi?id=333471

panemade@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+

------- Additional Comments From panemade@gmail.com 2007-10-26 00:32 EST ------- Review: + package builds in mock (development i386). + rpmlint is silent for SRPM and RPM. + source files match upstream. dfd4118a5980bac647660491fcc3698a gnome-packagekit-0.1.1.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is small so no need of -doc subpackage. + BuildRequires are proper. + Compiler flags are honoured correctly. + defattr usage is correct. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code. + no static libraries. + no .pc files are present. + no -devel subpackage exists. + no .la files. + translations are available. + Does owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. + scrollkeeper, Gconf, update-dekstop-database, update-gtk-icon-cache scriptlets are used. + package gnome-packagekit-0.1.1-1.fc8 -> Provides: config(gnome-packagekit) = 0.1.1-1.fc8 Requires: config(gnome-packagekit) = 0.1.1-1.fc8 dbus-glib >= 0.61 dbus-x11 >= 0.61 gnome-icon-theme gtk2 >= 2.10.0 libORBit-2.so.0 libatk-1.0.so.0 libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.3.4) libc.so.6(GLIBC_2.4) libcairo.so.2 libdbus-1.so.3 libdbus-glib-1.so.2 libdl.so.2 libgconf-2.so.4 libgdk-x11-2.0.so.0 libgdk_pixbuf-2.0.so.0 libglade-2.0.so.0 libglib-2.0.so.0 libgmodule-2.0.so.0 libgobject-2.0.so.0 libgthread-2.0.so.0 libgtk-x11-2.0.so.0 libnotify >= 0.4.3 libnotify.so.1 libpackagekit.so.2 libpango-1.0.so.0 libpangocairo-1.0.so.0 libpthread.so.0 librt.so.1 libxml2.so.2 rtld(GNU_HASH)

+ GUI app.

APPROVED.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

30 Oct 30 Oct

6:10 p.m.

New subject: [Bug 333471] Review Request: gnome-packagekit - gnome applications for PackageKit

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: gnome-packagekit - gnome applications for PackageKit

https://bugzilla.redhat.com/show_bug.cgi?id=333471

rnorwood@redhat.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?

------- Additional Comments From rnorwood@redhat.com 2007-10-30 14:10 EST ------- Huh. I guess I missed that this was approved several days ago. Let's do a CVS request, shall we?

Oh, and thanks again for the review(s), Parag!

New Package CVS Request ======================= Package Name: gnome-packagekit Short Description: GNOME applications for PackageKit Owners: rnorwood Branches: devel InitialCC: Cvsextras Commits:

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

11:12 p.m.

New subject: [Bug 333471] Review Request: gnome-packagekit - gnome applications for PackageKit

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: gnome-packagekit - gnome applications for PackageKit

https://bugzilla.redhat.com/show_bug.cgi?id=333471

kevin@tummy.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+

------- Additional Comments From kevin@tummy.com 2007-10-30 19:12 EST ------- cvs done.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

5 Nov 5 Nov

8:57 p.m.

New subject: [Bug 333471] Review Request: gnome-packagekit - gnome applications for PackageKit

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: gnome-packagekit - gnome applications for PackageKit

https://bugzilla.redhat.com/show_bug.cgi?id=333471

Bug 333471 depends on bug 333451, which changed state.

Bug 333451 Summary: Review Request: PackageKit - Package management with dbus and policykit https://bugzilla.redhat.com/show_bug.cgi?id=333451

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

6 Nov 6 Nov

4 p.m.

New subject: [Bug 333471] Review Request: gnome-packagekit - gnome applications for PackageKit

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: gnome-packagekit - gnome applications for PackageKit

https://bugzilla.redhat.com/show_bug.cgi?id=333471

rnorwood@redhat.com changed:

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

6080

Age (days ago)

6101

Last active (days ago)

package-review@lists.fedoraproject.org

10 comments

1 participants

tags (0)

participants (1)

Red Hat Bugzilla