[Bug 1780823] New: Review Request: librinutils-devel - headers-only c11/gnu11 used in Shlomi Fish's C projects
5:14 a.m.
https://bugzilla.redhat.com/show_bug.cgi?id=1780823
Bug ID: 1780823
Summary: Review Request: librinutils-devel - headers-only
c11/gnu11 used in Shlomi Fish's C projects
Product: Fedora
Version: rawhide
Hardware: All
OS: Linux
Status: NEW
Component: Package Review
Severity: medium
Priority: medium
Assignee: nobody(a)fedoraproject.org
Reporter: shlomif(a)shlomifish.org
QA Contact: extras-qa(a)fedoraproject.org
CC: package-review(a)lists.fedoraproject.org
Target Milestone: ---
Classification: Fedora
Spec URL: https://www.shlomifish.org/Files/files/code/librinutils-devel.spec
SRPM URL:
https://www.shlomifish.org/Files/files/arcs/librinutils-devel-0.1.4-1.fc3...
Description: librinutils-devel - headers-only c11/gnu11 used in Shlomi Fish's C
projects. Extracted as a separate lib for fedora/etc. policy.
Fedora Account System Username: shlomif
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
5:36 p.m.
New subject: [Bug 1780823] Review Request: librinutils-devel - headers-only
c11/gnu11 used in Shlomi Fish's C projects
https://bugzilla.redhat.com/show_bug.cgi?id=1780823
Robert-André Mauchin <zebob.m(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |zebob.m(a)gmail.com
Doc Type|--- |If docs needed, set a value
--- Comment #1 from Robert-André Mauchin <zebob.m(a)gmail.com> ---
- Not needed:
rm -rf %buildroot
%defattr(-,root,root)
- Please use macro here:
%{_includedir}/%{basen}/*.h
- Please use librinutils as base package and add a -devel subpackage and add a
Provides: librinutils-static = %{version}-%{release}
See
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_packaging_hea...
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
11:04 p.m.
New subject: [Bug 1780823] Review Request: librinutils-devel - headers-only
c11/gnu11 used in Shlomi Fish's C projects
https://bugzilla.redhat.com/show_bug.cgi?id=1780823
--- Comment #2 from Shlomi Fish <shlomif(a)shlomifish.org> ---
(In reply to Robert-André Mauchin from comment #1)
- Not needed:
rm -rf %buildroot
%defattr(-,root,root)
- Please use macro here:
%{_includedir}/%{basen}/*.h
- Please use librinutils as base package and add a -devel subpackage and
add a
Provides: librinutils-static = %{version}-%{release}
See
https://docs.fedoraproject.org/en-US/packaging-guidelines/
#_packaging_header_only_libraries
Thanks! But for the life of me I cannot figure out how to make the main package
"BuildArch: noarch" and the -devel package "BuildArch:
"-plat-dependent.
rpmlint warns on both cases where both are the same.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
12:14 a.m.
New subject: [Bug 1780823] Review Request: librinutils-devel - headers-only
c11/gnu11 used in Shlomi Fish's C projects
https://bugzilla.redhat.com/show_bug.cgi?id=1780823
--- Comment #3 from Shlomi Fish <shlomif(a)shlomifish.org> ---
(In reply to Shlomi Fish from comment #2)
(In reply to Robert-André Mauchin from comment #1)
> - Not needed:
>
> rm -rf %buildroot
>
> %defattr(-,root,root)
>
> - Please use macro here:
>
> %{_includedir}/%{basen}/*.h
>
> - Please use librinutils as base package and add a -devel subpackage and
> add a
>
> Provides: librinutils-static = %{version}-%{release}
>
> See
> https://docs.fedoraproject.org/en-US/packaging-guidelines/
> #_packaging_header_only_libraries
Thanks! But for the life of me I cannot figure out how to make the main
package "BuildArch: noarch" and the -devel package "BuildArch:
"-plat-dependent. rpmlint warns on both cases where both are the same.
Figured it out by looking at the cereal package (dnf info FTW). Anyway:
https://www.shlomifish.org/Files/files/arcs/librinutils-0.1.4-1.fc32.src.rpm
and
https://www.shlomifish.org/Files/files/code/librinutils.spec .
Thanks!
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
8:23 a.m.
New subject: [Bug 1780823] Review Request: librinutils-devel - headers-only
c11/gnu11 used in Shlomi Fish's C projects
https://bugzilla.redhat.com/show_bug.cgi?id=1780823
--- Comment #4 from Robert-André Mauchin <zebob.m(a)gmail.com> ---
- Just use:
%package devel
- Why did you make the headers noarch? The link I sent you explicitly says the
opposite:
Do not use noarch
It may be tempting to make the header library package noarch, since the header
files themselves are simply text. However, a library should have tests which
should be run on all architectures. Also, the install process may modify the
installed headers depending on the build architecture. For these reasons,
header-only packages must not be marked noarch.
- Also why not name it rinutils instead of librinutils? Using lib- prefix is a
Debianesque way of doing.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
12:52 p.m.
New subject: [Bug 1780823] Review Request: librinutils-devel - headers-only
c11/gnu11 used in Shlomi Fish's C projects
https://bugzilla.redhat.com/show_bug.cgi?id=1780823
--- Comment #5 from Shlomi Fish <shlomif(a)shlomifish.org> ---
(In reply to Robert-André Mauchin from comment #4)
- Just use:
%package devel
- Why did you make the headers noarch? The link I sent you explicitly says
the opposite:
Do not use noarch
It may be tempting to make the header library package noarch, since the
header files themselves are simply text. However, a library should have
tests which should be run on all architectures. Also, the install process
may modify the installed headers depending on the build architecture. For
these reasons, header-only packages must not be marked noarch.
- Also why not name it rinutils instead of librinutils? Using lib- prefix
is a Debianesque way of doing.
Fixed here:
* https://www.shlomifish.org/Files/files/code/rinutils.spec
* https://www.shlomifish.org/Files/files/arcs/rinutils-0.1.4-1.fc32.src.rpm
Thanks!
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
9:09 a.m.
New subject: [Bug 1780823] Review Request: librinutils-devel - headers-only
c11/gnu11 used in Shlomi Fish's C projects
https://bugzilla.redhat.com/show_bug.cgi?id=1780823
--- Comment #6 from Robert-André Mauchin <zebob.m(a)gmail.com> ---
Provides: lib%{basen}-static = %{version}-%{release}
→
Provides: %{basen}-static = %{version}-%{release}
- Also you must install the LICERSE file with %license in %ifiles:
%license LICENSE
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
2:10 a.m.
New subject: [Bug 1780823] Review Request: librinutils-devel - headers-only
c11/gnu11 used in Shlomi Fish's C projects
https://bugzilla.redhat.com/show_bug.cgi?id=1780823
--- Comment #7 from Shlomi Fish <shlomif(a)shlomifish.org> ---
(In reply to Shlomi Fish from comment #5)
(In reply to Robert-André Mauchin from comment #4)
> - Just use:
>
> %package devel
>
> - Why did you make the headers noarch? The link I sent you explicitly says
> the opposite:
>
> Do not use noarch
>
> It may be tempting to make the header library package noarch, since the
> header files themselves are simply text. However, a library should have
> tests which should be run on all architectures. Also, the install process
> may modify the installed headers depending on the build architecture. For
> these reasons, header-only packages must not be marked noarch.
>
>
> - Also why not name it rinutils instead of librinutils? Using lib- prefix
> is a Debianesque way of doing.
Fixed here:
Thanks Robert! Should be fixed here (same place):
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
6:43 p.m.
New subject: [Bug 1780823] Review Request: librinutils-devel - headers-only
c11/gnu11 used in Shlomi Fish's C projects
https://bugzilla.redhat.com/show_bug.cgi?id=1780823
Robert-André Mauchin <zebob.m(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |POST
Assignee|nobody(a)fedoraproject.org |zebob.m(a)gmail.com
Flags| |fedora-review+
--- Comment #8 from Robert-André Mauchin <zebob.m(a)gmail.com> ---
Package approved.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
1:31 p.m.
New subject: [Bug 1780823] Review Request: rinutils - headers-only c11/gnu11 used
in Shlomi Fish's C projects
https://bugzilla.redhat.com/show_bug.cgi?id=1780823
Shlomi Fish <shlomif(a)shlomifish.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|Review Request: |Review Request: rinutils -
|librinutils-devel - |headers-only c11/gnu11 used
|headers-only c11/gnu11 used |in Shlomi Fish's C projects
|in Shlomi Fish's C projects |
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
2:46 p.m.
New subject: [Bug 1780823] Review Request: rinutils - headers-only c11/gnu11 used
in Shlomi Fish's C projects
https://bugzilla.redhat.com/show_bug.cgi?id=1780823
--- Comment #9 from Gwyn Ciesla <gwync(a)protonmail.com> ---
(fedscm-admin): The Pagure repository was created at
https://src.fedoraproject.org/rpms/rinutils
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
7:25 p.m.
New subject: [Bug 1780823] Review Request: rinutils - headers-only c11/gnu11 used
in Shlomi Fish's C projects
https://bugzilla.redhat.com/show_bug.cgi?id=1780823
Elliott Sales de Andrade <quantum.analyst(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|POST |CLOSED
CC| |quantum.analyst(a)gmail.com
Fixed In Version| |rinutils-0.1.4-1.fc32
Resolution|--- |CURRENTRELEASE
Last Closed| |2020-08-03 00:25:50
--- Comment #10 from Elliott Sales de Andrade <quantum.analyst(a)gmail.com> ---
Please close your Review Requests when they are complete.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
1362
days inactive
1602
days old
package-review@lists.fedoraproject.org
11 comments
1 participants
participants (1)
-
bugzilla＠redhat.com